PLassist.mac Now with INI support

[Draconis]

Ok tried to rework it with new changes, but for some reason it wont cast now. The vars are set and the chat channel says it is casting the right spell I asked for. but it just stands for a few secs then sits down. anyways new code here did I screw something up? it looks like /call cast is not working for somereason.

also when using the give buff 1 <whatevername> MQ says there are no spawns matching any (1-100) <whatevername> even if they are standing right next to me.

EDIT: ok found the cast problem have to add " " around the

Code: Select all

${Buff[${buffnumber}]} 

code or it wont work, the give buff command is still broke, it seems to be adding a

Code: Select all

 ' 

after the name and comming up with no results for <whatevername'> not sure how to fix that yet.

Code: Select all

Newist code in 1st post

[aChallenged1]

I haven't looked, but I would consider looking to be sure you did not mispell something.

[Fluffy]

To fix the ' at the end

Just change

Code: Select all

#event Buffother "#*#Give Buff #1# #2#"

to

Code: Select all

#event Buffother "#*#Give Buff #1# #2#'"

That should fix that problem.

[Draconis]

Ok more changes

* Ini support for buffs and most vars.
* Sit is now a var
* Casts your mount at the start of the macro *(Not tested as I dont have a horse, Should work though)
* Give buff command tweaked now say "Give buff <whatever buff> <whatever target>

First post updated.

[Fluffy]

Ok for the mount thing I think you should change it to not just cast it but rather allow them to call for it or call for dismount. To allow for following and such a little better... So the following changes would allow for a little more control over that

In your events add in something like

Code: Select all

#event Mountup "#*#Mount on#*#" 
#event Dismount "#*#Mount off#*#

Then add in the follow functions

Code: Select all

Sub Event_Mountup()
/if (${havemount}) {
    /1 Mounting my horse/drogmor
    /call Cast "${mount}" item 3s 
    /return
    }
/1 Sorry I dont have a mount/drogmor edit ini to reflect if I do
/return

Sub Event_Dismount()
/1 Dismount my horse/drogmor
/dismount
/return

That should allow for you to command that portion of it and allow them to call when to mount or not... And I would also change

Code: Select all

#event mountfail "You can not summon a mount here."

|                                          | 
|------------------------------------------| 
|                                          | 
Sub Event_mountfail 
/1 Cant cast a mount here moving on.. 
/goto :loop 
/return 
|                                          | 
|------------------------------------------| 
|                                          | 

That shit is broken and wont work.. Remember you are making a call to it. So you dont need to /goto with it. It will return back from the call to right where it was called... So I would change it to be simply

Code: Select all

#event mountfail "You can not summon a mount here."

Sub Event_mountfail()
/1 Can't cast a mount here
/return

[Draconis]

ah ok, I did not have the /goto :loop in there at first but in my sleep deprived state I thought It might end up just looping over it self if you have a mount and it failed to cast.

EDIT:

Ok changes made, 1st post edited. With all the new changes Im running out of ideas for it to do. Other than maybe a "help im getting my ass kicked" command that would have bot assist and attack masters target untill it died then return to the last spot it was sitting at. Although that will take alot of digging through other macros to see hows its done, RH for movement code, and so on. So ill work on that later I think.

Any other suggestions / additions pile em up more practice the better lol.

[Fluffy]

ah ok, I did not have the /goto :loop in there at first but in my sleep deprived state I thought It might end up just looping over it self if you have a mount and it failed to cast.

EDIT:

Ok changes made, 1st post edited. With all the new changes Im running out of ideas for it to do. Other than maybe a "help im getting my ass kicked" command that would have bot assist and attack masters target untill it died then return to the last spot it was sitting at. Although that will take alot of digging through other macros to see hows its done, RH for movement code, and so on. So ill work on that later I think.

Any other suggestions / additions pile em up more practice the better lol.

Well the next thing you should look at is converting your command structure to something more scalable.. And add a few more features to that... Like a Allowed Masters list.. Right now any idiot who says the commands will cause him to cast.. That is not good in my book. You are doing event parsing which most people first do when they are learning.. Now you need to convert that to something with more structure.. See if you can get that done.. And when you get stuck let me know and I will help you along with that..

[Draconis]

ok checking for master would proably be a good idea. would get rid of this bug I found the other day, when ever this monk FDed and failed the fail message soandso has fallen to the ground, made the bot stand up, no Idea why though.

[fallon]

Now, I want to know, how do I tell it to look for and write to and create new INI files in another/specific folder other than the macro folder; as in c:/mq2/release/macros/ini, I'd really appriciate knowing.

Code: Select all

/if(!${Ini[SomeSubDir\plassist.ini,Configuration,VERSION]} ) /call Save_New_Config

Puts plassist.ini in Macros\SomeSubDir if I remember right. I'll have to check one of the macros I have at home for sure. You can do that with .inc files too and clean up your macros dir.

[Mattr35]

Everything works great... but the macro locks on to my target's pet. Its a beastlord pet, so I know it is seeing the toons name... Fluffy's Warder even though I told it to /mac plassist fluffy.

Any idea how to get it to ignore the pet?

[aChallenged1]

I've had that problem with a few macro's when it comes to BST and their pets. Thinking the only real fix would be for a change to the code so that it uses the PC's ID instead of name.

[fearless]

/target pc fluffy

When you do just /target fluffy it target's the closest thing that matches . . . most often the pet I would guess.

Change the macro to include the "pc" from above and it should fix your problem, though you may no longer heal pets.