Genbot Version 12 Ready

[bollox]

Thanks for the addition of checknames, LordGiddion-- it works great :)

Dulapore, gus, thanks for the heads up. I was looking at the wrong genbot version and had no idea it was already there. *flogs self with RTFM cat-o-nine tails*

In botspell.inc : WaitForCast you set CTimer incorrectly:

Code: Select all

   /varset CTimer "${CastTime}"s

Will not work. You are illegally passing a string to a timer variable.

Code: Select all

   /varset CTimer ${Math.Calc[${CastTime}*10]}

Will set CTimer with an int.

[fez_ajer]

bothealer.inc (272)

Code: Select all

/if (${Target.ID}!=${TarID}) /target id ${[color=red]TarID[/color]}

Seems to be working MUCH better now.

[omper]

got a problem when i type /tell botname buff temperance on me

i get varset failed

and end of macro..

i dont know where to get the log or i would post the entire msg.. cuz its long

edit something about bufflist

[mycodesux]

I cant even get the bot to tell me its mana
I type /tell botname mana
it crashes

says cant find sub evac

looking at the excommand area seems like array1 and array 2 arent the same
It also doesnt have the do- on it either

How the hell do you people say your working

[Rassilon]

How the hell do you people say your working

Not saying its ALL working. Various things are working to some degree or another and other things are not even close but its not completely fixed. As more ppl find bugs and post the errors in here then the better LG can locate these bugs if he can mimic the errors you have.

Thanks

[omper]

hey mycode


make sure you are up to date on everything including MQ2.. if not you will have more probs

[healbot]

every time i run this on my bot, i get back

Subroutine Init-Personal wasnt found

*edit* figured out the problem, didnt get the new personal.inc after LG had said they werent to be posted, heh. after that it's running fine so far

[fez_ajer]

Gid's got a rough weekend coming up so he's not likely to be posting fixes. In the mean time, I know the code will work (for the most part) with the tweaks listed here in the past few posts.

Until Gid gets some free time the best thing you can do is:

1) Be 150% sure you have the latest MQ from the zip compiled and installed correctly

2) Make sure you have the latest macro files from the first page of this thread

3) Find the last post from Gid saying he just posted a new version, then move forward applying all of the bug fixes people submitted. At some point things should approach sanity

[fez_ajer]

bothealer.inc (269)

Code: Select all

/if (${[color=red]TarID[/color]}==${Me.ID}) {

botspell.inc (84)

Code: Select all

/varset DelayBeforeSit ${Ini[${IniFile},[color=red]Core,[/color]DelayBeforeSit,NotFound]}

[Chant3r]

Hey I am getting "Subroutine main not found" .


I can only find problems I dont; know how to fix em :) .

Getting back on my short bus vrooom vroom

[Gerald]

I mostly use genbot for autofollow. When I copied the newest version down today that no longer worked - it would be straight to me instead of following my path and once it caught up to me once it would get stuck and just face me and not move.

After fixing the obvious typos still in the code (recommend using an editor that highlights those for you), I eventually worked out why follow wasn't working... It was defaulting to "FollowMode 1" which is the old mode I think and not working right.

OK, so I changed the ini to use FollowMode 2 (advpath follow), but then it just says "Unable to follow XXX". So I fixed that too. Then I changed the code so it sets the mode to default to 2 for new INI files, cause why would anyone want to use the old broken version?

Then I noticed MoveTo had the same problems so I changed those parts as well.

Note that for this fix to work you need to delete your old char's INI file or manually change FollowMode and MoveToMode in it to "2" instead of "1".

Here are all the changes I made:

Typos:

botcore.inc (12.25):

Added braces:

Code: Select all

Sub Do-FollowMode
   /if (!${Defined[Param0][color=red]}[/color]) /return
   /varset FollowMode ${Param0}
/return

Sub Do-MoveToMode
   /if (!${Defined[Param0][color=red]}[/color]) /return
   /varset MoveToMode ${Param0}
/return

bothealer.inc (12.23):

Added ending quote:

Code: Select all

Sub Do-settankheal
   /if (!${Defined[Param0]}) {
      /call ChatOut 3 ${MasterName} "My tank heal is ${TankSpell}[color=red]"[/color]
      /return
   }
   /varset TankSpell "${CommandParam}"
   /call ChatOut 3 ${MasterName} "I'll use ${TankSpell} to heal tanks."
/return

bothealer.inc (12.24):

Removed this extra brace:

Code: Select all

   /varset TankList ${Ini[${IniFile},Healer,TankList,NotFound]} 
   /varset CasterList ${Ini[${IniFile},Healer,CasterList,NotFound]} 
   /if (${TankList.Equal[NotFound]} && ${CasterList.Equal[NotFound]}) { 
         /ini ${IniFile} Healer TankList "Warrior|Shadow Knight|Paladin|Monk|Beastlord|Ranger|Shaman|Berserker" 
         /ini ${IniFile} Healer CasterList "Necromancer|Wizard|Enchanter|Magician|Rogue|Druid|Cleric|Bard" 
         /ini ${IniFile} Healer  
      [color=red]}[/color]
   } 
/return 

botcore.ini (12.25):

Fixes to FollowMode/MoveToMode default settings:

Code: Select all

   /varset FollowMode ${Ini[${IniFile},Core,FollowMode,1]}
   /if (${FollowMode}==1) {
      /ini ${IniFile} Core FollowMode [color=red]2[/color]
      /varset FollowMode [color=red]2[/color]
   }
   /varset MoveToMode ${Ini[${IniFile},Core,MoveToMode,1]}
   /if (${MoveToMode}==1) {
      /ini ${IniFile} Core MoveToMode [color=red]2[/color]
      /varset MoveToMode [color=red]2[/color]
   }

Fix to actually using FollowMode 2:

Code: Select all

   /if (${FollowMode}==2) {
      [color=red]/target ${FollowTarget}[/color]
      /call FollowFunction "${Target.CleanName}"
   }

I also notice that if I just sent "follow" alone, instead of picking the master as it is supposed to do, sometimes it will run with an old Param0. Like if I do "snt spell1 on Gerald" and then "follow", debugging code shows that the follow command is getting a Param0 of "spell1 on Gerald" leftover from the last command. Then it kind of picks something at random to follow. Maybe I'll try to fix that later.

Other suggestions:

"cmds Spell" and similiar help commands are case sensitive now. If you type "cmds spell" it tells you "NULL" which isn't very user friendly. I can't figure out how string manitpulation works right now though so I didn't fix that.

Also I think that "spellgem" should get saved to the ini file when you change it through the spellgem command.

-GT

[Chant3r]

Figured out what I was doing wrong . I get so happy when I get better at figuring this stuff out . I love being a short bus rider

[LordGiddion]

ok my son work me up with 5 hrs of sleep so I've read through the thread and I'll add the fixes that you folks have found into an update for those that don't want to walk through the posts.

OgreB: In think your cast item problem was from some extra quotes in botspell. Try it now.

Dulapore: thanks loot fixed - Lax hates 0's I think.

Charisa: Really sorry, this should settle out soon - there's a lot of code that had to be ripped up for the macro conversion and I missed a bunch of stuff - if things were a little more settled in my life I'd put more time then I did to testing.

fez_ajer: I think I've got in all your fixes, thanks for the help your giving the community and your votes of support. I think the chaincasting should be fixed. One change though - the delay before sit IS supposed to be in the [spell] section of the ini not core anymore - seems to me for new users it will make more sense there.

newb-n-training: thanks I think I incorperate all your math fixes. Though I'm not sure why you had problems with the bool compares I did some testing on the logic (not on backstab) and the ==1 shouldn't be needed. I'll try to check.

Chant3r: Recopy genbot.mac - the main is there.

Gerald: the Genbot follow should be fix now so the default of 1 should be ok, though 2 might be a better idea for most. Thanks for the catch on left over params, fixed it and that should fix other problems. Will fix some of the case issues later and I'll be adding Ini save functions later.

Nightshift: with your fix none of the timer logic works - but doesn't error - I fixed the actual error and it should work now.

Tazmanium: if you take THOSE quotes out the bot can't cast shortcut spells with spaces in the name. There were others that needed to come out but not those.

bollox: glad checknames works for you, took me a bit to figure out how to fix your problem but not change function for others. Thanks for the catch on the timer I think that may be the reason for the chain casting.

Likwid: I think the fixes that Fez did (and are in this update) should fix your heal problem.

omper: I think I think with the fixes that Fez did (and are in this update) you'll be fixed with this update.

mycodesux: I think I think with the fixes that Fez did (and are in this update) fixed with this update.

healbot: sorry about that, if I get a chance to code there will be one more update that will effect person.inc - it won't be a required change but will enhance Personal inc - It's part of the coding I'm gonna be doing so that current state can get save BACK to the ini.

Posted an update to every file except the mac & personal.inc

Current File Versions:
BotCore.inc 12.26
BotCombat.inc 12.22
BotSpell.inc 12.24
BotHealer.inc 12.24
ShortCuts.inc 12.22

[Badger999]

while testing the macro i encountered a strange thing:

the Commands[2, ...] Array seems to be fooked, The ExeCommand routine get's a wrong routine name for example the command sit. sit = camp. I checked the array in the AddCommand function (/echos to see what get's added, and there it seems fine)

I have the build from 29.4.2004 Rev C.

Any Ideas ?

[spektralkat]

still chain healing the moment i start macro