CRASH bug in IRC-20020929 (discovered by KaL)

DeathSpiral · Post by **DeathSpiral** » Mon Sep 30, 2002 2:36 pm

There is a 'crash' level bug in IRC-20020929; it was discovered by KaL in the IRC channel.

If you close MQ while EQ is running (macro running, macro not running, doesn't matter), it will spew the 'MacroQuest is unloaded' message to the screen, and then EQ will crash.

Initial bug report from KaL.
Confirmed by myself.

:)

cyberglitch · Post by **cyberglitch** » Mon Sep 30, 2002 2:46 pm

I just ran across that myself and was about to post it as well.

Plazmic · Post by **Plazmic** » Mon Sep 30, 2002 4:59 pm

Unloaded via the systray or /unload?
If it's by the systray, thats a step up since it used to just hang the client..
If it's in /unload then it's definately a regression somewhere...

rizwank · Post by **rizwank** » Mon Sep 30, 2002 5:47 pm

0905 right clicking systray and exiting never even locked up my client.. it worked perfectly

DeathSpiral · Post by **DeathSpiral** » Mon Sep 30, 2002 6:03 pm

rizwank wrote:0905 right clicking systray and exiting never even locked up my client.. it worked perfectly

Ditto here.

I 'confirmed' the crash with right click unload. I believe KaL used right click unload as well.

Grakun · Post by **Grakun** » Mon Sep 30, 2002 6:23 pm

MQ has always frozen EQ, if I try and right-click it, then exit while EQ is running... Even if I'm at the login screen...

Plazmic · Post by **Plazmic** » Mon Sep 30, 2002 9:20 pm

Ok, what OS are you guys that can unload with the systray running?
AFAIK:
XP -- locks up 100% from it, /unload works...
9x -- /unload blows up (from what I've heard) and no comment on systray

Also, I think I've fixed any possible telnet related crashes. I've wrapped everything in critical sections now (send queue, recv queue, connection list, and active threads) and CloseServer is safer.

DeathSpiral · Post by **DeathSpiral** » Mon Sep 30, 2002 10:02 pm

Using W2K here. MQ-20020905, I can systray unload, nothing untoward happens. IRC-20020929, I can /unload but not systray unload.

As a side note, the EQLib.dll I'm injecting with 0905 is AMadMonk's, with his console window. I can dig up the release 0905 and try it with that, but I recall systray unload working there.

Also, playing with the IRC release, apparently sometimes EQ crashes on systray lockup and sometimes I just can't return focus to EQ or provide EQ with input.

Valerian · Post by **Valerian** » Mon Sep 30, 2002 10:13 pm

XP, 905 release here, /unload and systray unload both work perfectly.

Plazmic · Post by **Plazmic** » Mon Sep 30, 2002 10:39 pm

Also, playing with the IRC release, apparently sometimes EQ crashes on systray lockup and sometimes I just can't return focus to EQ or provide EQ with input

There is a race condition in 929 when you connect MQ after EQ is running.
We try to grab the critical section to output chat to the telnet consoles before the critical section is initialized (another thing I fixed so far)

As far as unloading, the next build should work again I think...
Glad to know XP/Win2k are working (I'm not running XP, but something beyond it)

DeathSpiral · Post by **DeathSpiral** » Tue Oct 01, 2002 1:10 am

DeathSpiral wrote:Also, playing with the IRC release, apparently sometimes EQ crashes on systray lockup and sometimes I just can't return focus to EQ or provide EQ with input.

Erm, I meant to say on 'systray unload'.

AMadMonk · Post by **AMadMonk** » Tue Oct 01, 2002 2:17 pm

DeathSpiral:

Don't use my mod anymore :) My sources are out of date.

I need to resynch with what's up there and reapply my mods. Actually if the telnet server is working, a console output mod is sort of redundant since you can just connect locally for the same effect. So for now, ditch my mod since it may not be playing nice anymore.

DeathSpiral · Post by **DeathSpiral** » Tue Oct 01, 2002 2:46 pm

AMadMonk wrote:I need to resynch with what's up there and reapply my mods. Actually if the telnet server is working, a console output mod is sort of redundant since you can just connect locally for the same effect. So for now, ditch my mod since it may not be playing nice anymore.

lol, only pulled up your mod in use with 0905 to do a quick test; otherwise I've been running 0929 to help debug. :)