[IRC Release] 2 bugs found... [fixed]

A forum for feature requests/discussions and user submitted patches that improve MQ2

Moderator: MacroQuest Developers

User avatar
DeathSpiral
a ghoul
a ghoul
Posts: 95
Joined: Thu Aug 22, 2002 6:31 pm

[IRC Release] 2 bugs found... [fixed]

Post by DeathSpiral » Sun Sep 29, 2002 8:39 am

Playing with the telnet interface, found the following two bugs:

If a macro is paused, the telnet interface WILL NOT accept input. So... if you /mqp via telnet, you're fucked. [EDIT: Erm, thats not entirely true. It will accept input, but it won't process it until the macro is unpaused again on the console...]

If you /filter macros all, none of the output gets directed to the telnet interface. It should. This should be a prime reason of using the telnet interface; to get the messages from echo etc output somewhere. Thats what I really liked about AMadMonk's console window. (Thanks AMadMonk!) Also, we should have some sort of a filter or option to prevent everything else from going to the console window. If I'm debugging, I don't give two shits about guards and merchants and everyone casting spells. In fact, all its doing is cluttering my screen and annoying me. :) Anyway, theres my 2cp worth.

Keep up the good work, Plaz. We all love you for it.
I am orc pawn, hear me yell for centurians...

User avatar
DeathSpiral
a ghoul
a ghoul
Posts: 95
Joined: Thu Aug 22, 2002 6:31 pm

Post by DeathSpiral » Sun Sep 29, 2002 9:05 am

If you don't have a macro running, attempting an /echo $pX will crash EQ.

If EQ crashes (well, with the above listed crash anyways) the telnet server isn't being shut down. Exiting MQ doesn't shut it down either. MQ isn't loaded, but the telnet server port is still bound. I can still telnet to it, altho, obviously, nothing happens. Checked the process list, no MQ or EQ listed. Machine crashed right after that (display driver error, unrelated to anything) so I wasn't able to do further testing. I imagine I would have had to reboot anyways.

Actually, this begs the question: What / how does MQ handle more than one instance of EverQuest with the telnet control? Without looking at the code, it looks like it doesn't start listening to the port until the first EQ opens... which means when you opened the second it wouldn't be able to get the port, and you just wouldn't be able to control it. Can you confirm / deny this? Many thanks...
I am orc pawn, hear me yell for centurians...

Plazmic
The One
The One
Posts: 800
Joined: Fri Jun 14, 2002 12:31 am
Contact:

Post by Plazmic » Sun Sep 29, 2002 4:40 pm

Thanks for the bug on $pX (and probably $lX also)... I'll fix those
/mqpause.. another nice bug... will fix that too

If MQ can't open the port, it don't start the server up, so only 1 server per system right now... I could make it grab the next port so Port=1000 would be the first, and the next EQ would be 1001, etc...

If EQ crashes, we don't have a chance to unbind the port, fairly screwed...

About the filtering,etc... this is the first draft... It is currently just a remote chat window.. All I use it for so far is to avoid jumping over my sofa when my other system messes up...

Someone start a new thread for "What I want in the telnet server"
- Plazmic