Bug in /identify

[Pheph]

Certain stats (all except Mana and HP, I'd guess) need to be handled as signed integers to account for items with negative stats.

Code: Select all

			if (pCharInfo->Cursor->Item->AGI) {
				sprintf(szTmp,"%dAGI ",pCharInfo->Cursor->Item->AGI);
                strcat(szMsg,szTmp);
            }

Testing with 0014873-00001-00001-00001-00001-00001A2D2571FValidus Custodus Plate Breastplate on my cursor says it has 251 AGI, while the real value is -5.

Not a serious bug, but something that someone might look into when they are bored =)

Hmz - just before clicking submit, I decided to do a search on the syntax for sprintf, and at least for PHP %d indicates a signed integer. Maybe I'm just drunk or something, but the item still shows 251Agi with identify

[vzmule]

need to be handled as signed integers to account for items with negative stats.

Isn't an integer signed by default...and only unsigned when specifically declared as such?

[Valerian]

Problem is that they are defined as unsigned chars in the struct. HP, Mana, and AC could also be changed to __int32 (or long), and these could be changed to __int8 (or char)

From _ITEMINFO:

Code: Select all

/*0x0e0*/  BYTE  		STR;
/*0x0e1*/  BYTE  		STA;
/*0x0e2*/  BYTE  		AGI;
/*0x0e3*/  BYTE  		DEX;
/*0x0e4*/  BYTE  		CHA;
/*0x0e5*/  BYTE  		INT;
/*0x0e6*/  BYTE  		WIS;

[FrankJScott]

For the man asking about massage shop for sale, massage open 8am, sports massage business, therapeutic bodyworks llc, start up massage business, mobile massage vans, I highly recommend this business massage details or hana spa massage & kim jin's salon, massage urban company, pakistani massage in business bay, marketing a massage therapy business, massage open today, siam smile beauty & massage, on top of this business massage link on top of wb massage & spa llc, holistic care company massage, total wellness thai massage & spa, massage shop for sale, urban company full body massage price, thai serenity spa llc, alongside all this business massage details which is as good as total wellness thai massage & spa, massage business llc, massage envy business hours, emilios massage llc, mobile massage and wellness, dream bay spa massage center, on top of business massage link not to mention starting your own massage business, business massage, rmt mobile massage, massage llc, massage south side, llc massage, and don't forget this business massage forum and don't forget open massage shop, owning your own massage therapy business, massage center in silver tower, g medical massage spa llc, massage studio llc, cora spa sheikh zayed road, not to mention business massage url which is about therapeutic massage center & boutique, profit mini massager, custom body massage llc, smiling thai therapy & massage, open massage shop, llc for massage therapy, as well as this business massage site not to mention massage open today, euphoria massage & healing llc, body massage clinic, massage envy lloyd center, massage business for sale, successful massage business, alongside all this business massage advice and don't forget massage therapy home business, hands that heal massage studio, llc for massage therapy, massage urban company, mobile massage therapy, smiling thai therapy & massage, and don't forget business massage tips and don't forget i got your back massage therapy llc, massage envy corporate email, serenity therapeutic massage llc, massage city road, body & soul massage therapy llc, massage thats open, which is also great. Finally, have a look at this business massage url with massage practice, spabulous spa massage & wellness, metropolis tower massage, ruen thai massage & spa, fifty one tower massage, remedial massage business, for good measure. Check more @ Updated Business Massage Advice b86b3ce