BUG: New MQ window and Telnet

MacroFiend · Post by **MacroFiend** » Thu Oct 30, 2003 11:32 am

After implimenting the new chat window code, MQ isn't responding back across telnet. I am seeing all chat/auction/ooc messages but none of the [MacroQuest] messages or the super who.

Tested with filter macros all and enhanced. No MQ generated messages are being sent to the telnet session.

With filter macros none, everything was passed to telnet fine.

Zxeses · Post by **Zxeses** » Thu Oct 30, 2003 1:41 pm

by the way, I've been using the stable 10_13 source and have had rock solid stability.

May I suggest you revert to an older version until the whole chat window mess is eliminated.

If you cant see telnet and cant make the extra window go away, then the damn code is crap and shouldnt be used.

MacroFiend · Post by **MacroFiend** » Thu Oct 30, 2003 1:56 pm

That is a good suggestion for the average user ... but it doesn't help the other devs find bugs in the new code. I keep a copy of my last build (pre-window) and update it to include the new changes (minus the window) nightly.

I also use a stock version to test with to help track down issues like this one.

Lax · Post by **Lax** » Thu Oct 30, 2003 1:58 pm

in WriteChatColor, remove the "else" before the last if block (the one that handles telnet).

You can suck the "damn crap" code, you're welcome to do something better or something productive.

MacroFiend · Post by **MacroFiend** » Thu Oct 30, 2003 2:02 pm

Thanks Lax. I'll make that change later and see how it does.

Personally, I don't mind the new window. I'll like it even more once its size and position is stored when we move/resize. I know a good number of people don't care for it because of things they use constantly like SuperWho. If we could filter which MQ stuff went to the window and what didn't (or if, for example, the SuperWho went to the MQ window but a normal EQ Who went to the chat window at the same time)

I tried to cludge together a way to toggle the window on and off ... it bombed *g* I just didn't have the time or patience last night to work on it more.

Side question: I know you said that the close button had to be disabled or MQ would crash. I also know that MQ doesn't create that window until the first time it attempts to output text. Would it be possible to have MQ run a wnd->open check and re-create it if a user closed it?

Mckorr · Post by **Mckorr** » Thu Oct 30, 2003 2:09 pm

Instead of a close button, how about something along the lines of /mqwindow hide|unhide?

And I like it Lax. Just takes some getting used to.

MacroFiend · Post by **MacroFiend** » Thu Oct 30, 2003 2:11 pm

Hide would work for me too if the UI can do it :)

wassup · Post by **wassup** » Thu Oct 30, 2003 2:30 pm

Ignore the jackasses Lax. If it weren't for the devs taking their own personal time to make innovative changes to MQ, MQ would have died out long ago.

I for one appreciate the changes you and the other devs have made and believe what you are doing is for the betterment of MQ.

I like the window.

Lax · Post by **Lax** » Thu Oct 30, 2003 2:32 pm

It crashes because MQ has to keep the window handle, and the pointer becomes invalid if the window gets closed. I'll have an update tonight with an option to just use the main window instead of being safe, but personally I renamed the superwho to a different command in mine, and I normally use normal who

If you want to modify yours to use the main chat window, modify the Chat functions to not call the function that makes a window, and have it use pChatMgr->ChatWnd[0] instead of MQChatWnd. It'll be an option as we develop it a bit.

Zxeses · Post by **Zxeses** » Thu Oct 30, 2003 2:38 pm

He's right, sorry lax, my bad :(