Help on this macro

seph_yaro · Post by **seph_yaro** » Thu Oct 16, 2003 7:56 pm

I'm trying to make a macro that checks if I am full hp when I, say, press a hotbutton, and if I'm not, uses my velious BP to heal to full.
This is what I have, I got what I do from looking at drag.mac, sits.mac, and info.mac... but it doesn't loop -

Code: Select all

#turbo
Sub Main
  /press i
  /if n $char(hp,pct)<100 /goto loop
:Loop
  /if n $char(hp,pct)<100
  /cast item "brigand's chestguard"
  /if n $char(hp,pct)=100 /goto end else /goto loop

:end
/endmacro

It's prolly something dumb, but this is my first attempted macro :(

blueninja · Post by **blueninja** » Thu Oct 16, 2003 8:00 pm

You need a colon before the label like this:

Code: Select all

/goto :loop

Took me some time to get used to :)

blueninja · Post by **blueninja** » Thu Oct 16, 2003 8:10 pm

I was a bit quick with my previous reply, I missed some other stuff.

Changed the /endmacro to /return. /return'ing from the main loop will end the macro.

Changed /if n $char(hp,pct)=100 to /if n $char(hp,pct)==100 (double ='s is the comparison operator).

Removed the /if statement in the loop and made the one outside the loop jump to :end if hp is full.

Code: Select all

#turbo 
Sub Main 
  /press i 
  /if n $char(hp,pct)==100 /goto :end

:Loop 
  /cast item "brigand's chestguard" 
  /if n $char(hp,pct)==100 /goto :end else /goto :loop 

:end 
/return

EqMule · Post by **EqMule** » Thu Oct 16, 2003 8:58 pm

you dont have to have inventory open for /cast item to work btw...

seph_yaro · Post by **seph_yaro** » Thu Oct 16, 2003 9:08 pm

Thanks :)
I didn't know about the colon, or that inven didn't need to be open :)

seph_yaro · Post by **seph_yaro** » Thu Oct 16, 2003 9:12 pm

Justtried it, still doesn't loop

insanitywiz · Post by **insanitywiz** » Thu Oct 16, 2003 9:21 pm

Code: Select all

#turbo 
Sub Main 
  /press i 
  /if n $char(hp,pct)==100 /goto :end 

:Loop 
  /cast item "brigand's chestguard" 
  /if n $char(hp,pct)==100 /return
  /goto :loop 

:end
/return

seph_yaro · Post by **seph_yaro** » Thu Oct 16, 2003 10:31 pm

Thanks insanitywiz, that one works :)

wassup · Post by **wassup** » Fri Oct 17, 2003 12:47 am

Code: Select all

#turbo 
Sub Main 
  /press i
  :Loop
  /if n $char(hp,pct)==100 /goto :end 
    /cast item "brigand's chestguard" 
  /goto :loop 
:end 
/return