$char(buff,<buff name>) crashes again

renagade8 · Post by **renagade8** » Mon Jul 07, 2003 3:00 pm

With the newest cvs version $char(buff,<buff name>) crashes me. It seems when the ini file stuff was implimented thats when it got messed up, because i have an older eqlib file prior to the ini file implimentation that does not crash when using this. I just wanna know if anyone else is having this trouble or if its just me.

- Ren

BlueSkies · Post by **BlueSkies** » Tue Jul 08, 2003 1:42 am

I can verify the INI stuff didn't mess up the $char(buff) stuff

Val messed with the GetArg function -- perhaps he can shed some light on the subject. I certainly hope that's all it is...

dont_know_at_all · Post by **dont_know_at_all** » Tue Jul 08, 2003 4:40 am

Fixed in CVS. Here's the diffs:

Code: Select all

Index: EQLib_MacroParser.cpp
===================================================================
RCS file: /cvsroot/macroquest/macroquest/EQLib/EQLib_MacroParser.cpp,v
retrieving revision 1.5
diff -w -r1.5 EQLib_MacroParser.cpp
2186c2186
<                                                                               if (pCharInfo->Buff[bf].SpellID != 0xFFFFFFFF) {
---
>                                                                               if (pCharInfo->Buff[bf].SpellID != 0x0000FFFF) {
2195c2195
<                                                                               if (pCharInfo->Buff[Buff-1].SpellID != 0xFFFFFFFF) {
---
>                                                                               if (pCharInfo->Buff[Buff-1].SpellID != 0x0000FFFF) {

SpellID changed to from DWORD to WORD and no one changed the constants.

YKW-28983 · Post by **YKW-28983** » Tue Jul 08, 2003 6:29 am

ah. was wondering why I was crashing 24/7 lately lol. thx for the notice and fast fix.

willl have to check this soon as I get home today got the new cvs recompiled but no time to test.

had some odd behavior with it telling me the EQLib file was not there had to open it in windows and then open up the cmd prompt so it would already be in the folder and worked after that..

YKW-28983 · Post by **YKW-28983** » Tue Jul 08, 2003 11:57 am

not fixed. if the buff is not there it will crash otherwise it returns 15 again.. it's broke yet again.. wish there was two cvs's.. untouched and modded.. that way the mods can't screw with working version =\

and I agree things were working fine till the ini project got implemented.

BlueSkies · Post by **BlueSkies** » Tue Jul 08, 2003 11:59 am

How bout next time you get what you consider to be a 'working copy,' just save it in another directory. That way, when changes come down the CVS pipeline, you can just look through the code and decide which changes you want to implement in your copy?

That's what I do. :)

YKW-28983 · Post by **YKW-28983** » Tue Jul 08, 2003 12:09 pm

Well aren't you special..

BlueSkies · Post by **BlueSkies** » Tue Jul 08, 2003 12:36 pm

Er...

It was just a suggestion, dude, take it or leave it...

dont_know_at_all · Post by **dont_know_at_all** » Tue Jul 08, 2003 2:36 pm

Learn the ways of the -D.

Regular cvs is fixed but it will not be updated in the anonymous cvs until sometime later today, which is why I posted the diffs.

fryfrog · Post by **fryfrog** » Tue Jul 08, 2003 2:45 pm

by "-D" dkaa is suggesting you learn this "option" which allows you to check out any version of the mq source by date. so if you feel that mq from a week ago worked much better, just figure out the right -D option and get the source from 1 week ago. you can go back to the beginning if you like.

dont_know_at_all · Post by **dont_know_at_all** » Tue Jul 08, 2003 4:46 pm

YKW-28983 wrote:not fixed. if the buff is not there it will crash otherwise it returns 15 again.. it's broke yet again.

I didn't see this behavior before or after I fixed my crash. Can you provide a specific example that returns 15?

renagade8 · Post by **renagade8** » Tue Jul 08, 2003 4:51 pm

cool thanks dkaa works great with the fix

-ren

YKW-28983 · Post by **YKW-28983** » Wed Jul 09, 2003 11:42 am

If the spell defined in quotations was on my toon it would return 15 however if the spell was no where to be found it would just crash me.