Monk skillup

[mordster]

My first attempt at writing my own. Hardcore basic but I am happy with the results still. Timing works smooth for me, just thought I would share although I know i have seen others out there. Wasn't sure the oldies still worked and wanted to try my hand at something on my own.

Code: Select all

Sub Main
:loop
/if (${Me.AbilityReady[Feign Death]}) /doability "Feign Death"
/delay 30
/stand
/if (${Me.AbilityReady[Mend]}) /doability "Mend"
/delay 10
/if (${Me.AbilityReady[Intimidation]}) /doability "Intimidation"
/delay 100
/if (${Me.AbilityReady[Sneak]}) /doability "Sneak"
/delay 10
/doability Sneak
/delay 10
/if (${Me.AbilityReady[Disarm]}) /doability "Disarm"
/delay 10
/goto :loop 

Mord

[fearless]

Nice job Mord. Personally I prefer to use brackets more with my if's so that I can incorporate delay's better, if they are needed at all. Like so:

Code: Select all

Sub Main
:loop

  /if ( ${Me.AbilityReady[Feign Death]} ) {
    /doability "Feign Death"
    /delay 30
    /stand
  }

  /if ( ${Me.AbilityReady[Mend]} ) {
    /doability "Mend"
    /delay 10
  }

  /if ( ${Me.AbilityReady[Intimidation]} ) {
    /doability "Intimidation"
    /delay 100
  }

  /if ( ${Me.AbilityReady[Sneak]} ) {
    /doability "Sneak"
    /delay 10
    /doability Sneak
    /delay 10
  }

  /if ( ${Me.AbilityReady[Disarm]} ) {
    /doability "Disarm"
    /delay 10
  }

/goto :loop

/endmacro

The difference between mine and yours is that you have the delay's fire no matter what, while mine only are used if the skill actually is ready and fires. When you have the if's seperated like this, you can set your timers a little bit better and have things fire a little bit quicker.

Does that make sense?

EDIT: Note that I did not take out the delay's here because I don't know what delay's should be there versus what delay's can be taken out.

[mordster]

I think I follow you on that. You're saying my ability and delays are tied in together but if I separate the delays with brackets, they execute separate of the ability itself?

[fearless]

Kind of. Let's compare the two and see if it makes more sense.

Code: Select all

/if (${Me.AbilityReady[Feign Death]}) /doability "Feign Death"  <-- If FD is ready, go ahead and FD
/delay 30  <-- Delay 30 seconds even if FD failed
/stand 

Code: Select all

/if ( ${Me.AbilityReady[Feign Death]} ) { <-- If FD is ready, go into the {}, if FD is not ready, continue to the next /if
    /doability "Feign Death"  <-- do it
    /delay 30  <-- Delay 30 ONLY if the /if allowed the macro to go into the {}
    /stand
  } 

You can also add in a check for standing, something along the lines of

Code: Select all

/if ( !${Me.Standing} ) /stand

[xyilla]

Nive

[xyilla]

Fino

[xyilla]

Gill

[xyilla]

Dove

[xyilla]

тема

[xyilla]

Esse

[xyilla]

Sumo

[xyilla]

Doro

[xyilla]

табл

[xyilla]

Will

[xyilla]

Lyon