Problems Modifying kiola.mac

Help section from before the user variable changes that broke all macros

Moderator: MacroQuest Developers

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Problems Modifying kiola.mac

Post by Amadeus » Tue Jul 02, 2002 8:39 pm

Today I tried modifying kiola.mac to do Celestial Essenses. The first attempt crashed EQ HARD and FAST. After that, I placed a /delay 2 line after the combine just to see what it would do, and that seemed to make the macro work ....it does about 5 combines and stops.

Sometimes it just does very strange things and doesn't combine at all ....what's wrong with this macro? :lol:

What needs to be done to this macro to make it work properly?

THANKS!!

Code: Select all

| - ColdainHeater.mac -
|
| Please be near a brew barrel open before you start this macro.
|
#include routines.mac

Sub Main

   /itemtarget Brew Barrel
   /face item
   /click left item

   :MakeColdainHeater
      /sendkey down ctrl

      /finditem "Water Flask"
      /if $find()==FALSE /goto :Done
      /click left enviro 0

      /finditem "Allspice"
      /if $find()==FALSE /goto :Done
      /click left enviro 1

      /finditem "Brown Algae"
      /if $find()==FALSE /goto :Done
      /click left enviro 2

      /finditem "Shotglass"
      /if $find()==FALSE /goto :Done
      /click left enviro 4

      /sendkey up ctrl
      /click left enviro combine

      /delay 2
      /click left auto

      /goto :MakeColdainHeater

   :Done
    /sendkey up ctrl
    /click left enviro done
/return

User avatar
L124RD
Site Admin
Site Admin
Posts: 1343
Joined: Fri Jun 14, 2002 12:15 am
Location: Cyberspace
Contact:

Post by L124RD » Tue Jul 02, 2002 8:47 pm

Salutations,
That doesn't look like the recipe for celestial essences...

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

whoops

Post by Amadeus » Tue Jul 02, 2002 8:53 pm

Whoops ...I meant Coldain Heaters ....too much going on at once ;)

You will note that the macro itself mentions 'coldain heater' ....ignore my ramblings above the code, then it should be right ;)

User avatar
L124RD
Site Admin
Site Admin
Posts: 1343
Joined: Fri Jun 14, 2002 12:15 am
Location: Cyberspace
Contact:

Post by L124RD » Tue Jul 02, 2002 9:11 pm

Salutations,
yea noticed that was what was in the code...

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Ok....

Post by Amadeus » Tue Jul 02, 2002 10:25 pm

Ok -- the following code seems to work perfectly! I'm not sure if it's the proper fix, but it works :)

Code: Select all

#include routines.mac

Sub Main

   /itemtarget Brew Barrel
   /face item
   /click left item
   /delay 4

   :MakeColdainHeater
      /sendkey down ctrl

      /finditem "Water Flask"
      /if $find()==FALSE /goto :Done
      /click left enviro 0

      /finditem "Allspice"
      /if $find()==FALSE /goto :Done
      /click left enviro 1

      /finditem "Brown Algae"
      /if $find()==FALSE /goto :Done
      /click left enviro 2

      /finditem "Shotglass"
      /if $find()==FALSE /goto :Done
      /click left enviro 4

      /sendkey up ctrl
      /click left enviro combine
      /delay 4

      /click left auto
      /delay 2
   /goto :MakeColdainHeater

   :Done
    /sendkey up ctrl
    /click left enviro done
/return

User avatar
L124RD
Site Admin
Site Admin
Posts: 1343
Joined: Fri Jun 14, 2002 12:15 am
Location: Cyberspace
Contact:

Post by L124RD » Wed Jul 03, 2002 11:16 am

Salutations,
you should post that into the macro depot...