Self Automated Tradeskill Macros

peach · Post by **peach** » Tue Oct 19, 2004 3:14 pm

read the post, it explains why it does that..

PhoenixZorn · Post by **PhoenixZorn** » Sun Oct 24, 2004 11:31 pm

Hey override, I'd like these tradeskill macros to be part of the soon-to-be-packaged-and-released zip pack for mq2. I would love to have them all done before I do my zip pack, so I guess I'm just waiting for your Tailoring macro... unless of course you are doing Alchemy and Tinkering as well, witch of course can be released with a subsequent zip, but as you've already posted the tailoring macro is "done", I figured you should get it posted soon. =)

After the initial zip release, which I will be packaging for an upcoming mq2 zip pack, you would be expected of course, to keep your macros updated with new and interesting information and improvements, which can either be sent directly to me, Amadeus, or posted here. I'm truly sorry I didn't get to your macros earlier to get stickied, but I have been quite busy in the last few weeks.

Libra · Post by **Libra** » Mon Nov 01, 2004 9:17 am

Been a while since any update, things going ok?

DryGnome · Post by **DryGnome** » Sun Nov 07, 2004 12:18 pm

How long has the tailoring macro been "done" and we havn't seen it? I heard the testing thing. I just think when you post done it should actually be done. Also any ETA on the tinkering version?

MeGoober · Post by **MeGoober** » Fri Nov 12, 2004 1:26 am

I have the latest downloads and am having the same issues others in this post have. When doing the brewing in Abysmal Sea, I sell any leftover components and buy new ones, no problem. I walk over to the brewbarrel, open it, clear the enviro, and make one set of MHB. The second or third set, loads MOST of the components for another combine and dumps me to the desktop. I disable my HUD (that messed up the first part of the barrel) but I am successfully combining one or two rounds before the dump. I saw comments about lag in AS so looking at the script it appeared that there was a single delay multplier. I tried to slowly increase that to no avail. The only code changes I have made so far are:

Code: Select all

|   /varset SkillMaxWanted 248
    /varset SkillMaxWanted 200
|   /varset DelayMult 1
    /varset DelayMult 1.5

I am not sure where to go from here. I recompiled MQ2 successfully but still have issues. I removed all the plugins I added - moveutils, etc. Any suggestions from some of the earlier guys that had similar issues?

I tried to delay the placement of components...

Code: Select all

       /for i 1 to 10 
             /if (${EndingVar}==1) /call AddComp "${Component[${i}]}" ${i} 
       /delay 1s
       /next i

It did indeed slow down placing the components in the barrel but second round CTD. When I log back in, in the MQ window, it says "could not find (some component) ie. small beer (item varies) but it is always in a bag in the inventory. I moved the empty bags to the last three postions and have a bag in every slot.

Thanks

A_Druid_00 · Post by **A_Druid_00** » Fri Nov 12, 2004 6:57 am

I just did the brewing mac over the course of a day with absolutely no problems whatsoever. In fact, I forgot to buy New Tanaan Crafting Mastery and was brewing for about 4 hours at 200 skill before I came home from work and realized it.

I did, however, remove every call to close backpacks in the mac, and bumped all the delays down from seconds and set the delay multiplier to 3. I also did the same in all the called inc files. Oh, and I fixed it so it only bought the necessary 80 water flasks instead of 100.

Oh, and I got up to 240 fletching from 219 after blowing 50k O_o

Libra · Post by **Libra** » Mon Nov 15, 2004 5:04 pm

is Override dead?

MeGoober · Post by **MeGoober** » Tue Nov 16, 2004 2:57 pm

I have salvage 3 aa. When I fail a combine I normally recover at least part of the recipe. The problem is - the saved components go back into the ENVIRO container. The macros then attempt to do a combine on a partial load OR (depending on the macro) I loads another set of components over the top of what is there. Either way, the combine fails, hangs, and in the worst case scenarion CTD. Pottery will keep going, popping up windows telling you to load single components until you run out of components in your bags and then sell everything back to the vendors to start the cycle over again. Jewel Craft will just loop telling you that you cannot combine those items in this container. If you get in this loop, stop and restart the macro, it will clear your jewelry components but never get to the code that sells the completed items. If you were doing this semi-manually, moving the following code up to be in with the sell gem and bar items would simplify clearing the bags.

/call Sell ${ItemTo}
/delay ${Math.Calc[${DelayMult}*1]}s

Real Solution: We have to clear the enviro on every combine, not just when it is intially opened. Rather than destroying what is in there, it would be preferable to put it back into your bags.

The person walking into the walls. If you are doing it in pottery, you are using the code added to the forums here. He did not change the starting point to be the wheel, so you are attempting to go back out to the kiln. Rather than rewrite it (I am lazy and don't know the syntax well yet) and since you only need 10 skill ups. At the end of each set of combines, type /endmacro - walk back up to the starting vendor and restart the macro. I know, it's not fully automated but its still easy.

For the other combines in AS...specifically in brewing for me, the /doevent combines all the items into the eviron at one time and attempts to combine. The problem is that I can not add delays inbetween adding each component to the eviron - its all or nothing. Several times I only get partial components loaded into the enviro and again CTD. I have no idea how to fix this one. It seems like its a speed issue on my system since others don't see it. (I am running dual 3 gig processors w/ 3 gig of ram).

I commented the heck out of the code and traced it down to be sure before I posted again...

Great stuff, thx again.

Code: Select all

    :Loop
      /combine ${PackCode}
|   /echo *** Combine is done now.  Put clear here? ***
|   /delay 4s
      /delay ${Math.Calc[${DelayMult}*1]}s
    /call cleanPack "${Container}"
    /delay ${Math.Calc[${DelayMult}*3]}s
      /if (${PackCode.Equal[Enviro]}) /delay 1s 
      /doevents 
|   /echo *** Events are done now.  Clear Here? ***
|   /delay 4s
      /if (${InvSlot[${PackCode}].Item.Items}) /goto :Loop

Still locks up...someone give me a hand here...why wouldn't cleanPack work here? It terminates the macro...cleanly but still terminates, with or without the delay. Hmm, Container may not be global...looking... This is in the JC mac btw.

Code: Select all

Sub readIni(RecipeName) 
    /declare Container string

Thats it...it was only used in one sub, going to try to move it out of that sub into the main. Anyone with better idea can jump in at any time, hahaha.

MeGoober · Post by **MeGoober** » Tue Nov 16, 2004 5:03 pm

The cleanpack.inc works perfectly...it puts the extra items back into your inventory so no need to change it.

I would recommend moving the Container delcaration from the readIni subroutine to the main declarations:

Code: Select all

    /varset OldSkill ${Me.Skill[Jewelry Making]}
    /declare Container string outer

| ************************************************
| *   Change these settings to what you want.    *
| ************************************************

Delete the Container declaration from the readIni routine:

Code: Select all

Sub readIni(RecipeName) 
    /declare Container string 

    /echo Running ${RecipeName} recipe, which makes ${ItemTo}.

Then add cleanPack to the Combine routine

Code: Select all

sub DoCombine 
    :Loop
      /combine ${PackCode}
      /delay ${Math.Calc[${DelayMult}*1]}s
      /call cleanPack "${Container}"
      /if (${PackCode.Equal[Enviro]}) /delay 1s 
      /doevents 
      /if (${InvSlot[${PackCode}].Item.Items}) /goto :Loop 
      /delay ${Math.Calc[${DelayMult}*2]}s
      /if (${Me.Skill[Jewelry Making]}>${OldSkill}) {
        /echo Your Jewelry Crafting Went Up!! It's now ${Me.Skill[Jewelry Making]}!
        /varset OldSkill ${Me.Skill[Jewelry Making]}
      }
    /return

That should take care of issues for people that have the Salvage aa. I just did the JC.mac here but it would apply to the others as well. You could disable the cleaning prompts in the cleanPack.inc to keep from cluttering your MQ window if that bothers you.

Hmmm...I can't seem to get the font color to change...the code to change color shows up when I use it in the code blocks above. Do you have to comment them, or? Flame on?

fearless · Post by **fearless** » Tue Nov 16, 2004 5:39 pm

Code bracket disables all processing of code inside the bracket . . . or it wouldn't be a very good code bracket.

MeGoober · Post by **MeGoober** » Wed Nov 17, 2004 9:15 am

So how do others do it?

fearless · Post by **fearless** » Wed Nov 17, 2004 9:21 am

where?

Libra · Post by **Libra** » Sat Nov 20, 2004 5:53 pm

Yes, where indeed! Where is the author =\

MeGoober · Post by **MeGoober** » Sun Nov 21, 2004 12:16 pm

http://www.macroquest2.com/phpBB2/viewt ... &start=480

Last Post on page 33, loadinglastpage puts red comment bars in the gold code block. Others have done it as well, I just havent seen how. If I cut and paste their color changes dont show up.

I apologize, I didn't mean to change the subject. Yes, where are the latest changes and tailoring?

Chyld989 · Post by **Chyld989** » Mon Nov 22, 2004 2:13 am

MeGoober wrote:http://www.macroquest2.com/phpBB2/viewt ... &start=480

Last Post on page 33, loadinglastpage puts red comment bars in the gold code block. Others have done it as well, I just havent seen how. If I cut and paste their color changes dont show up.

I apologize, I didn't mean to change the subject. Yes, where are the latest changes and tailoring?

He didn't use a code block, he used a quote block.

Self Automated Tradeskill Macros

Any time you want to finish. =)

Brewing

Hmm I see part of the problem...

Ok...it's works great now...

Still don't know how.