Twist.mac - Non Combat/Combat Bard Song Twister

Post your completed (working) macros here. Only for macros using MQ2Data syntax!

Moderator: MacroQuest Developers

Bombadil
a lesser mummy
a lesser mummy
Posts: 67
Joined: Wed Mar 24, 2004 11:04 pm

Post by Bombadil » Sun Jul 18, 2004 9:03 pm

Ok, here is what I have found. The following:

Code: Select all

/echo ${Me.Song["1"].Duration}
Should return the duration of the song buff in Song Buff Window slot 1. It doesnt return correctly. Nor do

Code: Select all

/echo ${Me.Song["1"].Level}
/echo ${Me.Song["1"].Name}
return the proper info. They return 255 and "Unknown Spell" respectively.

This effectively breaks this portion of the code:

Code: Select all

  /if ((${Me.Song["${Me.Gem[${Song}]}"].Duration}<${Math.Calc[${Duration}-1]})&&(${Me.Buff["${Me.Gem[${Song}]}"].Duration}<${Math.Calc[${Duration}-1]})) /goto :NonCombatSing3 
I'm pretty sure this is relative to the macro not working correctly

awaterbrother
decaying skeleton
decaying skeleton
Posts: 3
Joined: Mon Jul 19, 2004 10:53 am
Location: Los Angeles

Post by awaterbrother » Mon Jul 19, 2004 11:07 am

Here's the errors that get thrown up when I try and run this macro
Unparsable in Calculation: 'g'
twist.mac@129 (NonCombatSing(Song)): /if (${SingTime}>0) /goto :NonCombatSing1
twist.mac@62 (Main(NonCombatGems,CombatGems)):/if ((!${Me.Combat})||(!${Defined[CombatGems]})) /call NonCombatSing ${NonCombatSongArray[${NonCombatCurSong}]}
The current macro has ended.
Failed to parse /if condition '(29>0)', non-numeric encountered
** Great! Changing all the > and < worked. Now the macro runs without errors. However, now it is dropping each song (in a 4 song rotation) for about .5 seconds in the rotation. This isn't a lag problem so I'm wondering if since I changed all the > and < to their new > < format are there some numbers I need to switch around as well? If not, I will be happy to keep my songs to just twisting 3 instead of 4. **
Last edited by awaterbrother on Mon Jul 19, 2004 11:36 am, edited 1 time in total.

User avatar
aChallenged1
a grimling bloodguard
a grimling bloodguard
Posts: 1804
Joined: Mon Jun 28, 2004 10:12 pm

Post by aChallenged1 » Mon Jul 19, 2004 11:15 am

Look at your errors again, and notice the > this is NOT correct. Anytime you copy a macro be sure to go through it, if it was posted before, and not edited since 6/30/04, and change any and all instances of > and < to be > and < respectively.
Fuck writing MQ2 macros. Go with IS scripts; IS Rules!

brettlpb
decaying skeleton
decaying skeleton
Posts: 2
Joined: Wed Jul 14, 2004 9:06 pm

Post by brettlpb » Mon Jul 19, 2004 4:07 pm

Does anyone have this working (twisting more than 1 song) as of July 18th?

Some people say theirs works fine, but mine and others seem to only stick to the first song. I don't see anything I need to do differently according to instruction.

Bombadil
a lesser mummy
a lesser mummy
Posts: 67
Joined: Wed Mar 24, 2004 11:04 pm

Post by Bombadil » Mon Jul 19, 2004 4:22 pm

The CHARINFO struct in the latest zip is slightly off in regards to ShortBuffs (Aka Songs). Check the MQ2::Development::Structs forum for fix.

Note: If you don't know how to edit C++ Source Code then do NOT attempt to fix yourself. Just wait till they roll out an updated zip.

User avatar
aChallenged1
a grimling bloodguard
a grimling bloodguard
Posts: 1804
Joined: Mon Jun 28, 2004 10:12 pm

Post by aChallenged1 » Mon Jul 19, 2004 4:40 pm

Which might not be far off.

Rumor exists that they will be having some kind of a patch soon due to the lag created in last set of patches. Nothing I can confirm. And I don't look forward to it. /sigh
Fuck writing MQ2 macros. Go with IS scripts; IS Rules!

Wite
orc pawn
orc pawn
Posts: 23
Joined: Tue Mar 16, 2004 6:49 pm

No Worky Here

Post by Wite » Mon Jul 19, 2004 4:50 pm

I'm gettin this error, which it looks like someone has before.



Unparsable in Calculation: 'i'

twist.mac@125 (NonCombatSing(Song)): /if ($(SingTime<;=0)
/goto :NonCombatSingBreak
twist.mac@62 (Main(NonCombatGems,CombatGems)): /if
((!${Me.Combat})||(!${Defined[CombatGems]})) /call
NonCombatSing
${NonCombatSongArray[${NonCombatCurSong}]}
The current macro has ended.

Failed to parse /if condition '(28<;0)', non-numeric encountered



Been trying to do everything my limited abilities allow and can't get it to work.


(Edited: Did not see previous post about CHARINFO struct when this was posted, sorry if this is redundent.)

Bombadil
a lesser mummy
a lesser mummy
Posts: 67
Joined: Wed Mar 24, 2004 11:04 pm

Re: No Worky Here

Post by Bombadil » Mon Jul 19, 2004 4:55 pm

Wite wrote:I'm gettin this error, which it looks like someone has before.



Unparsable in Calculation: 'i'

twist.mac@125 (NonCombatSing(Song)): /if ($(SingTime<;=0)
/goto :NonCombatSingBreak
twist.mac@62 (Main(NonCombatGems,CombatGems)): /if
((!${Me.Combat})||(!${Defined[CombatGems]})) /call
NonCombatSing
${NonCombatSongArray[${NonCombatCurSong}]}
The current macro has ended.


Failed to parse /if condition '(28<;0)', non-numeric encountered



Been trying to do everything my limited abilities allow and can't get it to work.

Code: Select all

($(SingTime<;=0)
It should be:

Code: Select all

($(SingTime<=0)
You didnt properly convert the < You left the ;

Wite
orc pawn
orc pawn
Posts: 23
Joined: Tue Mar 16, 2004 6:49 pm

Post by Wite » Mon Jul 19, 2004 5:04 pm

Thank you very much Bombadil.

demitri
orc pawn
orc pawn
Posts: 16
Joined: Fri Jul 23, 2004 7:04 pm

Post by demitri » Fri Jul 23, 2004 7:09 pm

Hi!

Anyone able to convert this to function with the new mq2data? plz! :)

/dem

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Post by dont_know_at_all » Fri Jul 23, 2004 8:58 pm

I edited the original on page one so that it works.

demitri
orc pawn
orc pawn
Posts: 16
Joined: Fri Jul 23, 2004 7:04 pm

Post by demitri » Sat Jul 24, 2004 7:48 am

as nice of you as it was Dkaa, it wasnt the problem, try running the macro and see if you can twist.

You will have the same problem Im having, will just play one song.

So, what was changed in the last mq2 that broke this and a few other macros? Please help!

Thanks,
Dem

dunce
decaying skeleton
decaying skeleton
Posts: 7
Joined: Thu Oct 30, 2003 2:18 pm

Post by dunce » Sat Jul 24, 2004 8:13 am

Sorry, I just tried it.. Works for me. The non-combat part is having an issue but the primary /macro twist.mac 1234 works just fine.

demitri
orc pawn
orc pawn
Posts: 16
Joined: Fri Jul 23, 2004 7:04 pm

Post by demitri » Sat Jul 24, 2004 8:18 am

o man, I must be a retard! I still cant find whats wrong :(

I start the macro for example /mac twist.mac 1357 and still plays the first song over and over...

Thanks for testing it dunce

/Dem

bigt
decaying skeleton
decaying skeleton
Posts: 3
Joined: Sat Feb 28, 2004 3:02 am

plays first song over and over

Post by bigt » Sat Jul 24, 2004 3:56 pm

I know this works fine on my friends computer but when i try it on mine it plays the first song over and over....

/twist.mac 1234
eat your cheese