Help for the last time on my mage macro!

showme1 · Post by **showme1** » Mon Jun 28, 2004 6:07 pm

Starting a new topic cause my last problem was fixed thanks to your guys wonderful help! For this problem I know it's gonna be someting simple, but I'm brain farting again. Good news is I AM LEARNING from this hehe! My last post I was trying to regulate when I clicked a mod rod by using a timer. Thanks to the help from some great people it is now working. Now I am trying to get my macro to recast a mod rod everytime i use it up. Here is the code I've added to my Sub BuffCheck.....

Code: Select all

Sub BuffCheck 
  /if (!${Me.Buff[Elemental Siphon Recourse].ID}) { 
    /echo Casting Elemental Siphon 
    /call cast "Elemental Siphon" 
    /delay 5 
    /doevents 
  } 
  /if (!${Me.Buff[Khura's Focusing].ID} && !${Me.Buff[Focus of Soul].ID} && !${Me.Buff[Focus of the Seventh].ID} && !${Me.Buff[Talisman of Kragg].ID} && !${Me.Buff[Shield of Maelin].ID}) { 
  /echo Casting Shield of Maelin 
  /call cast "Shield of Maelin" 
} 
/doevents 
  /if (!${Me.Buff[Xegony's Phantasmal Guard].ID} && !${Me.Buff[Blessing of the Nine].ID} && !${Me.Buff[Protection of the Nine].ID}) { 
    /echo Casting Xegony's Phantasmal Guard 
    /call cast "Xegony's Phantasmal Guard" 
    /delay 5 
    /doevents 
    }
  /if (!${Me.Buff[Maelstrom of Ro].ID}) {
  /call cast "Maelstrom of Ro"
  }
  /if (${ModRod}==0) {
  /target myself
  /call cast "Magi`kot's Pants of Convergence" item
  /delay 2
  /echo Setting ModRod to 3
  /varset ModRod 3
  /autoinv
  }
/return

I then added this declare...

Code: Select all

/declare ModRod outer
/varset ModRod 0

Again, to make it all tie together I'll post my whole macro at this point...

Code: Select all

#Event exp "#*#slain#*#"    
#Event rageon "#*#has become ENRAGED#*#" 
#Event rageoff "#*#is no longer enraged#*#" 
#Event burn "#*#burnout V spell has worn off#*#" 
#Event nuke1 "#*#Nuke 1#*#" 
#Event nuke2 "#*#Nuke 2#*#"
#Event nuke3 "#*#Nuke 3#*#"

#include spellcast.inc 

Sub Main 
/declare assist outer 
/echo Assisting ${Param0} 

/declare sentpet outer 
/varset sentpet 0 

/declare MaloCast outer 
/varset MaloCast 0 

/declare BoltCast outer 
/varset BoltCast 0 

/declare BoltCastB outer 
/varset BoltCastB 0 

/declare BoltCastC outer 
/varset BoltCastC 0

/declare BoltCastD outer 
/varset BoltCastD 0 
 
/declare BurnOut outer 
/varset BurnOut 0 

/declare NukeAmount outer 
/varset NukeAmount 4

/declare RodTimer timer outer 0
/varset RodTimer 0

/declare ModRod outer
/varset ModRod 0 

:MainLoop 
/assist ${Param0} 
/call BuffCheck 
/if (${String[${BurnOut}].Equal[0]}) { 
  /echo Casting Burnout V 
  /if (${String[${Me.State}].Equal[SIT]}) { 
    /stand 
    /delay 1s 
  } 
  /delay 3 
  /call cast "Burnout V" 
  /delay 5 
  /doevents 
  /varset BurnOut 1  
} 
/call ManaCheck 
/if (${Target.ID} && ${Target.PctHPs}<=97) { 
  /if (${String[${Target.Type}].Equal[NPC]}) { 
    /if (${sentpet}==0) { 
      /pet attack 
      /varset sentpet 1 
      /echo Pet Sent 
    } 
      /if (${MaloCast}==0) { 
        /call Malo 
    }
  }
}
  /if (${Target.PctHPs}<=97 && ${Target.PctHPs}>=90 && ${String[${Target.Type}].Equal[NPC]}) { 
    /if (${BoltCast}==0) { 
      /if (${String[${Me.State}].Equal[SIT]}) { 
        /stand 
        /delay 1s 
      }
      /echo this is cast 1  
      /call cast "Sun Vortex" 
      /varset BoltCast 1 
      /doevents 
    } 
  } 
  
  /if (${Target.PctHPs}<=70 && ${Target.PctHPs}>=60 && ${String[${NukeAmount}].Equal[4]}) { 
    /if (${BoltCastB}==0) { 
      /if (${String[${Me.State}].Equal[SIT]}) { 
        /stand 
        /delay 1s 
      }
      /echo this is cast 2 
      /call cast "Sun Vortex" 
      /varset BoltCastB 1  
      /doevents 
    } 
  }

  /if (${Target.PctHPs}<=40 && ${Target.PctHPs}>=30 && ${String[${NukeAmount}].Equal[4]}) { 
    /if (${BoltCastC}==0) { 
      /if (${String[${Me.State}].Equal[SIT]}) { 
        /stand 
        /delay 1s 
      }
      /echo this is cast 3 
      /call cast "Sun Vortex" 
      /varset BoltCastC 1  
      /doevents 
    } 
  }

  /if (${Target.PctHPs}<=13 && ${Target.PctHPs}>=5 && ${String[${NukeAmount}].Equal[4]}) { 
    /if (${BoltCastD}==0) { 
      /if (${String[${Me.State}].Equal[SIT]}) { 
        /stand 
        /delay 1s 
      }
      /echo this is cast 4 
      /call cast "Sun Vortex" 
      /varset BoltCastD 1 
      /doevents 
    } 
  }  
  
} 
/doevents 
/goto :MainLoop 
/return 

Sub Event_exp 
  /varset sentpet 0 
  /varset MaloCast 0 
  /varset BoltCast 0 
  /varset BoltCastB 0
  /varset BoltCastC 0
  /varset BoltCastD 0 
  /echo Mob is dead!!! Resetting Variables!!
  /pet hold 
/return 
 

Sub Malo 
  /call cast "Veil of Lost Hopes" item
  /if (${Macro.Return.Equal["CAST_SUCCESS"]}) { 
    /echo ${Target.Name} maloed.
    /varset MaloCast 1 
    /return 
  } else /if (${Macro.Return.Equal["CAST_RESISTED"]}) { 
    /delay 1
    /echo trying again with malosinia 
    /call Malo 
  } else 
    /echo check malo logic 
  } 
/return  

Sub ManaCheck 
  /if (${Me.PctMana}<=88 && ${RodTimer}<=0) { 
    /call cast "Rod of Mystical Transvergance" item 
    /if (${Macro.Return.Equal["CAST_SUCCESS"]}) {
      /echo Rod timer set to 3200 
      /varset RodTimer 3200 
    } 
  } 
/return 

Sub Event_rageon 
  /echo %t is enraged. Backing pet off. 
  /pet back off
  /delay 2
  /pet hold 
/return 

Sub Event_rageoff 
  /doevents flush 
  /echo %t is no longer enraged. Sending pet. 
  /pet attack 
/return 

Sub BuffCheck 
  /if (!${Me.Buff[Elemental Siphon Recourse].ID}) { 
    /echo Casting Elemental Siphon 
    /call cast "Elemental Siphon" 
    /delay 5 
    /doevents 
  } 
  /if (!${Me.Buff[Khura's Focusing].ID} && !${Me.Buff[Focus of Soul].ID} && !${Me.Buff[Focus of the Seventh].ID} && !${Me.Buff[Talisman of Kragg].ID} && !${Me.Buff[Shield of Maelin].ID}) { 
  /echo Casting Shield of Maelin 
  /call cast "Shield of Maelin" 
} 
/doevents 
  /if (!${Me.Buff[Xegony's Phantasmal Guard].ID} && !${Me.Buff[Blessing of the Nine].ID} && !${Me.Buff[Protection of the Nine].ID}) { 
    /echo Casting Xegony's Phantasmal Guard 
    /call cast "Xegony's Phantasmal Guard" 
    /delay 5 
    /doevents 
    }
  /if (!${Me.Buff[Maelstrom of Ro].ID}) {
  /call cast "Maelstrom of Ro"
  }
  /if (${ModRod}==0) {
  /target myself
  /call cast "Magi`kot's Pants of Convergence" item
  /delay 2
  /echo Setting ModRod to 3
  /varset ModRod 3
  /autoinv
  }
/return 

Sub Event_burn
  /target ${Me.Pet.CleanName}
  /delay 2s
  /call cast "burnout V"
/return

Sub Event_nuke1 
  /varset NukeAmount 1 
  /echo Nuking Once Per Fight 
/return 

Sub Event_Nuke2 
  /varset NukeAmount 2 
  /echo Nuking Twice Per Fight 
/return

Sub Event_Nuke3 
  /varset NukeAmount 3 
  /echo Nuking Three times Per Fight 
/return

Ok, so this is where I'm stuck! I know I need to add an /if statement to my Sub ManaCheck routine, but I dont know what that /if statement would be. What i want to happen is after I click the rod it lowers the variable in ModRod by one. there is 3 clicks on one rod before it disappears so once it reaches 0 it should recast it when it calls my BuffCheck. If I have no rod when I start the macro it works perfect. I'm just stuck on completing this step.

Again any help is MOOCHO appreciated!

thank you

hytiek · Post by **hytiek** » Mon Jun 28, 2004 6:33 pm

In regards to your request: "What i want to happen is after I click the rod it lowers the variable in ModRod by one" ; please see the red text:

Code: Select all

Sub ManaCheck 
  /if (${Me.PctMana}<=88  && ${RodTimer}<=0) { 
    /call cast "Rod of Mystical Transvergance" item 
    /if (${Macro.Return.Equal["CAST_SUCCESS"]}) { 
[color=red]      /varcalc ModRod ${ModRod} - 1[/color]
      /echo Rod timer set to 3200 
      /varset RodTimer 3200 
    } 
  } 
/return

In the documentation:

VARCALC defined:

/varcalc varname equation
Calculates the value of equation and stores the result in varname

/varcalc MyVar ${Me.CurrentMana} - ${Spell[Complete Heal].Mana}

In regards to: "If I have no rod when I start the macro it works perfect", keep going with what works :)

Else write some code to pick up the item, check SelectedItem.Charges and assign the value to {ModRod} appropriately (I'm at work, and have the flu atm, else I'd research and write this for ya bro...)

-hytiek

showme1 · Post by **showme1** » Mon Jun 28, 2004 9:17 pm

That worked perfect! Thank you very much sir! I'll try and find the code I need that you're talking about to check my inventory and set the variable from the amount left on the rod. For now though what you added works great. Thank you again for your time!

showme1 · Post by **showme1** » Mon Jun 28, 2004 9:45 pm

Only thing I've found so far is

Code: Select all

 /call ItemFinder "Rod of Mystical Transvergance"

I can't find any snippets yet that check an items charges, but I'll keep pluging away! thanks again [/code]

ieatacid · Post by **ieatacid** » Tue Jun 29, 2004 12:29 am

Code: Select all

${FindItem["Rod of Mystical Transvergance"].Charges}

hytiek · Post by **hytiek** » Thu Jul 01, 2004 6:52 pm

ieatacid, nice find

showme1, how's the macro working? I could put this to use

showme1 · Post by **showme1** » Mon Jul 05, 2004 10:00 pm

the macro works fine if i destroy a rod in my inventory before i start the macro. I have not figured out how to make

Code: Select all

${FindItem["Rod of Mystical Transvergance"].Charges}

automatically varset my ModRod to the amount of charges shown on the rod. If you got anymore ideas I'd be most appreciative!

Here is the macro I posted to the Depot...

Code: Select all

|mage.mac 
|Version 1.0 
|Usage: /mac mage (MA/Tank name) (fire/magic/bolt) 
|When starting this macro you need to assign your main assist and your |type of nuke! 
|fire: will cast "sun vortex" ... example /mac mage maintankname fire 
|magic: will cast "rock of taelosia" ... example /mac mage maintankname |magic 
|bolt: will cast "firebolt of tallon" ... example /mac mage maintankname |bolt 
|----------------------------------------------------------------------------------- 
|Will add ini support to this eventually 
| 
|code is taken from here and there and some is my own thinking 
|but right now this works exactly as I wanted it to. Thank you 
|to those who helped me in the help forum! 
|----------------------------------------------------------------------------------- 
|what this does when you start it is cast a pet then buff yourself up with |everything 
|you can cast. It also sets you up with your first rod. At 97% you will |begin battle 
|and nuke up to 4 times per fight with whatever spell you pick. you will |also debuff 
|the mob with malosinia. 
|----------------------------------------------------------------------------------- 
|DO NOT USE THIS WHILE AFK FFS!!!!!!!! 
|----------------------------------------------------------------------------------- 


#Event exp "#*#experience!!#*#"    
#Event rageon "#*#has become ENRAGED#*#" 
#Event rageoff "#*#is no longer enraged#*#" 
#Event burn "#*#burnout V spell has worn off#*#" 

#include spellcast.inc 

Sub Main 

/deletevar spellname 
/deletevar _param1 

/declare assist outer 
/echo Assisting ${Param0} 

/declare sentpet outer 
/varset sentpet 0 

/declare MaloCast outer 
/varset MaloCast 0 

/declare BoltCast outer 
/varset BoltCast 0 

/declare BoltCastB outer 
/varset BoltCastB 0 

/declare BoltCastC outer 
/varset BoltCastC 0 

/declare BoltCastD outer 
/varset BoltCastD 0 
  
/declare BurnOut outer 
/varset BurnOut 0 

/declare NukeAmount outer 
/varset NukeAmount 4 

/declare RodTimer timer outer 0 
/varset RodTimer 0 

/declare ModRod outer 
/varset ModRod 0 

/declare spellname string global 
/declare _param1 string global 

/varset _param1 ${Param1} 

/call choose 
/echo ${Param0} is the main tank and I'll be casting ${spellname}  

:MainLoop 
/if (!${Me.Pet.ID}) /call SumPet 
/delay 3 
/call BuffCheck 
/assist ${Param0}  
/if (${String[${BurnOut}].Equal[0]}) { 
  /echo Casting Burnout V 
  /if (${String[${Me.State}].Equal[SIT]}) { 
    /stand 
    /delay 1s 
  } 
  /delay 3 
  /call cast "Burnout V" 
  /delay 5 
  /doevents 
  /varset BurnOut 1  
} 
/call ManaCheck 
/if (${Target.ID} && ${Target.PctHPs}<=97) { 
  /if (${String[${Target.Type}].Equal[NPC]}) { 
    /if (${sentpet}==0) { 
      /pet attack 
      /varset sentpet 1 
      /echo Pet Sent 
    } 
      /if (${MaloCast}==0) { 
        /call Malo 
    } 
  } 
} 
  /if (${Target.PctHPs}<=97 && ${Target.PctHPs}>=90 && ${String[${Target.Type}].Equal[NPC]}) { 
    /if (${BoltCast}==0) { 
      /if (${String[${Me.State}].Equal[SIT]}) { 
        /stand 
        /delay 1s 
      } 
      /echo this is cast 1  
      /call cast ${spellname} 
      /varset BoltCast 1 
      /doevents 
    } 
  } 
  
  /if (${Target.PctHPs}<=70 && ${Target.PctHPs}>=60 && ${String[${NukeAmount}].Equal[4]}) { 
    /if (${BoltCastB}==0) { 
      /if (${String[${Me.State}].Equal[SIT]}) { 
        /stand 
        /delay 1s 
      } 
      /echo this is cast 2 
      /call cast ${spellname} 
      /varset BoltCastB 1  
      /doevents 
    } 
  } 

  /if (${Target.PctHPs}<=40 && ${Target.PctHPs}>=30 && ${String[${NukeAmount}].Equal[4]}) { 
    /if (${BoltCastC}==0) { 
      /if (${String[${Me.State}].Equal[SIT]}) { 
        /stand 
        /delay 1s 
      } 
      /echo this is cast 3 
      /call cast ${spellname} 
      /varset BoltCastC 1  
      /doevents 
    } 
  } 

  /if (${Target.PctHPs}<=13 && ${Target.PctHPs}>=5 && ${String[${NukeAmount}].Equal[4]}) { 
    /if (${BoltCastD}==0) { 
      /if (${String[${Me.State}].Equal[SIT]}) { 
        /stand 
        /delay 1s 
      } 
      /echo this is cast 4 
      /call cast ${spellname} 
      /varset BoltCastD 1 
      /doevents 
    } 
  }  
  
} 
/doevents 
/goto :MainLoop 
/return 

Sub Event_exp 
  /varset sentpet 0 
  /varset MaloCast 0 
  /varset BoltCast 0 
  /varset BoltCastB 0 
  /varset BoltCastC 0 
  /varset BoltCastD 0 
  /echo Mob is dead!!! Resetting Variables!! 
  /pet hold 
/return 

|----------------------------------------------------------------------------------- 
|VERY IMPORTANT INFORMATION!! READ SLOWLY AND CAREFULLY!! 
| 
|I have this portion of the macro set to cast malosinia from 
|my face slot item.. NOTE: if you do NOT have the time veil 
|you will need to change the line /call cast "Veil of Lost Hopes" item to 
|/call cast "Malosinia" 
|----------------------------------------------------------------------------------- 
  

Sub Malo 
  /call cast "Veil of Lost Hopes" item 
  /if (${Macro.Return.Equal["CAST_SUCCESS"]}) { 
    /echo ${Target.Name} maloed. 
    /varset MaloCast 1 
    /return 
  } else /if (${Macro.Return.Equal["CAST_RESISTED"]}) { 
    /delay 1 
    /echo trying again with malosinia 
    /call Malo 
  } else 
    /echo check malo logic 
  } 
/return 

Sub ManaCheck 
  /if (${Me.PctMana}<=86 && ${RodTimer}<=0) { 
    /call cast "Rod of Mystical Transvergance" item 
    /if (${Macro.Return.Equal["CAST_SUCCESS"]}) { 
      /varcalc ModRod ${ModRod} - 1 
      /echo Rod timer set to 3200 
      /varset RodTimer 3200 
    } 
  } 
/return 

Sub Event_rageon 
  /echo %t is enraged. Backing pet off. 
  /pet back off 
  /delay 2 
  /pet hold 
/return 

Sub Event_rageoff 
  /doevents flush 
  /echo %t is no longer enraged. Sending pet. 
  /pet attack 
/return 

|----------------------------------------------------------------------------------- 
|VERY IMPORTANT INFORMATION!! READ SLOWLY AND CAREFULLY!! 
|NOTE: if you do NOT have elemental legs 
|you will need to change the line  /call cast "Magi`kot's Pants of |Convergence" item to 
|/call cast "Rod of Mystical Transvergence" 
|this is located at the BOTTEM of Sub Buffcheck just below 
|----------------------------------------------------------------------------------- 
    

Sub BuffCheck 
  /if (!${Me.Buff[Elemental Siphon Recourse].ID}) { 
    /echo Casting Elemental Siphon 
    /call cast "Elemental Siphon" 
    /delay 5 
    /doevents 
  } 
  /if (!${Me.Buff[Khura's Focusing].ID} && !${Me.Buff[Focus of Soul].ID} && !${Me.Buff[Focus of the Seventh].ID} && !${Me.Buff[Talisman of Kragg].ID} && !${Me.Buff[Shield of Maelin].ID}) { 
  /echo Casting Shield of Maelin 
  /call cast "Shield of Maelin" 
} 
/doevents 
  /if (!${Me.Buff[Xegony's Phantasmal Guard].ID} && !${Me.Buff[Blessing of the Nine].ID} && !${Me.Buff[Protection of the Nine].ID}) { 
    /echo Casting Xegony's Phantasmal Guard 
    /call cast "Xegony's Phantasmal Guard" 
    /delay 5 
    /doevents 
    } 
  /if (!${Me.Buff[Maelstrom of Ro].ID}) { 
  /call cast "Maelstrom of Ro" 
  } 
  /if (${ModRod}==0) { 
  /target myself 
  /call cast "Magi`kot's Pants of Convergence" item 
  /delay 2 
  /echo Setting ModRod to 3 
  /varset ModRod 3 
  /autoinv 
  } 
/return 

Sub Event_burn 
  /target ${Me.Pet.CleanName} 
  /delay 2s 
  /call cast "burnout V" 
/return 

|----------------------------------------------------------------------------------- 
|VERY IMPORTANT INFORMATION!! READ SLOWLY AND CAREFULLY!! 
| 
|NOTE: if you do NOT have the spell Rock of Taelosia 
|you will need to change the line /varset spellname "Rock of Taelosia" to 
|/varset spellname "Black Steel" 
|----------------------------------------------------------------------------------- 

Sub choose 
/if (${String[${_param1}].Find["fire"]}>0) { 
   /varset spellname "Sun Vortex" 
   /return 
} 
/if (${String[${_param1}].Find["magic"]}>0) { 
   /varset spellname "Rock of Taelosia" 
   /return 
} 
/if (${String[${_param1}].Find["bolt"]}>0) { 
   /varset spellname "Firebolt of Tallon" 
   /return 
} 
/return 

Sub SumPet 
  /echo Summoning a pet to kill with!! 
  /call cast "Monster Summoning IV" 
/return

Thanks again man!

ieatacid · Post by **ieatacid** » Mon Jul 05, 2004 10:02 pm

Code: Select all

/varset ModRod ${FindItem["Rod of Mystical Transvergance"].Charges}

showme1 · Post by **showme1** » Mon Jul 05, 2004 10:08 pm

own! Will give this a try when i get hom from work. is there an /echo I can use that will show the amount it's varseting so I know for sure that it's doing the right amount?

showme1 · Post by **showme1** » Mon Jul 05, 2004 10:58 pm

still at work but is this what i'd want?

Code: Select all

/if (${ModRod}==0) {
  /varset ModRod ${FindItem["Rod of Mystical Transvergance"].Charges}
 } else /if (${ModRod}==0) {
  /target myself 
  /call cast "Magi`kot's Pants of Convergence" item 
  /delay 2 
  /echo Setting ModRod to 3 
  /varset ModRod 3 
  /autoinv 
  } 
/return

ieatacid · Post by **ieatacid** » Mon Jul 05, 2004 11:28 pm

The way you had it looked fine, just at the beginning do:

Code: Select all

/declare ModRod outer
/varset ModRod ${FindItem["Rod of Mystical Transvergance"].Charges}

That'll set it to whatever charges are left if you have one, 0 if you don't have one.

And then here, instead of using /varcalc you can again just set it to how many charges are left:

Code: Select all

Sub ManaCheck
  /if (${Me.PctMana}<=86 && ${RodTimer}<=0) {
    /call cast "Rod of Mystical Transvergance" item
    /if (${Macro.Return.Equal["CAST_SUCCESS"]}) {
      /varset ModRod ${FindItem["Rod of Mystical Transvergance"].Charges}
      /echo Rod timer set to 3200
      /varset RodTimer 3200
    }
  }
/return

showme1 · Post by **showme1** » Mon Jul 05, 2004 11:42 pm

very nice, thanks for your help man! Your way does make a lot more sense lol. Will try when home from work

showme1 · Post by **showme1** » Tue Jul 06, 2004 3:21 am

if i do an /echo ${FindItem["Rod of Mystical Transvergance"].Charges}

it returns a value of 1 even if there is more then one charge. When I try it in the macro it doesnt seem to be setting the ModRod variable using

/varset ModRod ${FindItem["Rod of Mystical Transvergance"].Charges}

showme1 · Post by **showme1** » Tue Jul 06, 2004 3:33 am

Did a search and found your post from the 2nd explaining about charges not working. That's what i get for not recompiling the most recent version. Gonna go try it now with the july3rd zip. Sorry for the n00bness

showme1 · Post by **showme1** » Tue Jul 06, 2004 5:21 am

Got it working now. Thanks again for all your help man!