ForageDestroy.mac - Now MQ2Data compliant

[xander]

OK guys, this is my first post, so be gentle. :) This is the one I was using, decided to try my hand at making it mq2data compliant. It works fine for me, but there are probably some coding mistakes. So here goes.

Code: Select all

|ForageDestroy.mac 
|Based off of Grimjack's forage.mac - Thank you =) 
|edit the /varset DestroyArray to reflect what you want to destroy. 
|If you add more update DestArraySize to reflect the change. 
|The next value in the array would be like this. 
|/varset DestroyArray(20) "what you want" 
|And you would update DestArraySize like this. 
|/varset DestArraySize 21 
|
|Edited by Xander for mq2data compliance

sub Main 
   /cleanup 
   /declare DestArraySize global 
   /declare LoopCount global 
   /declare DestroyArray array 
   /varset DestroyArray(0) "Fishing Grubs"
   /varset DestroyArray(1) "Pod of Water" 
   /varset DestroyArray(2) "Small Chunk of Velium"
   /varset DestroyArray(3) "Berries"
   /varset DestroyArray(4) "Fruit"
   /varset DestroyArray(5) "Roots"
   /varset DestroyArray(6) "Rabbit Meat"
   /varset DestroyArray(7) "Arctic Mussels"
   /varset DestroyArray(8) "Arctic Scallop"
   /varset DestroyArray(9) "Glob of Slush Water"
   /varset DestArraySize 10
   /varset LoopCount 0 
   :Forage 
       /delay 1s 
       /if (${Cursor.ID}) /call ItemSort
       /if (!${Cursor.ID}) {
	   /if (${Me.Skill[Forage]} > 0) /doability forage 
       }
       /if (${Cursor.ID}) /call ItemSort
       /goto :Forage 
   :loop 
/return 

sub ItemSort 
   :itemchecker 
      /if (${Cursor.ID}) { 
          /if (${Cursor.Name.Find[@DestroyArray(@LoopCount)]}) {
            /echo Destroying ${Cursor.Name} 
	    /destroy
            /delay 2s 
         } 
      /varadd LoopCount 1 
      /if (${Cursor.ID}) {
        /if (@LoopCount<@DestArraySize) /goto :itemchecker 
        }
   } 

   /if (${Cursor.ID}) { 
      /echo Keeping ${Cursor.Name} 
      /autoinventory 
      /delay 1s 
   } 
   /doevents 
   /varset LoopCount 0 
/return

[wassup]

Only things I see that need to be fixed are below:

Code: Select all

sub ItemSort 
   :itemchecker 
      /if (${Cursor.ID}) { 
          [color=cyan]/if (${Cursor.Name.Find[@DestroyArray(@LoopCount)]}) [/color]{ 
          [color=cyan]/echo Destroying ${Cursor.Name}[/color]
       /destroy 
            /delay 2s 
         } 
      /varadd LoopCount 1 
      /if (${Cursor.ID}) { 
        /if (@LoopCount<@DestArraySize) /goto :itemchecker 
        } 
   } 

   /if (${Cursor.ID}) { 
      [color=cyan]/echo Keeping ${Cursor.Name}[/color] 
      /autoinventory 
      /delay 1s 
   } 
   /doevents 
   /varset LoopCount 0 
/return

[xander]

Updated with those changes, thanks. Looks much cleaner that way.

[robdawg]

Would like to say this macro rocks and I used it for 6 hours straight with no problems.

Just wish it had INI support *OR* I was good enough to write INI support. :)

[Ketamine]

This seems to be destroying EVERYTHING I forage, not just what it is told to. Anyone else having this problem or know why I am?

[JimJohnson]

works fine for me

[Ketamine]

Now its not destroying everything I am foraging. Just Planar Fruits

[Ketamine]

Think I figured that out. Since Planar Fruit has the word "fruit" in it it was destroying it. I removed the fruit line and now it works fine.

[xander]

This is the code that's doing it:

Code: Select all

/if (${Cursor.ID}) { 
         [color=cyan] /if (${Cursor.Name.Find[@DestroyArray(@LoopCount)]}) [/color]{ 
            /echo Destroying ${Cursor.Name} 
       /destroy 
            /delay 2s 
         } 

This is looking for the text in the destroy array to see if it is in the text of the item on your cursor. I don't know how to make it require an exact match, sorry. As it is, if it finds a partial (IE 'fruit' in 'Planar Fruit') it evaluates to true and destroys it. Anyone know how to require an exact match in the expression?

[SimpleMynd_01]

Try:

Code: Select all

/if (${Cursor.Name.Find[[color=red]=[/color]@DestroyArray(@LoopCount)]}) { 

That's the way everything else seems to work for exact matches.

-SimeplMynd

[Remblan]

Only 2 minor problem2 with this one for me:

1) When I forage an item the is in the destroy list in spams the MQ window with 8 destroying NULL messages after destroying the foraged item

2) Would love a way to run this while med so that it stands me up and possible sits me back down. I tried to impliment a /stand command but all it did was stand me up as soon as I sat down

[Preocts]

In response to people who are looking for INI support. Here is a snippet from my own personal macro that runs 100% of the time my druid is logged in.

Code: Select all

 #Event Foraged "You have scrounged"
Sub Event_Foraged
  /delay 5
  /declare DoubleCheck local
  /varset DoubleCheck "${Cursor.Name}"

  /if (!${Ini[druid.ini,ForageList,${Cursor.Name}].Length}) {
    /ini "druid.ini" "ForageList" "${Cursor.Name}" "-1"
  } else {
    /if (${Ini[druid.ini,ForageList,${Cursor.Name}]}) {
      /if (${FindItemCount["=${Cursor.Name}"]}>=${Ini[druid.ini,ForageList,${Cursor.Name}]} && ${Ini[druid.ini,ForageList,${Cursor.Name}]}!=-1) /goto :Destroy
    } else {
      :Destroy
      /if (${Cursor.Name.Equal["@DoubleCheck"]}) /destroy
      /return
    }
  }

  :LootIt
    /autoinventory
    /delay 5
    /if (${Cursor.ID}) /goto :LootIt
/return

The ini is populated by the macro and has three possible settings. 0, -1, or any number. 0 will destroy that item if foraged. -1 will keep all. If you give it any other number, say 20, the macro will keep up to 20 of that item and destroy any extra that are foraged.

Code: Select all

[ForageList]
Fruit=-1
Pod of Water=40
Roots=0

2) Would love a way to run this while med so that it stands me up and possible sits me back down. I tried to impliment a /stand command but all it did was stand me up as soon as I sat down

Code: Select all

/if (${Me.AbilityReady["Forage"]}) {
  /if (${Me.Sitting}) {
    /stand
    /delay 3
    /doability Forage
    /sit
  } else {
    /doability Forage
  }
}

[game_slave]

Here is a working macro based mostly on Preocts code. I changed some names(Druid to forage) and added some echos so you would know what was happening. I am looking to add statistics maybe later on but for now this macro works very well.

Code: Select all

|Forage.mac
|Based off code from Preocts(thanks!) and code from various other forage macros.
|In the forage.ini file use -1 to keep all, 0 to destroy all and any other number to keep just that many.


sub Main
   /cleanup
   :Forage
    /if (${Me.State.NotEqual[STAND]}) {
      /stand
      /delay 5
   }
   /delay 1s
   /if (${Me.Skill[Forage]} > 0) /doability forage
       }
       /if (${Cursor.ID}) /call ItemSort
       /goto :Forage
   :loop
/return
sub ItemSort
  /delay 5
  /declare DoubleCheck local
  /varset DoubleCheck "${Cursor.Name}"

  /if (!${Ini[forage.ini,ForageList,${Cursor.Name}].Length}) {
    /ini "Forage.ini" "ForageList" "${Cursor.Name}" "-1"
  } else {
    /if (${Ini[forage.ini,ForageList,${Cursor.Name}]}) {
      /if (${FindItemCount["=${Cursor.Name}"]}>=${Ini[forage.ini,ForageList,${Cursor.Name}]} && ${Ini[forage.ini,ForageList,${Cursor.Name}]}!=-1) /goto :Destroy
    } else {
      :Destroy
      /if (${Cursor.Name.Equal["@DoubleCheck"]}) {
      /echo Destroying ${Cursor.Name}
      /destroy
      /return
    }
  }

  :LootIt
  	/echo Keeping ${Cursor.Name}
    /autoinventory
    /delay 5
    /if (${Cursor.ID}) /goto :LootIt
/return 

[Preocts]

Glad to hear you were able to make a working mac out of that snippet. Here is a general question for anyone who uses forage macs. What kind of stats are useful to record. My present macro tracks Forage: Attempts, Successes, Failures, Keeps, Destorys, and the number of each different item foraged for the 'day'. ((my macro has an option to reset these stats))

Once there are a few things worked out with the new Uservars I'll post my foraging.inc.

[xander]

I've never felt the need to know the stats at all myself.