My Fishing Macro... for casters on teh planes..

[PhoenixZorn]

This uber script has saved my ass from certain death many times by healing me and gating when I am being PKed or mob killed.

It is designed for use with Fisherman's Companion, and was based off another very effective fishing script I found here.

Code: Select all

| - Fish.mac - 
| By Phoenix and pr0ps to the original coder of this simple but effective fishing script.
#turbo
#include routines.mac 
 
#event BrokenPole "You can't fish without a pole"
#event NoBait "You can't fish without fishing bait, go buy some."


Sub Main 
   /cleanup 
   :Fish
      /if $invpanel==TRUE /press i 
      /call CheckPole  
      /if $return==1 /return 
      /doability Fishing 
      /delay 65  
|This script is specific to Plane of Valor/Storms.  If anyone wishes to do so, a #include could be
|written to figure out what zone you are in, then use the appropriate set of items.
|As it stands, I am only PoV flagged, so thus don't care about the others yet.
      /if "$cursor(name)"=="Tattered Cloth Sandal" /destroy
      /if "$cursor(name)"=="Rusty Dagger" /destroy 
      /if "$cursor(name)"=="Fish Scales" /destroy 
      /if "$cursor(name)"=="Fresh Fish" /destroy
      /if "$cursor(name)"=="Crawdad" /destroy
      /if "$cursor(name)"=="Waterleaf Scale" /destroy
      /if "$cursor(name)"=="Vallorian Discus" /autoinventory
      /if "$cursor(name)"=="Storm Salmon" /autoinventory
      /if "$cursor(name)"=="Nightmare Cichlid" /autoinventory
      /click left auto
      /if n $char(hp,pct)<75 /call GateMe 
   /goto :Fish 
/return 

Sub CheckPole 
   /if "$equip(primary,name)"~~"Brell's Fishin' Pole" /return 0 
   /if $invpanel==FALSE /press i 
   /if "$char(state)"=="SIT" /sit
   /delay 4
   /click right inv slot 0 
   /delay 11s 
   /autoinventory 
   /press i
   /sit
    
/return 0 

|For those of us who enjoy fishing in the Planes, especially PoN, PoV, and PoS...
|this part of the code causes you to heal yourself and gate if you are under 75% Health.
|Change the spell name if you are not a cleric, and remove the whole piece if you
|cannot cast Gate.


   
Sub GateMe
   /delay 6
   /if "$char(state)"=="SIT" /sit
   /target myself
   /cast "Celestial Healing"
   /delay 7s
   /cast "Gate"
   /delay 15s
   /if "$char(state)"=="STAND" /sit
   /camp desktop
   /endmacro
/return
   


|Added next line because I had an event in which the macro didn't auto recast a new pole.
|When I stood to cast, the macro continued as normal. 
  
Sub Event_BrokenPole
   /call CheckPole
/return

Sub Event_NoBait
   /call GateMe
/return

[Zxeses]

Just a couple of proposed changes:

Code: Select all

Sub GateMe 
   /delay 6 
   /if "$char(state)"[b][color=red]!="STAND" /stand[/color][/b] 
   [b][color=red]/press F1[/color][/b] 
   /cast "Celestial Healing" 
   /delay 7s 
   /cast "Gate" 
   /delay 15s 
   [b][color=red]/book[/color][/b]
   /camp desktop 
   /endmacro 
/return 

[Zxeses]

Couple more:

please note that you *MUST* be standing to summon a pole...

Code: Select all

Sub CheckPole 
   /if "$equip(primary,name)"~~"Brell's Fishin' Pole" /return 0 
   [color=red]|/if $invpanel==FALSE /press i  *REMOVE LINE*
   |/if "$char(state)"=="SIT" /sit  *REMOVE LINE*
   |/delay 4  *REMOVE LINE* [/color]
   /cast item "Fisherman's Companion"
   /delay 11s 
   /autoinventory 
   [color=red]|/press i 
   |/sit [/color]
    
/return 0 

[Zxeses]

by the way....

/if "$cursor(name)"=="Crawdad" /destroy


Can I have your Crawdad? heh, these sell for 10-50pp each

[PhoenixZorn]

They don't on Vallon Zek... and when I make 3k per hour by destryoing them... heh... I like that...

on your cmments. the macro is written the way it is because it works that way... it is simple... and effective. On your second post about the standing requirement to cast a spell... I'm well aware of this fact, and until I changed it to what it is now... the macro was actually attempting to sit down, cast the pole, then stand up... so now it works flawlessly.

I'm also questioning your /book line... as the /book command opens your spellbook... in my opinion, the line is absolutely un-necessary.

On your changing of my "stand" line to gate.... /stand is one way... it only stands... /sit is a toggle... thus works in both ways... but only gets called if the character is sitting, thus showing agan that this macro doesn't need many changes if any at all...

Thanks for your input... if you want to alter the macro for your own use, go right ahead... it won't offend me... but pleasse give credit where credit is due.

[Mutter]

He's got a point, I see no problems with his code. In fact I was rather impressed by a couple shortcuts in coding he took. Guys only flame/fix if it's broken!
Great code, simple but effective.

[yoda]

I have a question.....just wondering if I am not seeing something in the code, but say you aren't a cleric so you remove:

Code: Select all

/cast "Celestial Healing" 
/delay 7s 

But you leave the Gate part in. well my question is:

What happens if you are being attacked when this code is executed and you Fizzle or your casting is interupted?

To me, it looks like you would try to sit and camp, but if you are being attacked, then you would stand back up, maybe I am just missing something here.

Thanks