Page 1 of 1

Minor pointer bug in mq2telnet

Posted: Sun Aug 02, 2015 6:49 pm
by rmaxm
Looks to me like a minor pointer bug in TelnetServer.cpp when a connection is closing.
The code reads:

while(Conn->Received)
{
PCHATBUF rNext=Conn->Received->pNext;
free(rNext);
Conn->Received=rNext;
}

But this is going to free the next buffer (which will probably be NULL) instead of the current buffer.

Should be:
while(Conn->Received)
{
PCHATBUF rNext=Conn->Received->pNext;
free(Conn->Received);
Conn->Received=rNext;
}

This will of course be a very very rare condition.
(The same bug exists in CTelnetServer::Shutdown).

Also, I'm not sure this is the right place to post these kind of things so let me know if there is someplace else where devs post internal bugs like this.
And should I post a diff file?

Thanks,
RMAXM

Re: Minor pointer bug in mq2telnet

Posted: Wed Aug 05, 2015 8:06 pm
by EqMule
Thanks I'm out of the office atm I'll take a look at this when I get back but a quick glance looks good to me, thanks for the report.

Re: Minor pointer bug in mq2telnet

Posted: Sat Aug 08, 2015 1:36 pm
by EqMule
fixed in MQ2-20150808.zip

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:12 pm
by xyilla

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:13 pm
by xyilla

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:14 pm
by xyilla

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:16 pm
by xyilla

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:18 pm
by xyilla

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:19 pm
by xyilla

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:20 pm
by xyilla

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:21 pm
by xyilla

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:22 pm
by xyilla

Re: Minor pointer bug in mq2telnet

Posted: Sat Jan 17, 2026 12:24 pm
by xyilla