mq2-20060227b fixes

echoism · Post by **echoism** » Tue Feb 28, 2006 7:16 am

ISXEQCommands.cpp
563
[color=red]--         pCharData1->CastSpell(10,0,(EQ_Item**)item,0,slot,-1,0,0);[/color]
[color=green]++         pCharData1->CastSpell(10,0,(EQ_Item**)item,0,slot,-1,-1,0,0);[/color]

ISXEQChatWnd.cpp
52
[color=red]--		OutputBox->Unknown0x019=1;[/color]
[color=green]++		OutputBox->Clickable=1;[/color]

echoism · Post by **echoism** » Tue Feb 28, 2006 8:31 am

ISXEQPulse
52

Code: Select all

   // Drop out here if we're waiting for something.
    if ((!pChar) || (gZoning)/* || (gDelayZoning)*/) return;
[color=green]++	if (!pCharInfo) {
++		//DebugSpew("Pulse: no charinfo returning\n");
++		return;[/color]
	}
	if (pChar!=pCharOld && WereWeZoning)

70

Code: Select all

[color=red]--		LastHealth=0;
--		LastMana=0;
--		LastEndurance=0;[/color]
[color=green]++		LastHealth=GetCurHPS();
++		LastMana=GetCharInfo2()->Mana;
++		LastEndurance=GetCharInfo2()->Endurance;[/color]

123

Code: Select all

[color=red]--		if (GetCharInfo2()->Endurance != (int)pCharData1->Max_Endurance())[/color] 
[color=green]++		if (GetCharInfo2()->Endurance != GetMaxEndurance())[/color]

131

Code: Select all

[color=red]--    if (gbDoAutoRun && pChar && pChar->pCharInfo)[/color] 
[color=green]++    if (gbDoAutoRun && pChar && pCharInfo)[/color]

138

Code: Select all

[color=red]--        sprintf(szServerAndName,"%s.%s",pChar->pCharInfo->Server,pChar->pCharInfo->Name);[/color]
[color=green]++        sprintf(szServerAndName,"%s.%s",EQADDR_SERVERNAME,pCharInfo->Name);[/color]

206

Code: Select all

[color=red]--	DWORD GameState=*(DWORD*)(0xB54+pEverQuest);[/color]
[color=green]++	DWORD GameState=*(DWORD*)(0xB5c+pEverQuest);[/color]

Lacky · Post by **Lacky** » Tue Feb 28, 2006 11:48 am

Thank you!

Lacky · Post by **Lacky** » Sat Mar 04, 2006 2:48 pm

Code: Select all

(414.678): Access violation - code c0000005 (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
eax=009fe100 ebx=00000000 ecx=00000000 edx=00000000 esi=0a463c38 edi=0a463c3c
eip=00625a50 esp=0012a5c4 ebp=0012aef4 iopl=0         nv up ei pl zr na po nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs=0000             efl=00010246
*** WARNING: Unable to verify checksum for F:\everquest\eqgame.exe
*** ERROR: Module load completed but symbols could not be loaded for F:\everquest\eqgame.exe
eqgame+0x225a50:
00625a50 8b5104           mov     edx,[ecx+0x4]     ds:0023:00000004=????????
0:000> .sympath SRV*c:\winnt\symbols*http://msdl.microsoft.com/download/symbols
Symbol search path is: SRV*c:\winnt\symbols*http://msdl.microsoft.com/download/symbols
0:000> r
eax=009fe100 ebx=00000000 ecx=00000000 edx=00000000 esi=0a463c38 edi=0a463c3c
eip=00625a50 esp=0012a5c4 ebp=0012aef4 iopl=0         nv up ei pl zr na po nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs=0000             efl=00010246
eqgame+0x225a50:
00625a50 8b5104           mov     edx,[ecx+0x4]     ds:0023:00000004=????????
0:000> kv
*** WARNING: Unable to verify checksum for C:\Program Files\InnerSpace\IS-Kernel.dll
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for C:\Program Files\InnerSpace\IS-Kernel.dll - 
ChildEBP RetAddr  Args to Child              
WARNING: Stack unwind information not available. Following frames may be wrong.
0012aef4 0301edd8 000003e9 01121008 03008984 eqgame+0x225a50
0012af00 03008984 00000000 00000003 000003e9 IS_Kernel!F1+0x1cc98
0012af40 03008c6d 01113170 740cafba 00000000 IS_Kernel!F1+0x6844
00000000 00000000 00000000 00000000 00000000 IS_Kernel!F1+0x6b2d

Seems very reproducable. And seems to be pointing to IS not Isxeq.... Odd

Lax · Post by **Lax** » Sat Mar 04, 2006 5:32 pm

The above changes are now in CVS, so they should be present in the next zip

Lacky · Post by **Lacky** » Sun Mar 05, 2006 12:04 am

After talking to Lax about it. The crash report that IS sent in pointed to Isxeqchatwnd.

[13:55] Lax: Lacky: that appears to be crashing during the chat service broadcast (e.g. writechatcolor hook)
[13:58] Lax: actually i highly prefer the actual crash report, which shows that it's in isxeqchatwnd

Lacky · Post by **Lacky** » Sun Mar 05, 2006 5:07 pm

Fixed. Was me being dumb. Had MQ2 running as well. They dont like each other.