MacroQuest64

Fearless,

You're going to drag me kicking and screaming to using better form. :)

I don't get why the quotation marks aren't necesscary when brackets surround the variable. Does the bracket act as the same delimeter value as quotes? For example...would this work:
edit: I tested the above question, and it doesn't work. So I'm confused.

Thanks for your feedback, seriously. I've edited the script a couple posts above and would love to get your opinion on whether it's now crafted properly.

horseshoecrabs wrote:Fearless,

You're going to drag me kicking and screaming to using better form. :)

I don't get why the quotation marks aren't necesscary when brackets surround the variable. Does the bracket act as the same delimeter value as quotes? For example...would this work:

Code: Select all

/cast item [${RuneStaff}]

edit: I tested the above question, and it doesn't work. So I'm confused. :?

Thanks for your feedback, seriously. I've edited the script a couple posts above and would love to get your opinion on whether it's now crafted properly.

The vast majority of the time you only need to use quote marks when you are calling another sub and passing a string to it. IE /call cast "Blessed Armor of the Risen" gem8 10s

Let's mix in a declare line like /declare myvar string outer "Blessed Armor of the Risen". What happens with you use this later? If you use myvar, it turns into /call cast "${"Blessed Armor of the Risen"}" gem8 10s. See where the quotes come back in to play?

Regarding brackets . . . brackets are their own delimiter when used in a variable, ie you don't need quote marks in ${Spell[Blessed Armor of the Risen].ID}, but that is the only time they act as a delimiter. You do not want to use quotes in that same variable because ${Spell["Blessed Armor of the Risen"].ID} may or may not match the spell.

Does that make more sense?

For you can just do for true or for false. No need to switch it to a bool.

These are some great pointers! I was afraid to ask for this kind of help early on because my dumb questions might have been confused for those asked by somebody who isn't willing to make an honest effort on learning this stuff.

Your lesson on quotations and brackets clear things up nicely and your bool comments are remarkably simple implemenations of something I should have noticed in the first place, but obviously did not.

Edited the script again.

Thanks!

Glad to help.

Also, for something like ${RobeCasts}==0, you can just use !${RobeCasts}. I noticed you have a few of them in the mac.

If you can, hang out in IRC. Most of us are pretty helpful when it comes to giving macro pointers, as long as its apparent you're trying to learn and not looking for handouts.

Also, for something like ${RobeCasts}==0, you can just use !${RobeCasts}.

Hi there, back again from another trip. Yes, I thought about this too, and thought about it some more after reading your post. The reason I elected to check for a zero value in particular is because I'm looking at the var not so much as on or off, but as a value ranging from zero to 12. In that regard, I was interested in consistency.

I modified the macro again and did a couple of little things that make it a bit better than before. New features / changes may be found on the post with the macro itself.

horseshoecrabs wrote:

Also, for something like ${RobeCasts}==0, you can just use !${RobeCasts}.

The reason I elected to check for a zero value in particular is because I'm looking at the var not so much as on or off, but as a value ranging from zero to 12. In that regard, I was interested in consistency..

That's fair and I certainly can not argue with it. I just wanted to point it out as an option in case you were unawares.

LUB YU!!!

And this macro too.

I actually wrote my own macro based of this one and integrated it into my overall wizard macro. Awesome work and wonderful feedback..I learned lots too!

flabbie wrote:LUB YU!!!

And this macro too.

I actually wrote my own macro based of this one and integrated it into my overall wizard macro. Awesome work and wonderful feedback..I learned lots too!

I am sure horseshoecrabs, and everybody else, would love to take a look at what you have been able to come up with. ;)

Yeah, let's see it!

repost the old ones cuz this new 1 keeps tweakin me! btw i liked the old 1 and reformated and lost all info

Welp, here you go!

No where near as sophisticated or sexy coding as yours but I'm rather new to the coding scene!

Anyhoo! Here's my code

ok for some reason this dont work for me. i start it and just keeps spammin the mq2 box it cant do somthing then when i pick up my manarobe in my cursor it starts but then never rerunes itself- im using 1.0 wiz epic

B_rizzleB wrote:ok for some reason this dont work for me. i start it and just keeps spammin the mq2 box it cant do somthing then when i pick up my manarobe in my cursor it starts but then never rerunes itself- im using 1.0 wiz epic

The actual error messages would help here . . . I lost my psychic abilities last week.