MacroQuest64

This is pretty good a and I am using it nicely thanks for the update for the Bait dispenser...

A few things I have noticed that are only small issues... If you dont ahve Homemade Bait as a loot item the script drops the bait, also you need to keep fish you plan on making bait out off...

I'm trying to piece though the code so after each fish the loot code would look at the type of fish, determine if it was a keep or a bait, if keep it would put in inventory, if bait it would go right to the bait sequance which would look at how much bait you have and decide to make bait or through away the fish. I would also like to make it destroy fish rather then have it drop it to the ground... or rather have the choice of dropping, destroying or keeping/making bait...

I'm rather new at the coding side so as soon as I ahve somehting I like I'll post it here :)

When I looked over this macro I really didn't like the loot section. I don't like dropping items and I really don't like destroying items without exact names. All my gear and most my bags are nodrop and one mis-click would be bad.

So, I've decided to re-do how this works. In order to destory an item it must be listed in the [Destroy] section of the INI. What happens now when you fish an item is:

If it's in your ZONE section, keep it
If it's in your BAIT section, keep it
If it's in your DESTROY section, destroy it
Otherwise, keep the item UNLESS set_DropItems is TRUE in which case it will drop it.

No longer will it default to keeping unknown foods, however that could be added the following after it checks the [bait] and before it [destroys]

Untested

Really got to say How much I love this macro... But I was in Natimbi, The Broken Shores And it would not work

below is the Zone exerpt from my ini, I only include that because so far every other zone works. My guess is a miss-match between the ${ZoneName} and what is listed, but after 2+ hours I could not find it

[Natimbi, The Broken Shores]
Loot1=Freash Fish
Loot2=Crab
Loot3=Tuna

That's why short names are better.

Macro updated to now use short names.

Or just change: to:
You will need to rename zone ini sections. To find the short name of a zone, either type /echo ${Zone.ShortName} or run the macro once and see what it is expecting.

I made a change so it only keeps a set number of bait per entry. Useful for when you're tight on inventory and don't want to get overloaded with bait items.

from to Make the 10 anything you want.

Hey I got the Macro up and it will read the .ini and will report to me skillups...but thats it. It won't fish and when I do catch something it doesn't do anything with it even if an action has been specified for the caught item in the .ini

Any help is appreciated =)

Do you have Fishing set as an ability in one of the boxes in your action window? I don't think it will fish if you don't have it as an ability button. If this doesn't work, you could try adding checkpoints. At points in the script where something is checked, or a change occurs, add "/echo whateveryouwant" lines to the code, with different text so you can tell where it is hanging up.

I'm testing this macro out at the current moment and I do seem rather satisfied my only question is where can I find an loot table for the different zones?

Two little improvements can be done to this macro to improve it. Lately I stumbled on a problom that I found where this macro would stick fish inside the Bait dispencer when there was room elseware. Witch to me became a problom because the bait dispencer needs to be empty for the macro to use yes? But the macro has no way of checking to see if anything is in the bait dispencer witch can cause a big prob. Any Ideas lol.

Another problom I found is that where in the world do I set the max of something I want to fish for. It can be kind of sily if I cant set the amout of something I want IE Fresh fish=60 so the bait dispencer has something to work with. I dont want 900 fish cloging my inventory. is there anyway to improve this macro? The concept that I would like to see is like whats inside YAFM Yet Another Forage Macro has the Max setting implamented in it maby something can be done like that..

and Some check needs to be added to check to see if anything is in the bait dispencer first befor anything is added and combined.

Any Ideas? Please Post New Code... PLZZ

Can someone update this to be able to use A Hargar Brand Fishing Pail?

I was simply going to reply to this, make some changes to the mac, test it, and post the changes, but I got so annoyed the more I read your initial post at the lack of initiative and poor spelling and grammar, that I can no longer bear to keep it bottled up inside! (I am "Bad Karma", after all!)

Chaos12010 wrote:...a problom that I found where this macro would stick fish inside the Bait dispencer when there was room elseware. Witch to me became a problom because the bait dispencer needs to be empty for the macro to use yes?

Dunno....never used this macro, nor do I have a Anizok's Bait Dispenser. But if it's not working for you when you have stuff in there, then did you really need to ask this question? Here's a question for you:

In the Comments at the top of the macro, under the heading "HOW TO USE"....third (that's 3) paragraph, it states that the Dispenser should be in Slot 8. I assume that is where you have it, right? Yet you say items are still getting dropped there when there are free slots available elsewhere? Those free slots ARE large enough to hold whatever it is you're dropping into inventory, right? (You're not trying to stuff a "giant" Whale Carcass into a "tiny" Snuff Box, for example?) After you RTFM, does it still drop items into the Dispenser when there are free slots open elsewhere?

Chaos12010 wrote:But the macro has no way of checking to see if anything is in the bait dispencer witch can cause a big prob. Any Ideas lol.

Off the top of my head.... Idea #1: Add a check. "lol" <<insert visual of ditsy blond here>>

Chaos12010 wrote:...where in the world do I set the max of something I want to fish for.

Currently, nowhere. But I'm assuming you already figured that one out. Did you mean to ask "How do you add it"? (see below)

Chaos12010 wrote:is there anyway to improve this macro?

Yes.

Chaos12010 wrote:The concept that I would like to see is like whats inside YAFM Yet Another Forage Macro has the Max setting implamented in it maby something can be done like that..

Sure can....and to answer the question above, have you tried borrowing and modifying the "max count" code from YAFM into this one? Did it work? (Did I really just ask that? Of course you didn't! You want this spoon-fed to you!)

Chaos12010 wrote:and Some check needs to be added to check to see if anything is in the bait dispencer first befor anything is added and combined.

Didn't we already cover this?

big_daddy wrote:Can someone update this to be able to use A Hargar Brand Fishing Pail?

I don't have a lot of time for EQ lately, but did manage to swing this weekend off. Once I get EQ & MQ2 up on this new computer, I'll tinker with the macro a bit. Are there any special quirks with the Pail? Don't currently have one. Simply adding it into the macro is easy enough, though.

Somebody needs a nap.

I just tried this macro and got spammed with "Due to complete misuse of the String Top-Level Object, it has been removed." I think this needs an update lol

vladd wrote:I just tried this macro and got spammed with "Due to complete misuse of the String Top-Level Object, it has been removed." I think this needs an update lol

If you're using the one I posted, it shouldn't do that. I've been using it as is for some time now.