MacroQuest64

Posted: **Sat May 01, 2004 2:39 pm**

Problem in botcore line 371:
Code: Select all
/chat [color=red]#[/color]${ChatInChannel} ${ChatText}
Had to remove the # in order for it to work.

Been playing with this more to see what the difference is. The change of removing the # means the value in the ini file must be a channel number instead of channel name (makes sense since it's defined as an int). The # needs to be removed if the channel is a number not a name.

I know the old genbot used to use the value as a name not a number so I started trying to use a string value there. If a string is used (amongst the other problems I wont go into) the Ini value is constantly reset to 0.

Was the intention to use a string or a number here? I for one would love to see it a channel name since my channel numbers change when pw's are changed (thus throwing off the /autojoin).

Posted: **Sat May 01, 2004 3:58 pm**

newb-n-training wrote:
If a string is used (amongst the other problems I wont go into) the Ini value is constantly reset to 0.

Was the intention to use a string or a number here? I for one would love to see it a channel name since my channel numbers change when pw's are changed (thus throwing off the /autojoin).

I agree - I would also like the channel name as an option. The reason that it resets to 0 is that it is defined as an int by genbot, so when it sees a string, it resets it to zero. You could change the line that delcares the var, but i'm not sure if it would work right then.

Posted: **Sat May 01, 2004 4:40 pm**

xander -- yeah, did that once to see but it's referenced so many other places it'd be a systemic change not a simple correction. I'm just gonna stick to LG's version as much as I can.

Error found in Botcombat.inc remove ( on line 275 bsclock:

Code: Select all

/if [color=red]([/color]((${DoBackstab})&&(${Math.Distance[${Math.Calc[${Target.Y}-${Math.Cos[${Target.Heading.Degrees}]}*10]},${Math.Calc[${Target.X}+${Math.Sin[${Target.Heading.Degrees}]}*10]}]}<15)&&(${Me.Standing})) {

Posted: **Sat May 01, 2004 5:42 pm**

Fuergrissa wrote:
Fuergrissa & omper Not sure why that's happening, the logic looks all right to me as far as I see the only way BuffList[1,3] isn't found is if the buff spell that is cast isn't returning a duration. It's gonna have to be something I test when I have time. Tell me is this bug happening 5 seconds after you cast the buff or is it sooner then that?
I am using cleric/warrior combo and asking for resolution and armor of faith, also get it when i ask for aanya's quickening from enc.

i get 5 seconds after cast and it repeats error message again and again untill i end or it ends itself. let me know if i can put any Echos in for you to test, also IF ANYONE has "Buff" working please post to confirm, is it a global issue of just a few of us.

I'm having this same problem on multiple computers. If I echo the value of ${Bufflist[1,3]} I get a number so I'm not sure why its giving an error, but its pointing at varcalc

Posted: **Sat May 01, 2004 6:12 pm**

Fixes for loot code seem to be working but there bunch of errors about ID not being a member of Corpse also.

Posted: **Sat May 01, 2004 7:46 pm**

Also having problems with Buff, so it's not just you

Posted: **Sat May 01, 2004 7:59 pm**

So far I've noticed that the quotes are wrong in the casting portion of the shorcuts.inc... with the file how it is it'll cast targeted spells fine but anything else it fails to fine the spell.

Currently its:

:ShortCutCast
/varset CastText ${ShortCuts[2,${ShortcutNum}].Arg[${ArgNum},|]}
/if (${ShortCuts[4,${ShortcutNum}]}==1) /call Spellsub "${CastText}"
/if (${ShortCuts[4,${ShortcutNum}]}==2) /cast item ${CastText}
/if (${ShortCuts[4,${ShortcutNum}]}==3) /alt activate ${CastText}
/if (${ShortCuts[4,${ShortcutNum}]}==4) /disc ${CastText}
/varcalc ArgNum ${ArgNum}+1

Should be this from what I can tell (works perfectly for me)

:ShortCutCast
/varset CastText "${ShortCuts[2,${ShortcutNum}].Arg[${ArgNum},|]}"
/if (${ShortCuts[4,${ShortcutNum}]}==1) /call Spellsub ${CastText}
/if (${ShortCuts[4,${ShortcutNum}]}==2) /cast item ${CastText}
/if (${ShortCuts[4,${ShortcutNum}]}==3) /alt activate ${CastText}
/if (${ShortCuts[4,${ShortcutNum}]}==4) /disc ${CastText}
/varcalc ArgNum ${ArgNum}+1

I can't get sitaftercast to work for me at all... not sure whats wrong there.

I'm also getting errors with autobehind and backstab on a bot.... the errors don't show up right sometimes up to a minute later for me... does it alot more often with autobehind on but also does it if I just have backstab flagged. Whent he macro crashes the bot takes off from the group and then stops. I'm sorry I can't post the error listed atm since I can't access this site from home and I'm at work atm. I'll try the change newb listed once I get home tonight.

Buff gives me errors about 5 seconds after the spell is cast but thats already been listed.

Chat in channel not working but deleted the # and works fine with the number of the channel. Working with channel name would be alot easier to work with.

Those are the only issues I've noticed so far.

Posted: **Sat May 01, 2004 9:38 pm**

botspell.inc

Line 84:

Code: Select all

/varset DelayBeforeSit ${Ini[${IniFile}[color=red],Spell[/color],DelayBeforeSit,NotFound]}

Add the red code, seems to fix sit after cast.

NightShift

Posted: **Sat May 01, 2004 10:24 pm**

Why do my bots all CTD when they get agro and get hit? Now it's not everytime but if they get hit, it's a safe bet that a CTD is incoming.

Edit: Yes latestet zip, latest genbot files. It has been CTD on macros since the update. Is anyone else getting this? What do I need to do to fix it?

Posted: **Sat May 01, 2004 10:53 pm**

Gid,

After ml's post last night about not using "quotes" in /varset I went through and removed pretty much all of them from my local working copy. Things seem to be pretty smooth since then, but I'd actually made lots of changes since then so I'm not sure it had anything to do with it.

Thing is, I couldn't see where what he was saying was the case... Doing:

/varset SpazzBot "MonkeyDingus"

was giving the same results as

/varset SpazzBot MonkeyDingus

Do you know which is right?

Posted: **Sun May 02, 2004 12:29 am**

Varset will tack the quotes into the variable.

Run this and you'll see what I mean:

Code: Select all

Sub Main 
/declare blah string local
/varset blah "Johnny"
/echo See I have quotes in me: ${blah}


/if (${blah.Equal[Johnny]}) {
    /echo Yep! It's Johnny!
} else {
    /echo =( It's not Johnny.  *pout*
}

/if (${blah.Find[Johnny]}) {
    /echo Yep! I found Johnny!
} else {
    /echo =( I didn't find Johnny.  *pout*
}
/return

I know what you are thinking.. this should work right?

Code: Select all

Sub Main 
/declare blah string local
/varset blah "Johnny"
/echo See I have quotes in me: ${blah}


/if (${blah.Equal[[color=red]"[/color]Johnny[color=red]"[/color]]}) {
    /echo Yep! It's Johnny!
} else {
    /echo =( It's not Johnny.  *pout*
}

/if (${blah.Find[Johnny]}) {
    /echo Yep! I found Johnny!
} else {
    /echo =( I didn't find Johnny.  *pout*
}
/return

Nope.. You'd have to do this for both of these to be true:

Code: Select all

Sub Main 
/declare blah string local
/varset blah "Johnny"
/echo See I have quotes in me: ${blah}


/if (${blah.Equal[[color=red]""[/color]Johnny[color=red]""[/color]]}) {
    /echo Yep! It's Johnny!
} else {
    /echo =( It's not Johnny.  *pout*
}

/if (${blah.Find[Johnny]}) {
    /echo Yep! I found Johnny!
} else {
    /echo =( I didn't find Johnny.  *pout*
}
/return

Moral of the story. Never put quotes on your varset lines any further unless you intend on them being in the variable.

Posted: **Sun May 02, 2004 9:54 am**

I'll take a look through to see if that's biting us in the ass anywhere.

One thing I did find... The three /if lines in bscounter which deal with setting the heading have been fixed by stripping out some extra parens. The three in bsclock should changed to look like this:

botcombat.inc (294)

Code: Select all

   /if (${Target.Heading.Degrees}>=180 && ${Math.Calc[${Target.Heading.Degrees}-180]}<=${Me.Heading.Degrees} && ${Me.Heading.Degrees}<${Math.Calc[${Target.Heading.Degrees}-22.5]}) /goto :MoreClock
   /if (${Target.Heading.Degrees}<=180 && ${Me.Heading.Degrees}<${Math.Calc[${Target.Heading.Degrees}-22.5]}) /goto :MoreClock
   /if (${Target.Heading.Degrees}>=180 && ${Me.Heading.Degrees}<=180 && ${Math.Calc[${Me.Heading.Degrees}-22.5]}>${Math.Calc[${Target.Heading.Degrees}-360]}) /goto :MoreClock

also, if DelayBeforeSit get's moved to Spell, so does the associated INI command

botspell.inc (84)

Code: Select all

/varset DelayBeforeSit ${Ini[${IniFile},[color=red]Spell,[/color]DelayBeforeSit,NotFound]}
   /if (${DelayBeforeSit.Equal[NotFound]}) {
     /ini ${IniFile} [color=red]Spell[/color] DelayBeforeSit 3s

Posted: **Sun May 02, 2004 10:08 am**

Craft: I think you got a little too quote happy I think... You shouldn't have quotes on /varset lines, but the /call SpellSub should have quotes I believe.

Posted: **Sun May 02, 2004 11:03 am**

Yes you need to keep your quotes on /call lines or the recieve sub will not know how many arguments you are passing it.

Posted: **Sun May 02, 2004 11:08 am**

Thanks fez_ajer I missed that part of it. I added it in manually to the INI which is probably why it worked without that. It wasn't actually been made in the INI.

also, if DelayBeforeSit get's moved to Spell, so does the associated INI command

botspell.inc (84)
Code: Select all
/varset DelayBeforeSit ${Ini[${IniFile},[color=red]Spell,[/color]DelayBeforeSit,NotFound]}
   /if (${DelayBeforeSit.Equal[NotFound]}) {
     /ini ${IniFile} [color=red]Spell[/color] DelayBeforeSit 3s

[/quote]

MacroQuest64

Genbot Version 12 Ready

Re: i concur

Problems

CTD when bots get hit

Hrm...

Ok, I see what you're saying...

Re: Ok, I see what you're saying...