AFCleric.mac - Cleric automation macro (updated Aug 24th)

fearless · Post by **fearless** » Wed Apr 20, 2005 1:34 pm

hi, do you know how to read? The answer is in this thread. Heck, it's even talked about 3 posts above yours! OMG! Work your brain!

Process · Post by **Process** » Wed Apr 20, 2005 1:59 pm

OMG! I tried what was in the thread three pages back. Same problem. OMG!

fearless · Post by **fearless** » Wed Apr 20, 2005 2:38 pm

Okay Process, if you have such a unique problem, please post these very standard and commonly asked for things (cause to date you've just been bitching):

I run MQ version _____________
I have made _________ changes to it
It was compiled with __________
I have confirmed that ___________ works
I have confirmed that ___________ doesn't work
I have tried __________ to remedy this
The errors I am getting are ______________ (EXACT ERROR MESSAGE, NOT A PARAPHRASE)

wassup · Post by **wassup** » Wed Apr 20, 2005 3:19 pm

I am working on improving this a little bit.

There are quite a few unnecessary String conversions in this macro for one thing.

It also has issues when the cleric hp are at heal level and its target hp are at heal level. Just get spam about healing but the healing never happens.

Other than that it has worked decently.

mesthead · Post by **mesthead** » Thu Apr 21, 2005 8:55 am

could someone please post a working version.

i have tried the first page and done the global replaces in all possible combinations.

i still cannot get the macro to not lock up when i execute it.

i deleted every MQ 2 file I had and re downloaded re installed and it still locks up instantly after initializing on the MT.

mest

fearless · Post by **fearless** » Thu Apr 21, 2005 9:56 am

Process? hello? We're waiting for your feedback? Come back Process, we miss you and your unique problem. Perhaps when you come back you can make sure you show us the fixes you applied. We would really like that. Thanks Process. Come back. We're lonely without you and your unique problem.

Process · Post by **Process** » Thu Apr 21, 2005 1:28 pm

Be patient. I'm working on some different possibilities. I'll let you know when I've finished gathering information.

wassup · Post by **wassup** » Thu Apr 21, 2005 4:01 pm

mesthead wrote:could someone please post a working version.

i have tried the first page and done the global replaces in all possible combinations.

i still cannot get the macro to not lock up when i execute it.

i deleted every MQ 2 file I had and re downloaded re installed and it still locks up instantly after initializing on the MT.

mest

Are you able to watch the MQ2 window and get a line number where the macro locks?

Would help quite a bit to know this.

Useless · Post by **Useless** » Thu Apr 21, 2005 4:17 pm

When putting in the fixes I think I over relied on the find and replace and screwed up.

Code: Select all

/for gmember 0 to ${Group}

was replaced with:

Code: Select all

/for gmember 0 to ${Group.Member}

But should have been:

Code: Select all

/for gmember 0 to ${Group.Members}

I think other people may have the same issue using the find and replace. I need to double check when I get home but am pretty sure this is what finally fixed it for me.

I do know that the one posted on the first page still has instances of

Code: Select all

${Group}

in it.

mqnewbie · Post by **mqnewbie** » Thu Apr 21, 2005 4:36 pm

The ${Group} TLO is still in the source, and will report back with the current number of people in our group, however, I think it will go away when the devs realize that. ${Group.Members} is the new method and should be used in the event ${Group} does get removed.

Useless · Post by **Useless** » Thu Apr 21, 2005 6:05 pm

/sigh

Once again:

mqnewbie>me

mqnewbie · Post by **mqnewbie** » Thu Apr 21, 2005 6:26 pm

Nah, just explaining the why behind what you changed didn't work for the benifit of all. ;p You've already fixed your macs!

firehawk · Post by **firehawk** » Sun May 01, 2005 1:20 am

Ok i tried the global replacment and everything, and it doesn't seem to work, what i mean is it starts up fine, sits there ready to heal then bam, the charcter locks up and crashes everysingle time i run this and the shammy bot, i figure its related as they both do that exact samething, just locks the charcter up and crash, no spam in the mq2 window. Any ideas?

magictiger · Post by **magictiger** » Sun May 01, 2005 6:55 am

Attach a debugger and find out where it died and what caused it to die.

DigitalMocking · Post by **DigitalMocking** » Sun May 01, 2005 12:06 pm

I just tried this macro last night, here's exactly what I did:

1) Copied the code from the first post
2) On line 307, change {Group.Member} to {Group.Members}
3) Change Sub MedTime from the default code to use the code posted by Virtuoso65 on the bottom of page 22 of this thread.
4) Add a default MT if no one is targeted by adding the following:

Code: Select all

  /declare DefaultMT string outer <tanknamehere>

I also changed the MT function to allow for the default MT:

Code: Select all

  /if (!${Target.ID}) { 
     /varset tanknameid ${DefaultMT}
     /varset tankclass ${Target.Class.Name} 
  } else { 
     /varset tanknameid ${Target.ID} 
     /varset tankclass ${Target.Class.Name} 
  }

5) Edited the spell list for my spells and set the healing thresholds a little more lax for XP.

That was it, the macro ran flawlessly through a few hours of XP grinding and a DoN mission.

AFCleric.mac - Cleric automation macro (updated Aug 24th)

working version

Re: working version