Self Automated Tradeskill Macros

[Override]

I am in the abysmal sea at vender Bansama Nysawi, the macro starts off by running an saying a bunch of lines like Buying hooked arrowheads.
next line reads Not on Merchant.. it does a bunch of stuff like that as it goes on it finds what it wants an buys it. Then it closes all the vendor stuff and goes to make the arrows and the macro just ends with the following message. Recipe HWSL not found.

What am I doning wrong? any help would be great

Well, sounds like it may be lag on the first part. Does the vendor window open before it starts to buy? If it doesn't you may need to change the delay to higher then what it is before it starts to buy. Also, be sure you have the ini file in the same directory as the macro.

[kyle]

Ok I will try that now and let you know, I had the ini file in the ini folder i will move it to the macro folder.

I do not remember what folder opens first when i run the macro I will watch for that and look at the floor to avoid lag as well

[kyle]

Thats solved it thanks, Great app :)

[Override]

No problem, I'm here to help.

[kyle]

Hi Override,

The macro worked great up to skill 202. Now my skill is 202 and here is what happens.

Fletching is at 202
No more items to sell
No more items to sell
No more items to sell
No more items to sell
Buying item
Not on Merchant
Buying item
Not on Merchant
Buying item
Not on Merchant
Buying item
Not on Merchant
Running recipe, which makes.
NULL
Could not find container NULL
No more NULL to sell!!!
Feltching is at 202


At this point the loop starts over

Is there something I need to set or do to go over 202

I have cliping turned down to 25
I dont seem to have any lag.
I have 50k plat in my pocket so money is not an issue
The buy window opens first when the macro starts so it does not seem to be any lag issue.

Any help would be great

[Daeas]

Code: Select all

/if (${Me.Skill[Fletching]}>202) { 
      /varset Staff "shadewood bow staff" 
      /varset Twine "hemp twine" 
      /varset CombItemName "RSRB" 
      /varset ItemTo "Rough Shadewood Recurve Bow" 
    }

needs to be

/if (${Me.Skill[Fletching]}>=202) {
/varset Staff "shadewood bow staff"
/varset Twine "hemp twine"
/varset CombItemName "RSRB"
/varset ItemTo "Rough Shadewood Recurve Bow"
}

and same thing here...

Code: Select all

/varset EndingVar 1
    /target ${MerchantName}
    /face
    /nomodkey /click right target
    /call OpenPacks
    /if (${Me.Skill[Fletching]}>202) { 
       /call Sell ${Staff} 
       /delay 1s 
       /call Sell ${Twine} 
       /delay 1s 
       /call Buy ${Staff} 10 
       /delay 1s 
       /call Buy ${Twine} 10 
       /delay 1s 

needs to be

/varset EndingVar 1
/target ${MerchantName}
/face
/nomodkey /click right target
/call OpenPacks
/if (${Me.Skill[Fletching]}>=202) {
/call Sell ${Staff}
/delay 1s
/call Sell ${Twine}
/delay 1s
/call Buy ${Staff} 10
/delay 1s
/call Buy ${Twine} 10
/delay 1s

then it works.

[Override]

LOL, sorry about that. When I tested it i was already over 202 so I didn't see that error. I have fixed it and updated it on the website already too. Thanks for letting me know.

[JVerse]

Ran most of your tradeskills ...and at the recipe menu ..doesnt find it and stops. Buys everything and sells perfect...but recipe ..just says cant find...Any suggestions?

[Oskar]

I did some work on the Pottery Macro so that it will get your skill to 199 doing multiple combines for creamic bowls. The only problem I ran into was the movement part at the end. It goes from the pottery wheel, to the kiln and then back to the pottery wheel. If you have DoKiln set to 0 it works perfectly. Maybe someone could look at it and fix it so DoKiln set to 1 also works?

This was my first attempt ever at programming or modifying a macro, so please be kind.

| pottery.mac
| Takes you from 1 to 199 in pottery
| Version 2.3
| Date: August 30, 2004
|
| Please be sure to get the lastest updates at http://www.soc-music.com/mq2/
|
| Before are the settings you need to change for you.
| This Macro can take you up to 188 in pottery.
| SkillMaxWanted can be change to what skill you want to stop at.
| MerchantNameA is which merchant has the water flask.
| MerchantNameB is which merchant has the firing sheets, sketchs, clay and brew.
| The DoKiln can be set to 1 or 0, if it is in 1 it will actually make the final
| item in the Kiln. This will save you on money, but take more time to skill up.
| Setting it to 0 will skip the Kiln.
|
| This Macro works best in the Abysmal Sea since all the components are there.
| You WILL need to be in front of Yoen Ormard (near the alchemy guys) for this macro to work.
|
| Disclaimer:
| Code was used from other programers also from the MQ Forums.
| This macro may not work any other place then the Abysmal Sea.
|


#event CombineError "#*#There was no place to put that#*#"
#event CombineError "#*#You cannot combine these items in this container type!#*#"
#event CombineError "#*#did not accept these items#*#"
#event ContUsed "#*#Someone else is using that. Try again later.#*#"
#include common/sell.inc
#include common/buy.inc
#include common/packs.inc
#include common/cleanpacks.inc

Sub Main
/declare OldSkill int outer
/declare UsingCont int outer
/declare DoKiln int outer
/declare SkillMaxWanted int outer
/declare PackCode string outer
/declare Component[10] string outer
/declare i int outer
/declare MerchantNameA string Outer
/declare MerchantNameB string Outer
/declare WFlask item outer
/declare CBrew item outer
/declare BClay item outer
/declare VialT item outer
/declare QSheet item outer
/declare LSketch item outer
/declare SBClay item outer
/declare DSketch item outer
/declare LBClay item outer
/declare SubComp item outer
/declare CombItemA string outer
/declare CombItemB string outer
/declare CombItemC string outer
/declare ItemTo string outer
/declare EndingVar int outer
/declare Levelname int outer
/varset OldSkill ${Me.Skill[Pottery]}
/declare Location int inner

/call ReadINIA pottery.ini "Abysmal Sea"
/if (!${Defined[LocArray]}) {
/echo No Loc Array Created...
/endmacro
}

| ************************************************
| * Change these settings to what you want. *
| ************************************************

/varset MerchantNameA "Yoen Ormard"
/varset MerchantNameB "Malkidiv"
/varset SkillMaxWanted 199
/varset DoKiln 0

| ************************************************
| ************************************************

:start
/varset UsingCont 0
/echo Pottery is at ${Me.Skill[Pottery]}

/if (${Me.Skill[Pottery]}>=${SkillMaxWanted}) {
/echo Pottery is at ${SkillMaxWanted}. Quiting!
/camp desktop
/endmacro
}

/if (${Me.Skill[Pottery]}<148) {
/varset WFlask "water flask"
/varset CBrew "crows special brew"
/varset BClay "small block of clay"
/varset VialT "vial sketch"
/varset QSheet "high quality firing sheet"
/varset CombItemA "PVA"
/varset CombItemB "PVB"
/varset SubComp "Unfired Poison Vial"
/varset ItemTo "Poison Vial"
}
/if (${Me.Skill[Pottery]}>=148 && ${Me.Skill[Pottery]}<168) {
/varset WFlask "water flask"
/varset CBrew "crows special brew"
/varset BClay "small block of clay"
/varset VialT "lined vial sketch"
/varset QSheet "high quality firing sheet"
/varset CombItemA "LPVA"
/varset CombItemB "LPVB"
/varset SubComp "Unfired Lined Poison Vial"
/varset ItemTo "Lined Poison Vial"
}
/if (${Me.Skill[Pottery]}>=168 && ${Me.Skill[Pottery]}<188) {
/varset WFlask "water flask"
/varset CBrew "crows special brew"
/varset BClay "small block of clay"
/varset VialT "sealed vial sketch"
/varset QSheet "high quality firing sheet"
/varset CombItemA "SPVA"
/varset CombItemB "SPVB"
/varset SubComp "Unfired Sealed Poison Vial"
/varset ItemTo "Sealed Poison Vial"
}
/if (${Me.Skill[Pottery]}>=188 && ${Me.Skill[Pottery]}<=199) {
/varset WFlask "water flask"
/varset LSketch "ceramic lining sketch"
/varset SBClay "small block of clay"
/varset QSheet "quality firing sheet"
/varset DSketch "casserole dish sketch"
/varset LBClay "large block of clay"
/varset CombItemA "UCDA"
/varset CombItemB "UCDB"
/varset CombItemC "UCDC"
/varset SubComp "Unfired ceramic lining"
/varset ItemTo "unfired casserole dish"
}

/varset EndingVar 1
/delay 1s
/target ${MerchantNameA}
/face
/delay 1s
/nomodkey /click right target
/delay 1s
/call OpenPacks
/if (${Me.Skill[Pottery]}>=188 && ${Me.Skill[Pottery]}<=199) {
/call Sell ${ItemTo}
/delay 1s
/call Sell ${WFlask}
/delay 1s
/call Sell ${LSketch}
/delay 1s
/call Sell ${SBClay}
/delay 1s
/call Sell ${QSheet}
/delay 1s
/call Sell ${DSketch}
/delay 1s
/call Sell ${LBClay}
/delay 1s
/call Buy ${WFlask} 40
/delay 1s
} else {
/call Sell ${ItemTo}
/delay 1s
/call Sell ${WFlask}
/delay 1s
/call Sell ${CBrew}
/delay 1s
/call Sell ${BClay}
/delay 1s
/call Sell ${VialT}
/delay 1s
/call Buy ${WFlask} 30
/delay 1s
}
/nomodkey /notify MerchantWnd DoneButton leftmouseup
/call ClosePacks
/delay 2s

/look
/call GoToMerchantB
/delay 2s
/target ${MerchantNameB}
/face
/delay 1s
/nomodkey /click right target
/delay 1s
/call OpenPacks
/if (${Me.Skill[Pottery]}>=188 && ${Me.Skill[Pottery]}<=199) {
/call Buy ${LSketch} 20
/delay 1s
/call Buy ${SBClay} 20
/delay 1s
/call Buy ${DSketch} 20
/delay 1s
/call Buy ${LBClay} 20
/delay 1s
/call Buy ${QSheet} 20
/delay 1s
} else {
/call Buy ${CBrew} 20
/delay 1s
/call Buy ${BClay} 20
/delay 1s
/call Buy ${VialT} 20
/delay 1s
/if (${DoKiln}==1) /call Buy ${QSheet} 20
/delay 1s
}
/nomodkey /notify MerchantWnd DoneButton leftmouseup
/call ClosePacks
/delay 2s

/itemtarget "Pottery Wheel"
/face
/look
/delay 1s
/nomodkey /click left item
/delay 2s
/doevents
/delay 1s
/call OpenPacks
/delay 2s

/call readIni "${CombItemA}"
:BeginA
/if (${EndingVar}==1) /call ClearCursor
/for i 1 to 10
/if (${EndingVar}==1) /call AddComp "${Component[${i}]}" ${i}
/next i
/if (${EndingVar}==1) /call DoCombine
/if (${EndingVar}==1) /goto :BeginA

/delay 1s
/call ClosePacks
/nomodkey /keypress esc

/if (${Me.Skill[Pottery]}>=188 && ${Me.Skill[Pottery]}<=199) /goto ish
/if (${DoKiln}==1) {
ish
/varset UsingCont 1
/call GoToKiln
/delay 1s
/itemtarget "Kiln"
/face
/look
/delay 1s
/nomodkey /click left item
/delay 2s
/doevents
/delay 1s
/call OpenPacks
/delay 2s
/varset EndingVar 1
/call readIni "${CombItemB}"
:BeginB
/if (${EndingVar}==1) /call ClearCursor
/for i 1 to 10
/if (${EndingVar}==1) /call AddComp "${Component[${i}]}" ${i}
/next i
/if (${EndingVar}==1) /call DoCombine
/if (${EndingVar}==1) /goto :BeginB

/delay 1s
/call ClosePacks
/nomodkey /keypress esc
}

/if (${Me.Skill[Pottery]}>=188 && ${Me.Skill[Pottery]}<=199) {
/varset UsingCont 0
/call BackToWheel
/delay 2s
/itemtarget "Pottery Wheel"
/face
/look
/delay 1s
/nomodkey /click left item
/delay 2s
/doevents
/delay 1s
/call OpenPacks
/delay 2s
/varset EndingVar 1
/call readIni "${CombItemC}"
:BeginC
/if (${EndingVar}==1) /call ClearCursor
/for i 1 to 10
/if (${EndingVar}==1) /call AddComp "${Component[${i}]}" ${i}
/next i
/if (${EndingVar}==1) /call DoCombine
/if (${EndingVar}==1) /goto :BeginC

/delay 1s
/call ClosePacks
/nomodkey /keypress esc
/varset Location 8
/delay 1s
}

/call GoToMerchantA
/delay 1s
/target ${MerchantNameA}
/face
/delay 1s
/nomodkey /click right target
/delay 1s
/call OpenPacks
/if (${Me.Skill[Pottery]}>=188 && ${Me.Skill[Pottery]}<=199) {
/call Sell ${ItemTo}
/delay 1s
/call Sell ${LSketch}
/delay 1s
/call Sell ${SBClay}
/delay 1s
/call Sell ${QSheet}
/delay 1s
/call Sell ${DSketch}
/delay 1s
/call Sell ${LBClay}
/delay 1s
} else {
/call Sell ${ItemTo}
/delay 1s
/call Sell ${WFlask}
/delay 1s
/call Sell ${CBrew}
/delay 1s
/call Sell ${BClay}
/delay 1s
/call Sell ${VialT}
/delay 1s
}
/nomodkey /notify MerchantWnd DoneButton leftmouseup
/call ClosePacks
/delay 2s

/goto :start

/return

Sub readIni(RecipeName)
/declare Container string

/echo Running ${RecipeName} recipe

/if (${Ini["pottery.ini","${RecipeName}",-1,"NOTFOUND"].Equal["NOTFOUND"]}) {
/echo Recipe ${RecipeName} not found
/endmacro
}

/varset Container ${Ini[pottery.ini,${RecipeName},Cont,Enviro]}

/if (${Container.Equal[Enviro]}) {
/varset PackCode Enviro
} else {
/varset PackCode ${FindItem[=${Container}].InvSlot}

/if (${PackCode.Equal[NULL]}) {
/echo Could not find container ${Container}
/varset EndingVar 2
/return
}
| pack1 = 22, ... , pack8 = 29
/varset PackCode pack${Math.Calc[${PackCode}-21].Int}
}

/call cleanPack ${Container}

/for i 1 to 10
/varset Component[${i}] ${Ini[pottery.ini,${RecipeName},Comp${Math.Calc[${i}-1].Int},NOTFOUND]}
/next i
/return

sub ClearCursor
:Loop
/if (!${Cursor.ID}) /return
/if (${Me.Skill[Pottery]}>=188 && ${Me.Skill[Pottery]}<=199) /autoinv
/if (${DoKiln}==1) {
/autoinv
} else {
/destroy
}
/delay 5
/doevents
/goto :Loop
/return

sub DoCombine
:Loop
/combine ${PackCode}
/delay 1s
/if (${PackCode.Equal[Enviro]}) /delay 1s
/doevents
/if (${InvSlot[${PackCode}].Item.Items}) /goto :Loop
/delay 5
/if (${Me.Skill[Pottery]}>${OldSkill}) {
/echo Your Pottery Went Up!! It's now ${Me.Skill[Pottery]}!
/varset OldSkill ${Me.Skill[Pottery]}
}
/return

sub AddComp(CompName, PackSlot)
/if (${CompName.Equal[NOTFOUND]}) /return

/if (!${FindItem[=${CompName}].ID}) {
/echo Could not find ${CompName} in inventory
/beep
/varset EndingVar 2
/return
}

:Loop
/nomodkey /ctrl /itemnotify ${FindItem[=${CompName}].InvSlot} leftmouseup

/if (!${Cursor.ID}) {
/delay 1
/goto :Loop
}

/if (${PackCode.Equal[Enviro]}) {
/nomodkey /itemnotify ${InvSlot[enviro${PackSlot}]} leftmouseup
} else {
/nomodkey /itemnotify in ${PackCode} ${PackSlot} leftmouseup
}
/return

Sub Event_CombineError
/varset EndingVar 2
/return

Sub Event_ContUsed
/echo Container in use. Waiting 30 seconds and trying again.
/delay 30s
/if (${UsingCont}==0) /itemtarget "Pottery Wheel"
/if (${UsingCont}==1) /itemtarget "Kiln"
/delay 1s
/nomodkey /click left item
/delay 2s
/doevents
/return

Sub GoToMerchantA
/declare Location int inner
/echo Going to ${MerchantNameA}.
/if (${DoKiln}==1) {
/varset Location 14
:starta
/if (${Location}>0) {
:MoveLoopa
/if (${Location}==9) /goto onea
/face nolook loc ${LocArray[${Location}]}
/if (${Math.Distance[${LocArray[${Location}]}]}>4) {
/nomodkey /keypress forward hold
/face nolook loc ${LocArray[${Location}]}
/look
/if (${Location}==11) /keypress u
}
/if (${Math.Distance[${LocArray[${Location}]}]}<=4) {
/nomodkey /keypress forward
/goto :nexta
}
/goto :MoveLoopa
:nexta
/delay 1s
/varset Location ${Math.Calc[${Location}-1]}
/goto :starta
}
onea
/varset Location 5
:startb
/if (${Location}>0) {
:MoveLoopb
/if (${Location}==0) /goto oneb
/face nolook loc ${LocArray[${Location}]}
/if (${Math.Distance[${LocArray[${Location}]}]}>4) {
/nomodkey /keypress forward hold
/face nolook loc ${LocArray[${Location}]}
/look
/if (${Location}==2) /keypress u
}
/if (${Math.Distance[${LocArray[${Location}]}]}<=4) {
/nomodkey /keypress forward
/goto :nextb
}
/goto :MoveLoopb
:nextb
/delay 1s
/varset Location ${Math.Calc[${Location}-1]}
/goto :startb
}
oneb
} else {
/varset Location 8
:startc
/if (${Location}>0) {
:MoveLoopb
/if (${Location}==0) /goto onec
/face nolook loc ${LocArray[${Location}]}
/if (${Math.Distance[${LocArray[${Location}]}]}>4) {
/nomodkey /keypress forward hold
/face nolook loc ${LocArray[${Location}]}
/look
/if (${Location}==2) /keypress u
}
/if (${Math.Distance[${LocArray[${Location}]}]}<=4) {
/nomodkey /keypress forward
/goto :nextc
}
/goto :MoveLoopb
:nextc
/delay 1s
/varset Location ${Math.Calc[${Location}-1]}
/goto :startc
}
onec
}
/return

Sub GoToMerchantB
/declare Location int inner
/echo Going to ${MerchantNameB}.
/for Location 1 to 8
:MoveLoop
/face nolook loc ${LocArray[${Location}]}
/if (${Math.Distance[${SHArray[${Location}]}]}>4) {
/nomodkey /keypress forward hold
/face nolook loc ${LocArray[${Location}]}
/look
/if (${Location}==3) /keypress u
}
/if (${Math.Distance[${LocArray[${Location}]}]}<=4) {
/nomodkey /keypress forward
/goto :next
}
/goto :MoveLoop
:next
/delay 1s
/next Location
/return

Sub GoToKiln
/declare Location int inner
/echo Going to Kiln.
/for Location 8 to 14
:MoveLoop
/face nolook loc ${LocArray[${Location}]}
/if (${Math.Distance[${SHArray[${Location}]}]}>4) {
/nomodkey /keypress forward hold
/face nolook loc ${LocArray[${Location}]}
/look
/if (${Location}==12) /keypress u
}
/if (${Math.Distance[${LocArray[${Location}]}]}<=4) {
/nomodkey /keypress forward
/goto :next
}
/goto :MoveLoop
:next
/delay 1s
/next Location
/return

Sub BackToWheel
/declare Location int inner
/echo Going back to Pottery Wheel.
/for Location 14 to 20
:MoveLoop
/face nolook loc ${LocArray[${Location}]}
/if (${Math.Distance[${SHArray[${Location}]}]}>4) {
/nomodkey /keypress forward hold
/face nolook loc ${LocArray[${Location}]}
/look
/if (${Location}==17) /keypress u
}
/if (${Math.Distance[${LocArray[${Location}]}]}<=4) {
/nomodkey /keypress forward
/goto :next
}
/goto :MoveLoop
:next
/delay 1s
/next Location
/return

Sub ReadINIA(FileName,SectionName)
/echo Attempting to Read Section "${SectionName}" Zone Information from ${FileName}...
/delay 1s

/if (${Ini[${FileName},${SectionName},-1,NO].Equal[NO]}) {
/echo "${SectionName}" is not a Valid Section for FILE:${FileName}, ending macro...
/delay 1s
/return
}
/declare nValues int local 1
/declare nArray int local 0
/declare KeySet string local ${Ini[${FileName},${SectionName}]}

| ****************** Locs ****************************
:CounterLooplo
/if (${String[${Ini[${FileName},${SectionName},Loc${nValues}]}].Equal[null]}) {
/varcalc nValues ${nValues}-1
/goto :MakeArraylo
}
/varcalc nValues ${nValues}+1
/goto :CounterLooplo
:MakeArraylo
/if (!${nValues}) /return
/if (${nValues}>0) {
/echo Declaring Loc Array...
/declare LocArray[${nValues}] string outer
}
/for nArray 1 to ${nValues}
/varset LocArray[${nArray}] ${Ini[${FileName},${SectionName},Loc${nArray}]}
/next nArray



/echo "${SectionName}" Zone Information Read Successfully from ${FileName}...
/delay 1s
/return

pottery.ini

[PVA]
Cont=Enviro
Comp0=crows special brew
Comp1=small block of clay
Comp2=vial sketch
Comp3=water flask

[LPVA]
Cont=Enviro
Comp0=crows special brew
Comp1=small block of clay
Comp2=lined vial sketch
Comp3=water flask

[SPVA]
Cont=Enviro
Comp0=crows special brew
Comp1=small block of clay
Comp2=sealed vial sketch
Comp3=water flask

[UCDA]
Cont=Enviro
Comp0=ceramic lining sketch
Comp1=small block of clay
Comp2=water flask

[PVB]
Cont=Enviro
Comp0=unfired poison vial
Comp1=high quality firing sheet

[LPVB]
Cont=Enviro
Comp0=unfired lined poison vial
Comp1=high quality firing sheet

[SPVB]
Cont=Enviro
Comp0=unfired sealed poison vial
Comp1=high quality firing sheet

[UCDB]
Cont=Enviro
Comp0=unfired ceramic lining
Comp1=quality firing sheet

[UCDC]
Cont=Enviro
Comp0=large block of clay
Comp1=casserole dish sketch
Comp2=ceramic lining
Comp3=water flask

[Abysmal Sea]
Loc1=110.96, 20.36
Loc2=178.05, 50.08
Loc3=178.05, 69.77
Loc4=92.04, 111.11
Loc5=92.67, 260.68
Loc6=-204.01, 261.08
Loc7=-225.75, 204.70
Loc8=-252.69, 202.40
Loc9=-225.75, 204.70
Loc10=-204.01, 261.08
Loc11=-254.69, 259.14
Loc12=-271.72, 258.73
Loc13=-329.85, 260.15
Loc14=-328.94, 241.51
Loc15=-329.85, 260.15
Loc16=-281.08, 258.73
Loc17=-267.08, 258.73
Loc18=-204.01, 261.08
Loc19=-225.75, 204.70
Loc20=-252.69, 202.40

[Override]

Ran most of your tradeskills ...and at the recipe menu ..doesnt find it and stops. Buys everything and sells perfect...but recipe ..just says cant find...Any suggestions?

Be sure your .ini file ARE in the same directory as the macro file.

And I will be releasin my 199 version too soon. I has been busy in RL, so I haven't got around to adding it yet.

[Shamna]

Hi there,nice job on this mac,really loved it....any chance you will add anything for alchemy ? pretty please :)....

[Override]

I will once I get the rest of them updated and finshed. I need to finish up my pottery to 199, blacksmithing to 180, and tailoring one.

[episix]

I read that someone had an error with /itemtarget earlier in the thread, but i never saw a solution to it.
Whenever i run one of the tradeskill macros as soon as it gets to /itemtarget Forge, Kiln, etc I CTD, can anyone link me to where the fix was? thanks

[Override]

Try to redownload and recompile MQ2. I think that fixed it to one person I was talking to.

[episix]

Tried that, stiill crashing ;\