${Me.Grouped}
Moderator: MacroQuest Developers
${Me.Grouped}
This sometimes gets flagged as false if the group leader changes or someone leaves the group or something, and then the only way to refresh it back to true is to disband and then rejoin.
-
quixote398
- orc pawn
- Posts: 12
- Joined: Mon Jul 19, 2004 12:47 am
couldn't line 1522 in MQ2DataTypes.cpp be changed from...to... ?
basically just compare all the group members with an or operator, so if any one of them has data(is true), then the grouped datatype would return true.
Code: Select all
Dest.DWord=pChar->GroupMember1[0];Code: Select all
Dest.DWord=(pChar->GroupMember1[0]|pChar->GroupMember2[0]|pChar->GroupMember3[0]|pChar->GroupMember4[0]|pChar->GroupMember5[0]);basically just compare all the group members with an or operator, so if any one of them has data(is true), then the grouped datatype would return true.
You *could* so something like that, just like you could hack around the many bugs in the item and spell databases, and the deal where Me.Casting clears itself all the time on a bard, even though you're casting, and...
The thing is, as I understand it, the MQ Data structs are meant to reflect the "true" contents of memory, as they'd appear just watching that location in a debugger. By all means use whatever methods you have to in your macros/plugins to make them work correctly, but changing MQ2's returns is a grey area...you kind of have to judge case-by-case whether it would be more intuitive to return the value unmolested or fudge it a bit.
The thing is, as I understand it, the MQ Data structs are meant to reflect the "true" contents of memory, as they'd appear just watching that location in a debugger. By all means use whatever methods you have to in your macros/plugins to make them work correctly, but changing MQ2's returns is a grey area...you kind of have to judge case-by-case whether it would be more intuitive to return the value unmolested or fudge it a bit.
-
quixote398
- orc pawn
- Posts: 12
- Joined: Mon Jul 19, 2004 12:47 am
Well, if you look at the original code, Grouped was never actually in the data structure. Originally it was thought it was, but later on it was discovered that it was actually the first character of the first group member's name. All five group member's names were being stored and only recently discovered.
The original code was actually just checking the first group member slot and returning true if there was a name there, or false if not. It'd make sense now to extend the "Grouped" check to see if any of the five group slots had someone in them.
Sony's code does not shift group members around. You can notice this in game when you invite a first person, and then a second person, first person leaves group, get a third person, and re-invite first person, the first and third persons have switched group slots. The code just fills in group slots on a first come, first serve basis. but it doesn't move the order of the slots if someone leaves.
So the "best" way to see if someone is grouped is to do a logical OR on the groupslots, so if any one of them has someone in it, return TRUE for grouped.
The original code was actually just checking the first group member slot and returning true if there was a name there, or false if not. It'd make sense now to extend the "Grouped" check to see if any of the five group slots had someone in them.
Sony's code does not shift group members around. You can notice this in game when you invite a first person, and then a second person, first person leaves group, get a third person, and re-invite first person, the first and third persons have switched group slots. The code just fills in group slots on a first come, first serve basis. but it doesn't move the order of the slots if someone leaves.
So the "best" way to see if someone is grouped is to do a logical OR on the groupslots, so if any one of them has someone in it, return TRUE for grouped.
-
Night Hawk
- a grimling bloodguard
- Posts: 590
- Joined: Fri Aug 13, 2004 4:56 pm
