06/16 bugs, FindItem

A forum for reporting bugs NOT related to custom plugins.

Moderator: MacroQuest Developers

Oid
a snow griffon
a snow griffon
Posts: 416
Joined: Thu Oct 17, 2002 3:26 am
Contact:

06/16 bugs, FindItem

Post by Oid » Thu Jun 17, 2004 2:34 am

Works on items in main inventory slots, does not work in packs.

Apparently is also not working with mq2exchangeitem

also opcodes appear to ahve changed, if that makes a differance on that function i been bugging you about lax.
Smokey the Lax says only you can prevent reproduction.

dman
a hill giant
a hill giant
Posts: 181
Joined: Fri Dec 05, 2003 12:54 pm

Post by dman » Thu Jun 17, 2004 2:38 am

${FindItemCount} is also returning 0 on all bagged items.

User avatar
doanchano
orc pawn
orc pawn
Posts: 27
Joined: Sun Jan 11, 2004 11:31 pm

Post by doanchano » Thu Jun 17, 2004 1:07 pm

Same here re-compiled no change.
Always returns item not found.

I can fill my inventory with an item and still wont find it.

User avatar
bohicaseti
a lesser mummy
a lesser mummy
Posts: 33
Joined: Sat Mar 06, 2004 5:55 am

Post by bohicaseti » Thu Jun 17, 2004 2:14 pm

Yep, giving an "Invalid item slot 'null'" spew any time I attempt to grab something out of a bag.
Friends help friends move . . . .
Real friends help friends move dead bodies.

Ogre_Luvr
a lesser mummy
a lesser mummy
Posts: 52
Joined: Thu Dec 18, 2003 10:11 pm
Location: DC

status

Post by Ogre_Luvr » Fri Jun 18, 2004 8:36 am

Im still having this problem as of last night around 11:00 pm when i got the update...

is someone working on it? or is this something i need to fix in my macro

this will summon forever .. and ever .. and ever :cry:

Code: Select all

	/if (!${Math.Calc[${FindItemCount["Summoned: Black Bread"]}>20]}) {
		/call noFailMem 7 "Abundant Food"
		:waitFood
		/delay 1
		/if (!${Me.SpellReady["Abundant Food"]}) /goto :waitFood
		/call cast "Abundant Food"
		/autoinv
	}

Kracken
orc pawn
orc pawn
Posts: 24
Joined: Sat Dec 20, 2003 3:01 pm

Calc fix

Post by Kracken » Fri Jun 18, 2004 10:06 am

Yes it appears the new Calc is broken.

Credit Caladine for fix
"Go into MQ2Utilities.c and uncomment the old calculate "ActualCalculate", and uncomment the Benchmarks line at the bottom of the file with ActualCalculate, and comment out the other."

User avatar
blueninja
a grimling bloodguard
a grimling bloodguard
Posts: 541
Joined: Thu Aug 28, 2003 7:03 am
Location: Göteborg, Sweden

Re: Calc fix

Post by blueninja » Fri Jun 18, 2004 12:11 pm

Kracken wrote:Credit Caladine for fix
"Go into MQ2Utilities.c and uncomment the old calculate "ActualCalculate", and uncomment the Benchmarks line at the bottom of the file with ActualCalculate, and comment out the other."
That's not a fix, that's a workaround.. :(

Ogre_Luvr
a lesser mummy
a lesser mummy
Posts: 52
Joined: Thu Dec 18, 2003 10:11 pm
Location: DC

Post by Ogre_Luvr » Fri Jun 18, 2004 1:56 pm

Is there anything else i need to comment/uncomment? its still not counting correctly

Benchmark(bmCalculate,Ret=ActualCalculate(Buffer,Result));
//Benchmark(bmCalculate,Ret=FastCalculate(Buffer,Result));

and the method:
BOOL ActualCalculate(PCHAR szFormula, DOUBLE &Result) {

brian
decaying skeleton
decaying skeleton
Posts: 1
Joined: Fri Jun 18, 2004 2:25 pm

Post by brian » Fri Jun 18, 2004 2:26 pm

FindItem itself is still broken as well :(

Kracken
orc pawn
orc pawn
Posts: 24
Joined: Sat Dec 20, 2003 3:01 pm

fix

Post by Kracken » Fri Jun 18, 2004 4:39 pm

Ogre_Luvr

Yes you need to find the begining of the function ActualCalculate take out the /* and go to the end and take out the /**/

The code is a rather large block and should show up as green text. Or just use the ctl-f and use the find for the word ActualCalculate.

It will fix your macros without sacrificing functionality, so yes it fixes you problem. Geez

Ogre_Luvr
a lesser mummy
a lesser mummy
Posts: 52
Joined: Thu Dec 18, 2003 10:11 pm
Location: DC

Post by Ogre_Luvr » Fri Jun 18, 2004 5:13 pm

I have done that and i can send you the CPP file if you would like to review it. I tried to post it but it was too big

Caladine
a hill giant
a hill giant
Posts: 164
Joined: Fri Feb 13, 2004 9:29 pm

Post by Caladine » Fri Jun 18, 2004 5:19 pm

Yeah, it's hardly a fix, just a workaround to use the old calc function until a reason is found to see why the new function doesn't work.

I have a few macros that break it at the moment, so I'll probably be playing with the debugger later tonight.

Riven
a lesser mummy
a lesser mummy
Posts: 68
Joined: Sat Jan 31, 2004 12:14 pm
Location: Missouri

problems getting the work aground to work

Post by Riven » Sat Jun 19, 2004 4:59 pm

well im trying to do the work around. could one if u that has it working pm me with the code that your changeing. thanks

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Post by dont_know_at_all » Sat Jun 19, 2004 6:27 pm

Fixed in latest zip.

Riven
a lesser mummy
a lesser mummy
Posts: 68
Joined: Sat Jan 31, 2004 12:14 pm
Location: Missouri

fixed

Post by Riven » Sat Jun 19, 2004 6:31 pm

u guys have fixed the issue with the new,

Code: Select all

Benchmark(bmCalculate,Ret=ActualCalculate(Buffer,Result));
well ok ill check to see if that new zip works with the mac.