ok i give up

Need help running MacroQuest 1? Too bad! Use MQ2.

Moderator: MacroQuest Developers

van
a lesser mummy
a lesser mummy
Posts: 37
Joined: Mon Jun 24, 2002 1:04 am

ok i give up

Post by van » Tue Jun 25, 2002 12:30 am

can sombody please tell me what i butch... errr did wrong.
cheese mac converted to bear meat maker that fails randomly (im thinking lagg) added delays that did not help. maybe just the wrong spot. here is the code before adding delays to everything and still having it fail from time to time.

fails from time to time on the sell and every now and then fails after buying bear meat saying my inv is full.. no more room

it works but if it ran without failing it would be better


| - bear.mac -
|
#include routines.mac

Sub Main

/mqlog
/varcalc v50 $char(plat)*10+$char(gold)
/varset t0 3000
/varset t1 0
/call FindCombiner baking
/if $return==99 /return
/varset v80 $return

:StartLoop

/cleanup
/click left auto
/click right inv $v80

/if $pack($v80,empty)==FALSE /call CleanPack
/if $pack($v80,empty)==FALSE /goto :TooFull

/sendkey down ctrl
/call Makebear
/sendkey up ctrl
| /if n $t1==0 /call CastCHA
/call SellBuy

/if $t0==0 /call LogStats

/goto :StartLoop

:TooFull
/echo You are too full on stuff, aborting macro.
/return


Sub CleanPack
/varcalc v2 $pack($v80,slots)-1
/sendkey down shift
/for v1 0 to $v2
/click left pack $v80 $v1
/click left auto
/next v1
/sendkey up shift
/return


Sub Makebear

:Makebear

/finditem "bear meat"
/click left pack $v80 0

/finditem "filleting knife"
/click left pack $v80 3

/if "$item($v80,0,name)"=="bear meat" /if "$item($v80,3,name)"=="filleting knife" /goto :DoCombine
/return

:DoCombine
/click left pack $v80 combine

:LoopWait
/if "$cursor()"=="NULL" /goto :LoopWait
/if "$cursor(name)"=="filleting knife" /goto :Failed
/click left auto
:LoopFail
/if "$cursor()"=="NULL" /goto :LoopFail
:Failed
/click left auto

/goto :Makebear

/return


Sub SellBuy

| Open merchant
/click left auto
/target drible
/face
/press u
/delay 25

/sendkey down shift

| Sell our bearmeat
:Sellbear
/varset v98 $char(gold)
/finditem "filleted bear"
/if $find()==FALSE /goto :DoneSelling
/click left merchant buy
:WaitSale
/if n $v98==$char(gold) /goto :WaitSale
/goto :Sellbear

:DoneSelling
/varset v51 0
/finditem "bear meat"
/if $find()==TRUE /varset v51 1
/goto :buybearmeat


:buybearmeat

| Buy bearmeat
/click left merchant 11
/call BuyItem
/call BuyItem
/call BuyItem
/call BuyItem
/call BuyItem

/sendkey up shift
/press esc

/return


Sub LogStats

| Calc profit in gold
/varcalc v51 $char(plat)*10+$char(gold)-$v50

| calc plat/hr
/varcalc v52 $v51*360/$running

| Plat
/varcalc v53 $v51/10

| left over gold
/varcalc v54 $v51%10

/echo Profit: $v53.$v54pp, avg: $v52pp/hr
/mqlog Run time: $running sec, Profit: $v53.$v54pp, Average = $v52pp/hr

/varset t0 3000

/return

Sub BuyItem
/varcalc v98 $char(gold)*100+$char(silver)*10+$char(copper)
/click left merchant buy
:WaitBuy
/varcalc v97 $char(gold)*100+$char(silver)*10+$char(copper)
/if n $v98==$v97 /goto :WaitBuy
/return

Sub CastCHA
/target myself
/call Event_CastFizzle
:LoopFizzle
/doevents
/if n $t9>0 /goto :LoopFizzle
/varset t1 30m
/return

Sub Event_CastFizzle
/delay 5
/cast 1
/varset t9 7s
/return

SurfAngel
orc pawn
orc pawn
Posts: 14
Joined: Thu Jun 20, 2002 2:50 pm

Post by SurfAngel » Tue Jun 25, 2002 5:27 pm

Hmmm... where in the code do you drop the fillet into inventory?

Domosan
I had to suck up to get this title ;)
Posts: 101
Joined: Mon Jun 17, 2002 3:54 pm

Post by Domosan » Wed Jun 26, 2002 12:17 am

Right Here:

Code: Select all

:LoopWait 
/if "$cursor()"=="NULL" /goto :LoopWait 
/if "$cursor(name)"=="filleting knife" /goto :Failed 
/click left auto 
:LoopFail 
/if "$cursor()"=="NULL" /goto :LoopFail 
:Failed 
/click left auto 

/goto :Makebear 

Domosan
I had to suck up to get this title ;)
Posts: 101
Joined: Mon Jun 17, 2002 3:54 pm

Post by Domosan » Wed Jun 26, 2002 7:42 am

This works for making the bear fillets -- you can add in your spell casting if you'd like at any point.

Keep in mind that fillets have a trivial of 143, which means you will most likely fail more often than with mature cheese, I averaged slightly less plat per hour using this one as opposed to my cheese.mac.

Code: Select all

| - BearMeat.mac - 
| * Modified from Cheese.mac *
| * Original by Plazmic * 
| * Edited by Yocals, Mon Jun 24, 2002 11:42 pm* 
| * Edited by Zeltren, Tue Jun 25, 2002 3:26 pm* 
Sub Main 
   /stand 
   /press CTRL
   /press shift
   /press alt

   /mqlog 
   /varcalc v50 $char(plat)*10+$char(gold) 
   /varset t0 3000 
   /call FindCombiner baking 
   /if $return==99 /endmacro 
   /varset v80 $return 
   /mqlog Will now start to make money, you started with $v50gp 

   | make sure loop is running right 
   :Loopsub 
   /varset v37 1    
   /call Loopsub 
   /mqlog We had a subroutine PANIC, skiped one... so here we go back to the routines, maybe done by lag... 
   /goto :Loopsub 
/return 

sub Loopsub 
   :LOOPSTART
   /cleanup
   /face loc -100,1167 
|   /if $gm==TRUE /call Crap 
   /sendkey up shift

   /sendkey down shift 
   /click left auto 
   /click right inv $v80 
   /finditem "filleting Knife" 
   /click left auto 
   /sendkey up shift 

   /if $pack($v80,empty)==FALSE /call CleanPack 

   /sendkey down ctrl 
   /call MakeMeat 
   /sendkey up ctrl 
   /cleanup
   /varset v37 0    
   /call SellBuy 
   /if $t0==0 /call LogStats 
   /goto :LOOPSTART 
   /endmacro 
/return 

Sub CleanPack 
   /varcalc v2 $pack($v80,slots)-1 
   /sendkey down shift 
   /for v1 0 to $v2 
      /click left pack $v80 $v1 
      /click left auto 
   /next v1 
   /sendkey up shift 
/return 


Sub MakeMeat 
  
   :MakeMeat 
      /finditem "Bear Meat" 
      /click left pack $v80 0 

      /finditem "filleting Knife" 
      /click left pack $v80 1 
      /if $cursor(value)!=NULL /goto :AutoDropMeat 
      /if $find()==FALSE /endmacro 

      /if "$item($v80,0,name)"=="Bear Meat" /if "$item($v80,1,name)"=="filleting Knife" /goto :DoCombine 
      /return 

      :DoCombine 
      /click left pack $v80 combine 

      :AutoDropMeat 
      /if $cursor(value)!=342 /click left auto
      /if $cursor(value)!=342 /goto :AutoDropMeat
      /if $cursor(value)==342 /click left auto
   /goto :MakeMeat 
/return 


Sub SellBuy 
   :StartSellBuy
   /if n $v37!=0 /call Loopsub 
   | Open merchant 
   /click left auto 
   | PANIC if holding item! 
   /if $cursor(value)!=NULL /goto :ITEMINHAND 
   /target Nicoela 
   /face 
   /mouseto auto 
   /mouseto merchant buy 
   /varset v38 $mouse(x) 
   :mousedelay 
   /press u 
   /press u 
   /press u 
   /mouseto merchant buy 
   /varset v39 $mouse(x) 
   /if $38==$39 /goto :mousedelay 

   /sendkey down shift 

   | This will save your arse instead of selling your EXPENSIVE ITEMS!!! 
   /goto :SellMeat 
   :ITEMINHAND 
   /cleanup
   /click left auto
   /mqlog ITEM IN HAND, PANIC!!! 
   /goto :StartSellBuy


   | Sell our Meat 
   :SellMeat 
      /varset v98 $char(gold) 
      /varset v55 $char(silver) 
      /varset v56 $char(copper) 
      /finditem "filleted bear" 
      /if $find()==FALSE /goto :SellOldMeat 
      /click left merchant buy 
      :WaitSale 
      /if n $v98!=$char(gold) /goto :SellMeat 
      /if n $v55!=$char(silver) /goto :SellMeat 
      /if n $v56!=$char(copper) /goto :SellMeat 
   /goto :WaitSale 

   | Sell our milk 
   :SellOldMeat 
      /varset v98 $char(gold) 
      /varset v55 $char(silver) 
      /varset v56 $char(copper) 
      /finditem "Bear Meat" 
      /if $find()==FALSE /goto :DoneSelling 
      /click left merchant buy 
      :WaitSale2 
      /if n $v98!=$char(gold) /goto :SellOldMeat 
      /if n $v55!=$char(silver) /goto :SellOldMeat 
      /if n $v56!=$char(copper) /goto :SellOldMeat 
   /goto :WaitSale2 

   :DoneSelling 

   | Buy Bear Meat 
   /click left merchant 11 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem 
   /call BuyItem

   /sendkey up shift 
   /mouseto auto 
   /varset v37 1 
/return 

Sub LogStats 

   | Calc profit in gold 
   /varcalc v51 $char(plat)*10+$char(gold)-$v50

   | calc plat/hr 
   /varcalc v52 $v51*360/$running 

   | Plat 
   /varcalc v53 $v51/10 

   | Total Plat = Plat + Plat_in_bank
   /varcalc v59 $v53+$char(plat,bank)

   | left over gold 
   /varcalc v54 $v51%10 

   /mqlog Run time: $running sec, Profit: $v53.$v54pp, Average = $v52pp/hr
   /mqlog Total Plat:  $v59

   /varset t0 3000 

/return 

Sub Crap 
  /afk Sorry RL problems, need to log. 
  /cleanup 
  /mqlog GM in zone... camping 
  /sit 
  /reply Sorry RL problems, need to log. 
  /delay 20 
  /camp 
  /unload 
/return 

Sub FindCombiner 
   /varset p2 99 
   /for v99 0 to 7 
      /if "$pack($v99,combine)"=="$p0" /varset p2 $v99 
   /next v99 
   /if $p2==99 /echo You do not seem to have a valid $p0 container. 
/return $p2 

Sub BuyItem 
   /varset v98 $char(gold) 
   /varset v55 $char(silver) 
   /varset v56 $char(copper) 
   /click left merchant buy 
   :WaitBuy 
      /if n $v98!=$char(gold) /goto :Waitend 
      /if n $v55!=$char(silver) /goto :Waitend 
      /if n $v56!=$char(copper) /goto :Waitend 
   /goto :WaitBuy 
   :Waitend 
/return 

van
a lesser mummy
a lesser mummy
Posts: 37
Joined: Mon Jun 24, 2002 1:04 am

Post by van » Wed Jun 26, 2002 11:29 am

Thanks =)
Ill try it out now.

cheese was only making me 123pp an hour with 143 skill and 143 char.

this one topped out at 380pp

faction i think plays a part maybe.

ill post my results after testing it. thanks

van
a lesser mummy
a lesser mummy
Posts: 37
Joined: Mon Jun 24, 2002 1:04 am

Post by van » Wed Jun 26, 2002 11:59 am

This is the reason i like this better than cheese.... thanks for the help again.. it seems to be working fine for now.


with the newcheese.mac

[2002/05/25 12:33:05] Run time: 408 sec, Profit: 23.6pp, Average = 208pp/hr

[2002/05/25 12:53:02] Run time: 370 sec, Profit: 1.4pp, Average = 13pp/hr

[2002/05/25 13:56:24] Run time: 436 sec, Profit: 21.5pp, Average = 177pp/hr

[2002/05/25 14:04:19] Run time: 910 sec, Profit: 46.6pp, Average = 184pp/hr


And with your help...

[2002/05/26 11:52:46] [2002/05/26 11:52:46] Will now start to make money, you started with 245gp

[2002/05/26 11:58:24] Run time: 338 sec, Profit: 37.2pp, Average = 396pp/hr

[2002/05/26 12:04:18] Run time: 336 sec, Profit: 39.9pp, Average = 428pp/hr

cyberglitch
a lesser mummy
a lesser mummy
Posts: 42
Joined: Wed Jun 26, 2002 4:40 pm

Post by cyberglitch » Wed Jun 26, 2002 4:41 pm

Where is the merchant Drible located for this macro? Would love to test it out.

Sparr
a hill giant
a hill giant
Posts: 159
Joined: Mon Jun 24, 2002 5:41 am

err

Post by Sparr » Wed Jun 26, 2002 6:35 pm

yeah, i been trying to find out the same thing. and where do you get a fillet knife? Zeltrens script doesnt like me so Ill be converting my own to do bear meat if I can find out where.

van
a lesser mummy
a lesser mummy
Posts: 37
Joined: Mon Jun 24, 2002 1:04 am

Post by van » Wed Jun 26, 2002 6:49 pm

echo caverns but you can use any vendor that sells bear/wolf meat

the faction helps.. i am currently warmly with him.


so if you are evil thats the place to go.

added loopd detection to my original script as the other dropped my knife on the ground fixed my issues.

knife is scaler mold + 3 metal bits unstacked and 1 water

currently pulling 337-400pp an hour. more bags the better as always. datarate of 8

KneightSkye
orc pawn
orc pawn
Posts: 14
Joined: Sun Jul 07, 2002 6:27 pm

hmmm

Post by KneightSkye » Sun Jul 07, 2002 6:31 pm

what script are you using van?
because i am using the one posted by domosan up above and i have ally faction with my merchant and 108 cha.... averaging according to log 101pp a hour to 195pp.... no where near 300+

van
a lesser mummy
a lesser mummy
Posts: 37
Joined: Mon Jun 24, 2002 1:04 am

Post by van » Sun Jul 07, 2002 11:59 pm

Code: Select all

| - bear.mac -
|
#include routines.mac

Sub Main
|This sets how many repetitions to go through in a Wait loop before reporting Frozen 
   /varset v92 200 
   /mqlog
   /varcalc v50 $char(plat)*10+$char(gold)
   /varset t0 3000
   /varset t1 0
   /call FindCombiner baking
   /if $return==99 /return
   /varset v80 $return

   :StartLoop

   /cleanup
   /click left auto
   /click right inv $v80

   /if $pack($v80,empty)==FALSE /call CleanPack
   /if $pack($v80,empty)==FALSE /goto :TooFull

   /sendkey down ctrl
   /call Makebear
   /sendkey up ctrl
|   /if n $t1==0 /call CastCHA
   /call SellBuy

   /if $t0==0 /call LogStats

/goto :StartLoop

:TooFull

 /goto :StartLoop


Sub CleanPack
   /varcalc v2 $pack($v80,slots)-1
   /sendkey down shift
   /for v1 0 to $v2
      /click left pack $v80 $v1
      /click left auto
   /next v1
   /sendkey up shift
/return


Sub Makebear

   :Makebear

      /finditem "bear meat"
      /click left pack $v80 0

      /finditem "filleting knife"
      /click left pack $v80 3

      /if "$item($v80,0,name)"=="bear meat" /if "$item($v80,3,name)"=="filleting knife" /goto :DoCombine
      /return

      :DoCombine
      /click left pack $v80 combine

      :LoopWait
      /if "$cursor()"=="NULL" /goto :LoopWait
      /if "$cursor(name)"=="filleting knife" /goto :Failed
      /click left auto
      :LoopFail
      /if "$cursor()"=="NULL" /goto :LoopFail
      :Failed
      /click left auto

   /goto :Makebear

/return


Sub SellBuy

   | Open merchant
   /click left auto
   /target YOURVENDORHERE
   /face
   /press u
   /delay 10

   /sendkey down shift

   | Sell our bearmeat
   :Sellbear 
      /varset v98 $char(gold) 
      /finditem "filleted bear" 
      /if $find()==FALSE /goto :DoneSelling 
      /click left merchant buy 
      :WaitSale
      /varadd v99 1 
      /if n $v99==$v92 /goto :loopdetected
      /if n $v98==$char(gold) /goto :WaitSale
   /goto :Sellbear


   :DoneSelling
   /varset v99 0
   /varset v51 0
   /finditem "bear meat"
   /if $find()==TRUE /varset v51 1
   /goto :buybearmeat


   | loopedetected get out of it clean up and go on - code added by van
   :loopdetected
   /echo loop detected cleaning up and continuing
   /varset v99 0
   /cleanup
   /click left auto
   /press esc
   /press CTRL
   /press shift
   /press alt
   /goto :startloop

   :buybearmeat


   | Buy bearmeat
   /click left merchant 11
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem
   /call BuyItem

   /sendkey up shift
   /press esc
   /press esc
/return


Sub LogStats

   | Calc profit in gold
   /varcalc v51 $char(plat)*10+$char(gold)-$v50

   | calc plat/hr
   /varcalc v52 $v51*360/$running

   | Plat
   /varcalc v53 $v51/10

   | left over gold
   /varcalc v54 $v51%10

   /echo Profit: $v53.$v54pp, avg: $v52pp/hr
   /mqlog Run time: $running sec, Profit: $v53.$v54pp, Average = $v52pp/hr

   /varset t0 3000

/return

Sub BuyItem
   /varcalc v98 $char(gold)*100+$char(silver)*10+$char(copper)
   /click left merchant buy 
   :WaitBuy
      /varcalc v97 $char(gold)*100+$char(silver)*10+$char(copper)
   /if n $v98==$v97 /goto :WaitBuy
/return

Sub CastCHA
   /target myself
   /call Event_CastFizzle
   :LoopFizzle
      /doevents
   /if n $t9>0 /goto :LoopFizzle
   /varset t1 30m
/return

Sub Event_CastFizzle
  /delay 5
  /cast 1
  /varset t9 7s
/return


that one

shes ugly but damn nice

how to make more money
simple=faster no gm check its not gonna help you they contact you, your screwed.. they already looked at the loggs and found you were doing 2+ combines a second .. faster than humanly possable.

no checks for anything.. look at the script

more bags less time opening up

cha 135+
warmly faction
Change YOURVENDORHERE to your vendors name
look at the floor..
sit down
change datarate.txt up higher untill the script messes up
then back it down one

depends on the maching... my home computer is at 8
work handels 9

eqwindows helps

currently making 500+ pp an hour after tweaking


[2002/06/07 11:04:22] Run time: 39519 sec, Profit: 5627.1pp, Average = 512pp/hr

KneightSkye
orc pawn
orc pawn
Posts: 14
Joined: Sun Jul 07, 2002 6:27 pm

hmmm

Post by KneightSkye » Mon Jul 08, 2002 11:19 am

[2002/06/08 11:04:14] Run time: 24605 sec, Profit: 792.2pp, Average = 115pp/hr

[2002/06/08 11:04:14] Total Plat: 1292


i dunno why i am getting an average 400pp less then you. done everything you said. it seems to be running at a good speed. i must be failing on everything or some shit. /shrug

van
a lesser mummy
a lesser mummy
Posts: 37
Joined: Mon Jun 24, 2002 1:04 am

Post by van » Mon Jul 08, 2002 12:24 pm

well whats your int? my mule has 122 int
and i fail maybe 1 time out of 8 combines

skill is at the point of not getting any better making these.

wierd.

User avatar
L124RD
Site Admin
Site Admin
Posts: 1343
Joined: Fri Jun 14, 2002 12:15 am
Location: Cyberspace
Contact:

Post by L124RD » Mon Jul 08, 2002 2:51 pm

Salutatios,
cha would make a diff too...

KneightSkye
orc pawn
orc pawn
Posts: 14
Joined: Sun Jul 07, 2002 6:27 pm

Post by KneightSkye » Mon Jul 08, 2002 4:44 pm

208 int
133cha
Ally Faction
Cable Modem connection
datarate 8
no noticable framerate lag when macro is running
skill is at the trivial point which may be my problem

also got most channels filtered out and server filter on
and got most of the text from the macro quest filtered out too.