Advbot.mac - Advanced Caster Bot - Heal/Debuff/Buff

Post your completed (working) macros here. Only for macros using MQ2Data syntax!

Moderator: MacroQuest Developers

ml2517
a grimling bloodguard
a grimling bloodguard
Posts: 1216
Joined: Wed Nov 12, 2003 1:12 am

Post by ml2517 » Fri May 14, 2004 2:47 pm

game_slave wrote:I have one minor issue I would like you to look in to. In the heal cycle you have the healer announce what he/she is doing ("Complete heal for <target") before the checks for OOR or OOS are made. Makes the healer look kind of stupid when the healee is obviously OOR. Could you put the announcement AFTER the checks so there is only an announcement when the spell is actually cast? I ended up turning announce off but that left me wondering if there really was a heal coming. :p I would do this myself but then I would have an incompatable version which opens up a whole other can of worms. :)

GS
The check is only done after you try to cast. How exactly would you want me to announce before the heal when I have to wait until after the heal to know if they were out of range? Anything else is just a guess at the max heal range and I wanted to avoid that.

What I *could* do is pick a number like 400 loc distance and say, If the target is farther than that away just quietly fail without announcing. This wouldn't completely solve it but it would take care of most of the false announcements.

game_slave
orc pawn
orc pawn
Posts: 18
Joined: Wed Apr 21, 2004 6:50 pm

Post by game_slave » Fri May 14, 2004 3:28 pm

MQ does have a data variable that is the range the spell has. You could use that varaible to check against the range of the target and if the target is beyond that range the spell doesn't get cast. In the mean time, a fixed range equal to the range of Cleric CH would work for me. If most other people don't care or want such then I can just code it in myself. No biggie. :)

Really good work so far though. I have only really stressed the healing bot portion of the macro but it seems to work very well. Even kept the group alive when we had so many adds we had to evac. :)


GS

ml2517
a grimling bloodguard
a grimling bloodguard
Posts: 1216
Joined: Wed Nov 12, 2003 1:12 am

Post by ml2517 » Fri May 14, 2004 4:40 pm

Updated:
advbot.mac

I went ahead and added in the distance checks for heals and group buffs (Spells only. Items and AA aren't checked.). If your target is beyond the range of the spell it will just keep ignoring them until they get in range.

game_slave
orc pawn
orc pawn
Posts: 18
Joined: Wed Apr 21, 2004 6:50 pm

Post by game_slave » Fri May 14, 2004 5:41 pm

Damn ML! You are fast! Thanks! :D

GS

User avatar
fearless
Not a Psychic
Posts: 2684
Joined: Wed Mar 10, 2004 3:52 pm

Pet assisting while follow is on

Post by fearless » Fri May 14, 2004 9:38 pm

ML - just wanted to mention that pet assisting while follow is on is working. I appreciate the changes.

ml2517
a grimling bloodguard
a grimling bloodguard
Posts: 1216
Joined: Wed Nov 12, 2003 1:12 am

Post by ml2517 » Fri May 14, 2004 10:45 pm

Updated:
spellcast.inc

You can now put one of 3 parameters in your Dismount INI setting in the [Settings] section:

dismount
nodismount
nocheck

nocheck will just disregard any loss of target midcast. It basically makes spellcast.inc behave like it had in the past.

User avatar
fearless
Not a Psychic
Posts: 2684
Joined: Wed Mar 10, 2004 3:52 pm

Summon Pet?

Post by fearless » Fri May 14, 2004 10:49 pm

What about an option to summon the pet if there is not one up?

Also, maybe I have missed this somewhere, but how are HOT heals handled? Does the script know that it is a HOT and put in a delay before it casts it again?

Thanks again.

ml2517
a grimling bloodguard
a grimling bloodguard
Posts: 1216
Joined: Wed Nov 12, 2003 1:12 am

Post by ml2517 » Fri May 14, 2004 11:55 pm

Yes it know's what is a HoT and what isn't automatically and will not cast heals on someone if they have a HoT on them.

The pet summoning thing is valid though.

game_slave
orc pawn
orc pawn
Posts: 18
Joined: Wed Apr 21, 2004 6:50 pm

Post by game_slave » Sat May 15, 2004 1:59 am

Dunno if this is a bug or not. I was doing an adventure with my SK, Cleric and Chanter. I had pet heals on. The Cleric seemed to heal the Chanter pet just fine but the SK pet got down to 50% life and the Cleric just chained healed the SK until OOM. I turned off pet heals and he healed everyone else fine from that point on. The SK was GL if that has any bearing.

Other than that issue everything worked really well. The Chanter mezzed adds and debuffed. The Cleric kept everyone alive. :D

GS

ml2517
a grimling bloodguard
a grimling bloodguard
Posts: 1216
Joined: Wed Nov 12, 2003 1:12 am

Post by ml2517 » Sat May 15, 2004 5:09 am

game_slave wrote:Dunno if this is a bug or not. I was doing an adventure with my SK, Cleric and Chanter. I had pet heals on. The Cleric seemed to heal the Chanter pet just fine but the SK pet got down to 50% life and the Cleric just chained healed the SK until OOM. I turned off pet heals and he healed everyone else fine from that point on. The SK was GL if that has any bearing.

Other than that issue everything worked really well. The Chanter mezzed adds and debuffed. The Cleric kept everyone alive. :D

GS
Next time you group with a SK that has a similar pet do me a favor and target the pet and do these and post the results:
/echo ${Target.Type}
/echo ${Target.CleanName}
/echo ${Target.PctHPs} (Try this one before and after its healed)

Also try these and tell me the results (Replace "TheSK'sGroup#" with the number he is showing up in your group list minus 1):

/echo ${Group[TheSK'sGroup#].PctHPs}
/echo ${Group[TheSK'sGroup#].Pet.PctHPs}



Also, clarify for me please. The cleric chain healed the SK? or the SK pet? and what is GL? You mean Group leader?

ml2517
a grimling bloodguard
a grimling bloodguard
Posts: 1216
Joined: Wed Nov 12, 2003 1:12 am

Post by ml2517 » Sat May 15, 2004 6:29 am

Updated:
advbot.mac
advbot.inc

I went through and did some better target verification. Now after I issue:
/target id ${Whatever.ID}

I put some checking via the new conditional delays, IE:
/target id ${Whatever.ID}
/delay 1s ${Target.ID}==${Whatever.ID}

Let me know if this helps/hurts. Overall it should help speed up the macro (especially when you have watch targets). I'm hoping this might fix the issue that was encountered above as well with the pet healing.

rasor
orc pawn
orc pawn
Posts: 15
Joined: Fri May 14, 2004 12:46 am

can this be changed?

Post by rasor » Sat May 15, 2004 11:24 am

Not sure if this can be changed.

when using the macro it seems the only way to get a pet to assist and attack when the mob is at xx amount of health is by turning on the assist option. not the pet assit option but the main assist option. problem is once you do this the caster is auto attacking in the macro.

This causes mana problems because when the caster is auto attacking they are gaining mana as if they are standing. Even if they are on a horse.

any fix to this?

game_slave
orc pawn
orc pawn
Posts: 18
Joined: Wed Apr 21, 2004 6:50 pm

Post by game_slave » Sat May 15, 2004 11:59 am

Also, clarify for me please. The cleric chain healed the SK? or the SK pet? and what is GL? You mean Group leader?
The Cleric chained healed the pet. Yes. The Cleric saw low HP's on the pet and tried to heal it but was actually healing the SK, who was full HP.

Yes, "GL" means group leader.

I will do those target variable checks the next time I get on. All the toons are mine so I can do this anytime I am playing. I remember when I looked at the Cleric's screen when he was trying to heal the pet he actually had the SK targeted and was saying "Quick heal to <SK's name>" over and over. He was seeing the pet's HP but was targeting and healing the master. Also, like I said, he healed the Chanter pet just fine. The SK was in the first slot of the group for the Cleric and the Chanter was in spot 3.

GS

ml2517
a grimling bloodguard
a grimling bloodguard
Posts: 1216
Joined: Wed Nov 12, 2003 1:12 am

Post by ml2517 » Sat May 15, 2004 12:02 pm

I see what your problem is. You need to do an:
/assist off

Or I think that was the command. Its a command in EQ to shut off autoattack when you are assisting. I believe it also updates your EQ ini so you shouldn't have to set it every time. I don't really want to do it in the macro because some people might like to keep their /assist on.
Last edited by ml2517 on Sat May 15, 2004 12:05 pm, edited 1 time in total.

ml2517
a grimling bloodguard
a grimling bloodguard
Posts: 1216
Joined: Wed Nov 12, 2003 1:12 am

Post by ml2517 » Sat May 15, 2004 12:04 pm

game_slave wrote:
Also, clarify for me please. The cleric chain healed the SK? or the SK pet? and what is GL? You mean Group leader?
The Cleric chained healed the pet. Yes. The Cleric saw low HP's on the pet and tried to heal it but was actually healing the SK, who was full HP.

Yes, "GL" means group leader.

I will do those target variable checks the next time I get on. All the toons are mine so I can do this anytime I am playing. I remember when I looked at the Cleric's screen when he was trying to heal the pet he actually had the SK targeted and was saying "Quick heal to <SK's name>" over and over. He was seeing the pet's HP but was targeting and healing the master. Also, like I said, he healed the Chanter pet just fine. The SK was in the first slot of the group for the Cleric and the Chanter was in spot 3.

GS
Ok hopefully those changes I'd made will help. One other question, did you have your SK on your watch list or anything like that? Just trying to find any other reason it would do that (Even if he was on the watch list it shouldn't have done that).