VERY simple mob kill count

JGC84 · Post by **JGC84** » Mon Feb 23, 2004 11:27 pm

i made this to take care of those stupid GoD events where you have to count the number of mobs you killed, and one can seem to keep an accurate count... yes is simple, yes its stupid, but its my first macro, if you have any suggestions for changes let me know :)

UPDATE: 2/27/04:
-I added a way you could add and subtract 1 from the count at a time to compensate for being dead, oor, or pets, but since i'm still REALLY new at this if anyone has a better way to add one and subtract one at runtime let me know, i was just using /say Plus 1 Kill, /say Minus 1 Kill when i was dead so people wouldnt notice much.. and yes i did change the /g /rsay to /echo.. ya thats it for now

Code: Select all

||count.mac
|Count the Mobs you've killed. 
|Version 1 
|Date:002/27/2004
| 

#Event expgain "You gain experience!!"
#Event exppgain "You gain party experience!!"
#Event exprgain "You gain raid experience!!"
#Event plus "Plus 1 Kill"
#Event minus "Minus 1 Kill"

#turbo

Sub Main
	/declare Count global
	/varset Count 0
	:Loop
	/doevents
	/goto :loop

/endmacro

Sub Event_plus
	/varadd Count 1
	/echo Kill Count: $int(@Count)
/return

Sub Event_minus
	/varadd Count -1
	/echo Kill Count: $int(@Count)
/return

Sub Event_expgain
	/varadd Count 1
	/echo Kill Count: $int(@Count)
/return

Sub Event_exppgain
	/varadd Count 1
	/echo Kill Count: $int(@Count)
/return

Sub Event_exprgain
	/varadd Count 1
	/echo Kill Count: $int(@Count)
/return

Goofmester1 · Post by **Goofmester1** » Tue Feb 24, 2004 2:27 am

Small reduction in lines.. though not at all needed for this..
found it useful in some macros to reduce the number of repetative subs.

Combine all three sub events you have to one by reducing the length of the #Event line. Then you only have the one event sub to be called instead of the three.

Code: Select all

|count.mac 
|Count the Mobs you've killed. 
|Version 1 
|Date:002/23/2004 
| 

#Event expgain "You gain" 

#turbo 

Sub Main 
   /declare Count global 
   /varset Count 0 
   :Loop 
   /doevents 
   /goto :loop 

/endmacro 

Sub Event_expgain 
   /varadd Count 1 
   /echo Kill Count: $int(@Count) 
/return

JGC84 · Post by **JGC84** » Tue Feb 24, 2004 8:12 am

wouldn't

#Event expgain "You gain"

trigger if someone said "You gain" in any channel? i was trying to avoid misscounts.

lestor · Post by **lestor** » Tue Feb 24, 2004 2:27 pm

Why not use "has been slain" and "You have slain" instead? Not all mobs give experience. ;)

daerck · Post by **daerck** » Tue Feb 24, 2004 3:17 pm

you may not be in range to see the slain message.

#event expgain "experience!!" should work though, unless of course someone says "omg~ this is good experience!!"

In any case, the first macro works pretty fail prove and a couple more lines of code won't make a difference to harddisk space or performance. So why change it? =)

Vic · Post by **Vic** » Fri Feb 27, 2004 10:26 am

What i would suppress are the /grouptalk and /rsay section; an echo output should be more then enough on a normal enviroment, while the constant "perfect" chatting is like a big sign on your head telling "i am macroing".

In addiction to this, since it is been written for GoD expedition5 i would like to add that it will most prolly happen for puller to be out of xp range or you to be dead when one or more mobs have been killed.
In this scenario you will not see the message hence you will not add the count at the mob ... but the macro will still be runnin yelling in the direction of the sign you have on your head :p

Good job anyway, is simple and work as intended; if you want add something to it maybe add an argument to the macro so that u can set the count during the game when u miss some mobs.

JGC84 · Post by **JGC84** » Fri Feb 27, 2004 4:21 pm

update see top thanks

Bad Karma · Post by **Bad Karma** » Mon Mar 01, 2004 8:22 am

Use an /echo #event to add/subtract. Keep it out of all public channels. Can also have it add/subtract Param0...so if it misses 4 kills, you can just /echo +4 or whatever...

JGC84 · Post by **JGC84** » Mon Mar 01, 2004 9:18 am

Use an /echo #event to add/subtract. Keep it out of all public channels

I would very much like to, but I’m not sure how to make a #event for a specific channel... I scanned through genbot to see if I could find it, but I’m not sure on the details... an example would be great and get me rolling. If someone doesn’t mind...

Gumby · Post by **Gumby** » Mon Mar 01, 2004 11:53 am

JGC84 wrote:
Use an /echo #event to add/subtract. Keep it out of all public channels
I would very much like to, but I’m not sure how to make a #event for a specific channel... I scanned through genbot to see if I could find it, but I’m not sure on the details... an example would be great and get me rolling. If someone doesn’t mind...

What BK refers to is allowing for something like this... though I took the liberty of making it a variable addition / subtraction :). Since all /echo's from a chat perperspective come through as [MQ2] blahblah, you can restrict a commend input to /echo only by:

Commands:
/echo Plus <number>
/echo Minus <number>

Code: Select all

#event Plus "[MQ2] Plus"
#event Minus "[MQ2] Minus"

...

Sub Event_Plus(EventText)
   /varadd Count $arg(3,"@EventText")
   /echo Kill Count: $int(@Count)
/return

Sub Event_Minus(EventText)
   /varsub Count $arg(3,"@EventText")
   /echo Kill Count: $int(@Count)
/return

G