Updates:
advpath.inc
genbot.mac
There were alot of bug fixes. The one main one with people having the "running back and forth" issue due to short sampling distances *should* be fixed.
You no longer issue 3 parameters to InitAPVars it is only 2.
The default is:
/call InitAPFVars 1 15
First parameter is 1 (use face fast) or 0 (don't use face fast).
Second parameter is a number from 15 or so and down. This number is now used to:
Calculate how far away from a plotted location it will assume is close enough to move to the next loc.
and
Calculate how far in between sampling distances it will plot a loc for the person/npc you are following.
The speed of the character is used when determining the first calculation. The speed of the player/npc you are following is used in the second calculation.
In short this should stop you from having to backtrack to locs in most cases. If for some reason you still see it happen now and then try using the '/echo +' command and keep bumping up the distance mod until it acts right. Once you get a good reading let me know and I can guide you on how best to set your settings up.
New additions since the last post are the + and - commands. Please read the top of advpath.inc for details.
TEST: genbot.mac w/ 3D Follow
Moderator: MacroQuest Developers
Had a chance to test newest code (up to last post) on two separate machines.
Very improved operation with find fast. Damn near flawless (see below, minor thing)
Some occasional looping behaviour without find fast.
I'm unclear on the + and - usage. It would seem that a parameter has been removed from the InitAPFvars that would require me to issue oodles of + commands in its place which isn't exactly the easiest.
For example, if I have a healer following me I don't want them 15 locs away at all times. I want them within casting range at all times. So 50 or 75 is reasonable.... why not move these commands out of genbot.mac and also into the ini? I could also see how it could be user specific...
My nitpick would be a anti-headache option. Any way to stop the jitterlook? Even running a completely flat surface in a straight line in qeynos my bot is looking all over the place.
In a nutshell though with face fast options turned on it appears the bot is performing nicely, and not insanely bot like ping ponging.
It might be wise to never have face fast at startup, but in transit. Heres what I mean by this: Just like the /face fast pingponging, it "looks odd" when a bot stands up and does an instant 180degree turn to run after someone. However in transit (while following the leader) you've polished it up so much that minor face fast tweaks shouldn't be noticeable. The only nitpick is in the "I need to start moving, let me face my leader" bit.
Zoning looked polished. I'll tear through it more when I have more patience -- stupid code was memming yaulp and casting after zoning and breaking this. Whoever put in the yaulp code into personal.inc needs to be shot....
I know I'm nitpicking, I just want to say that overall this thing is awesome. I have been busy at work so I hope to actually test out more of it other than quick 15 min sessions.
Very improved operation with find fast. Damn near flawless (see below, minor thing)
Some occasional looping behaviour without find fast.
I'm unclear on the + and - usage. It would seem that a parameter has been removed from the InitAPFvars that would require me to issue oodles of + commands in its place which isn't exactly the easiest.
For example, if I have a healer following me I don't want them 15 locs away at all times. I want them within casting range at all times. So 50 or 75 is reasonable.... why not move these commands out of genbot.mac and also into the ini? I could also see how it could be user specific...
My nitpick would be a anti-headache option. Any way to stop the jitterlook? Even running a completely flat surface in a straight line in qeynos my bot is looking all over the place.
In a nutshell though with face fast options turned on it appears the bot is performing nicely, and not insanely bot like ping ponging.
It might be wise to never have face fast at startup, but in transit. Heres what I mean by this: Just like the /face fast pingponging, it "looks odd" when a bot stands up and does an instant 180degree turn to run after someone. However in transit (while following the leader) you've polished it up so much that minor face fast tweaks shouldn't be noticeable. The only nitpick is in the "I need to start moving, let me face my leader" bit.
Zoning looked polished. I'll tear through it more when I have more patience -- stupid code was memming yaulp and casting after zoning and breaking this. Whoever put in the yaulp code into personal.inc needs to be shot....
I know I'm nitpicking, I just want to say that overall this thing is awesome. I have been busy at work so I hope to actually test out more of it other than quick 15 min sessions.
The + an - aren't meant to position your follower x distance away from the followee. Its simply a way to "dumb down" the following code if you have a slow pc and you aren't able to process the macro fast enough to hit the plotted locations of the person you are following. This simply does this:
Lets say without using the + at all you are following someone and you notice it doing the "oops I missed my location I'd better face fast to the rear and go back to that loc". If you had this happen you could bump up + a bit and it might make that go away.
I don't actually have anything built in to guarantee you are x location away from your followee. The closest thing to that is the way I'm doing the "shortcut" code to stop you from running the full path if you are within 30 distance of your followee. I'll see if there is a decent way to implement what you are asking for though.
Now, the non-face fast mode thing. I can imagine this working like crap when you take sharp turns etc. There really isn't alot I can do about this that I can think of but I'll try to think of something.
The face fast at startup I should be able to take care of. Simply have it do a non-face fast before I start the follower in motion should do it.
Is this yaulp thing happening with the personal.inc I have posted? I honestly never tried turning that on. I'd posted someones fix from the genbot thread for something to do with yaulp though.
Lets say without using the + at all you are following someone and you notice it doing the "oops I missed my location I'd better face fast to the rear and go back to that loc". If you had this happen you could bump up + a bit and it might make that go away.
I don't actually have anything built in to guarantee you are x location away from your followee. The closest thing to that is the way I'm doing the "shortcut" code to stop you from running the full path if you are within 30 distance of your followee. I'll see if there is a decent way to implement what you are asking for though.
Now, the non-face fast mode thing. I can imagine this working like crap when you take sharp turns etc. There really isn't alot I can do about this that I can think of but I'll try to think of something.
The face fast at startup I should be able to take care of. Simply have it do a non-face fast before I start the follower in motion should do it.
Is this yaulp thing happening with the personal.inc I have posted? I honestly never tried turning that on. I'd posted someones fix from the genbot thread for something to do with yaulp though.
The yaulp thing is on by default, and it's a copy of the "other" genbot, so I don't blame your code at all. It's just a nuisance, something that really shouldn't be on by default. The logic is ... if you're a cleric, and if your mana is under 100, mem yaulp and use it. Well, that happens when you zone, even if you have 100 mana really, because of the hiccup on mana/health when zoning. Silly.
Appreciate the explanation of the + and - though, makes sense.
Appreciate the explanation of the + and - though, makes sense.
Not related to your mods, but something I thought I'd point out anyway...
In Personal.inc, Line 123 reads:
It should be:
It's in every version of Genbot I've seen so far. lol
In Personal.inc, Line 123 reads:
Code: Select all
/declare BuffSpell6 global
/varset BuffSpell6 "$ini(@IniFile,"Personal",BuffSpell6)"
/if "@BuffSpell[color=red][b]8[/b][/color]"=="NOTFOUND" /ini "@IniFile" Personal BuffSpell6 "Name of Buff spell 6"Code: Select all
/declare BuffSpell6 global
/varset BuffSpell6 "$ini(@IniFile,"Personal",BuffSpell6)"
/if "@BuffSpell[color=red][b]6[/b][/color]"=="NOTFOUND" /ini "@IniFile" Personal BuffSpell6 "Name of Buff spell 6"[b]- Bad Karma
________________________________________[/b]
In our own quest for excellence, we should strive to take the time to help those who help themselves.
All others should [b]RTFM[/b]!!!!!!!!!
________________________________________[/b]
In our own quest for excellence, we should strive to take the time to help those who help themselves.
All others should [b]RTFM[/b]!!!!!!!!!
Updated:
advpath.inc
genbot.mac
Changed it so that when you first start following you do a normal /face instead of a face fast. Looks more natural.
Added the 'distance' command to change how far you stay away from the followee. Default is 20. I'm going to try to improve this. It has to take a straight path to the first loc when the followee starts moving, if you were in a tight dungeon or something you might not be able to run straight line to the first loc. I'll look at a way to handle this.
Changed the /look routines to only change in degrees of 10. This should stop alot of the "bobbling" while pathing.
advpath.inc
genbot.mac
Changed it so that when you first start following you do a normal /face instead of a face fast. Looks more natural.
Added the 'distance' command to change how far you stay away from the followee. Default is 20. I'm going to try to improve this. It has to take a straight path to the first loc when the followee starts moving, if you were in a tight dungeon or something you might not be able to run straight line to the first loc. I'll look at a way to handle this.
Changed the /look routines to only change in degrees of 10. This should stop alot of the "bobbling" while pathing.
Update:
advpath.inc
Lots of bug fixes.
When starting to move you will run to the loc the followee was standing before resuming the path. This helps you duplicate a path of the followee better.
Changed the way the non-face fast works. You really shouldn't need to use this mode at all anyways because it looks alot less obvious than it ever has. But if you do, you'll notice that if your next location is at more of an angle than you can turn using /face in the time allotted you will stop, turn and then resume.
The "am I at the plotted loc yet?" code has been greatly improved. It not only checks distances now but keeps track of your heading while facing it at the begenning of the loc and if your angle changes drastically it assumes you've reached the location and goes on to the next. After I added this I noticed alot better accuracy.
Edit: Updated advpath.inc again but it should have no bearing on genbot routines.
advpath.inc
Lots of bug fixes.
When starting to move you will run to the loc the followee was standing before resuming the path. This helps you duplicate a path of the followee better.
Changed the way the non-face fast works. You really shouldn't need to use this mode at all anyways because it looks alot less obvious than it ever has. But if you do, you'll notice that if your next location is at more of an angle than you can turn using /face in the time allotted you will stop, turn and then resume.
The "am I at the plotted loc yet?" code has been greatly improved. It not only checks distances now but keeps track of your heading while facing it at the begenning of the loc and if your angle changes drastically it assumes you've reached the location and goes on to the next. After I added this I noticed alot better accuracy.
Edit: Updated advpath.inc again but it should have no bearing on genbot routines.
genbot v9.1 now includes support for advpath.inc.
You can download genbot here.
http://macroquest2.com/phpBB2/viewtopic.php?t=4796
ml2517's advpath.inc can be found here.
http://macroquest2.com/phpBB2/viewtopic.php?t=4974
Please post questions/comments in the appropriate threads; Thanks!
You can download genbot here.
http://macroquest2.com/phpBB2/viewtopic.php?t=4796
ml2517's advpath.inc can be found here.
http://macroquest2.com/phpBB2/viewtopic.php?t=4974
Please post questions/comments in the appropriate threads; Thanks!
There is something strange about the movebehind in this threads version of genbot.
Many times the character will not move behind the mob. I have to constantly tell the character to stop, then assist again.
Also, when I tell the character to stop, then I zone and then zone the character, Follow does not work. I have to restart genbot to get it to Follow again.
Many times the character will not move behind the mob. I have to constantly tell the character to stop, then assist again.
Also, when I tell the character to stop, then I zone and then zone the character, Follow does not work. I have to restart genbot to get it to Follow again.
Yeah the getbehind code wasn't tested all that much. Stop actually tells the bot to stop following all together so that is to be expected. I'd give 9.2 a shot and see if it works well for you. The whole intention of this thread was simply to get the new follow code integrated into Genbot, which Lasher ended up doing as well.
The getbehind was working just fine before the latest round of changes, so something changed in it somewhere.
What I meant as far as stop goes:
1. I am at a zone line so I issue a stop command
2. I zone.
3. I switch to other character and zone
4. I switch back to master and issue follow command
5. The character does not follow, I have to restart genbot to get it to follow
What I meant as far as stop goes:
1. I am at a zone line so I issue a stop command
2. I zone.
3. I switch to other character and zone
4. I switch back to master and issue follow command
5. The character does not follow, I have to restart genbot to get it to follow
ah ok. Hmm. I'm not sure why the getbehind would have stopped working. I haven't touched a thing with that for quite some time. Were you using the test version of the new getbehind code and working fine? then all of a sudden it stopped working? Or were you working fine when I'd had the old getbehind code in there?
I'll try to figure out what is wrong with the follow issue.
I'll try to figure out what is wrong with the follow issue.
Wassup, no clue as to why your follow isn't working. I did exactly the same things you stated you'd done and it works fine. Did you make sure you were on the same file revisions that are posted?
** Gave this about a 10 minute workout of having him assist and get behind, following me. Zoning when I issue a stop right before, etc. Couldn't get it to react like you are saying. /shrug
** Gave this about a 10 minute workout of having him assist and get behind, following me. Zoning when I issue a stop right before, etc. Couldn't get it to react like you are saying. /shrug