/selectitem bugged (fixed in 2003 12 30 release)

A forum for reporting bugs NOT related to custom plugins.

Moderator: MacroQuest Developers

Shali
a ghoul
a ghoul
Posts: 87
Joined: Sun Dec 07, 2003 12:39 pm

/selectitem bugged (fixed in 2003 12 30 release)

Post by Shali » Thu Dec 25, 2003 3:56 pm

with the new version of MQ2 (dec 25th) /selectitem appears to be broken

something like this:

Code: Select all

    /selectitem "water flask" merchant
will send the selector to the right spot on the merchant, but for some reason, the buy/sell button changes to sell, instead of buy, not quite sure why it is functioning this way

Vaft
a lesser mummy
a lesser mummy
Posts: 69
Joined: Fri Mar 07, 2003 6:39 am

Post by Vaft » Fri Dec 26, 2003 1:50 am

The SlotID in the CSIDLWND struct is incorrect, that's all I know.

EqMule
Developer
Developer
Posts: 2697
Joined: Fri Jan 03, 2003 9:57 pm
Contact:

Post by EqMule » Fri Dec 26, 2003 1:05 pm

hmm Id hope for Lax to look at this since he is the master of that struct... or maybe Amadeus wants to give it a shot, Im short on time right now...
My status o/
If you like MQ2 and would like to contribute, please do. My goal is 25 donations per month.
So far I've received Image donations for this month's patches.

Bitcoin: 1Aq8ackjQ4f7AUvbUL7BE6oPfT8PmNP4Zq
Krono: PM me.
I can always use characters for testing, PM me if you can donate one.

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Fri Dec 26, 2003 1:35 pm

Sorry, Lax is really the only one with the tools to verify this, if you want the truth. I checked into it somewhat, but to my eyes the struct looks pretty much the same as it did before.

How are you confirming that SlotID is wrong?

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Fri Dec 26, 2003 2:03 pm

Well, I figured out how to fix the /selectitem ;however, in doing it, I break the UI Labels ..lol. My best guess is that there is actually two types of 'SlotIDs' ..and, technically, I could duct tape things together to make it all work...but, it would be sheer guesswork and duct tape, and we don't want that.

This fixes /selectitem ..but breaks UI labels:

Code: Select all

			union {
/*0x110*/			_CXSTR  *SidlScreen;
/*0x110*/			DWORD SlotID;
			};
/*0x114*/	LPVOID  SidlPiece;
This ...does the opposite (breaks /select item and UI labels are fixes)

Code: Select all

/*0x110*/   struct  _CXSTR  *SidlScreen; 
/*0x114*/   union { 
                    LPVOID SidlPiece;   // CScreenPieceTemplate (important)  
                    DWORD   SlotID; 
            }; 


If I were to guess ..I'd guess both were unions and involve two different types of SlotIDs....but, like I said, it's sheer guessing....



Soooo...it's back to waiting on Lax.

Lax
We're not worthy!
We're not worthy!
Posts: 3524
Joined: Thu Oct 17, 2002 1:01 pm
Location: ISBoxer
Contact:

Post by Lax » Fri Dec 26, 2003 4:54 pm

Indeed, Labels dont use the same SlotID anymore. Fixed in dev cvs.
Lax Lacks
Master of MQ2 Disaster
Purveyor of premium, EULA-safe MMORPG Multiboxing Software
* Multiboxing with ISBoxer: Quick Start Video
* EQPlayNice, WinEQ 2.0

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Post by dont_know_at_all » Fri Dec 26, 2003 7:55 pm

EQMERCHWINDOW fixed in dev cvs as well.

DekeFentle
a lesser mummy
a lesser mummy
Posts: 48
Joined: Wed Oct 22, 2003 1:41 pm

Post by DekeFentle » Fri Dec 26, 2003 8:44 pm

Would this also cause...

/Click Left Item

to malfunction in that nothing is selected.
Revelation 6:8

J-Squared
orc pawn
orc pawn
Posts: 22
Joined: Wed Nov 19, 2003 11:02 am

Post by J-Squared » Sun Dec 28, 2003 4:53 pm

Would this also cause...

/Click Left Item

to malfunction in that nothing is selected.
I am also searching for this answer.. since I have dicovered that starting from the Dec 25th build /Click Left Item also does not work for me.

This is the closest thing I've found to an answer so far. If someone could verify that would solve the puzzle I've been working on today.


Lax
We're not worthy!
We're not worthy!
Posts: 3524
Joined: Thu Oct 17, 2002 1:01 pm
Location: ISBoxer
Contact:

Post by Lax » Sun Dec 28, 2003 5:11 pm

you could always just wait for us to update the zip, and go back to actually playing the game
Lax Lacks
Master of MQ2 Disaster
Purveyor of premium, EULA-safe MMORPG Multiboxing Software
* Multiboxing with ISBoxer: Quick Start Video
* EQPlayNice, WinEQ 2.0

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Post by dont_know_at_all » Sun Dec 28, 2003 6:20 pm

I'm pretty sure this is broken because they renumbered the messages.

EqMule
Developer
Developer
Posts: 2697
Joined: Fri Jan 03, 2003 9:57 pm
Contact:

Post by EqMule » Sun Dec 28, 2003 8:11 pm

yes thats exactly what it is ... I can fix it in like 10 secs *shrug*, but im waiting until lax/Amadeus updates are done and a new and working zip is posted.
My status o/
If you like MQ2 and would like to contribute, please do. My goal is 25 donations per month.
So far I've received Image donations for this month's patches.

Bitcoin: 1Aq8ackjQ4f7AUvbUL7BE6oPfT8PmNP4Zq
Krono: PM me.
I can always use characters for testing, PM me if you can donate one.