Monk skillup macro, delay issues

[Stogar]

I made this for my twink monk that can't Feign Death to save his life, literally. I originally thought I had to sit in between and found when testing the macro that I'd get skillups regardless if I sat or not. I want to add a /doability "Mend" but my delays seem to get screwed.

Heres what I have that works:
(This was inspired by the forageINI.mac)

Code: Select all

| Monk SkillUP Macro
| v 0.01

 
#turbo 

Sub Main 
  /zapvars
  
:Continue 
  /call Skillup
  
  /goto :Continue
   
/return 


Sub Skillup 
  /doability "Feign Death"
  

  /delay 12 
/return 

Here is the test sub to add "Mend":

Code: Select all

Sub Skillup 
  /doability "Feign Death"
  /delay 1
  /doability "Mend"
  /delay 90
  /delay 12 
/return 

but I don't think this is a clean way of making it do like FD FD FD FD - Mend - FD FD FD......etc. In fact it's no nearly that at all.

I am gonna add the regular GM detect code, skill up reporting, stop at max, but wanted to make the core smooth first.

Could use any ideas on how to make this a bit more generic, I was thinking of setting up an array of skills with refresh times to pass into the sub. I'm still a bit new so trying to build from the basics.

Thanks[/code]

[Mckorr]

Code: Select all

/if n $char(ability,"Feign Death")>0 /doability "Feign Death"
/if n $char(ability,"Mend")>0 /doability "Mend"

Loop those, and it will only hit the Feign Death or Mend buttons when they are available for use. You won't need the delays after /doability that way.[/code]

[Soulzek]

Short and simple:

Code: Select all

Sub Main
:loop
/if n $char(ability,"Feign Death")>0 /doability "Feign Death"
/delay 1
/if n $char(ability,"Mend")>0 /doability "Mend"
/delay 1
/if $GM==TRUE /call GM
/goto :loop
/return

Sub GM
/echo GM IN ZONE!!!
/beep
/beep
/beep
/q
/end

[Stogar]

Wow mine is ugly, thanks for the help.