Sub FindItem

Curious · Post by **Curious** » Mon Sep 08, 2003 3:10 pm

Replace /finditem "spiderling silk" with /call FindItem "spiderling silk" or /finditem similar "silk" with /call FindItem similar "silk" (for example).

Code: Select all

Sub FindItem
   /for l0 0 to 7
| Edited here to compensate for NULL error (added 11 spaces)
      /if "$pack($l0,name)           "=="NULL" /goto :FindItemNextPack
      /for l1 0 to $pack($l0,slots)
         /if "$p0"=="similar" /if "$item($l0,$l1,name)"~~"$p1" /goto :FindItemFoundIt
         /if "$item($l0,$l1,name)"=="$p0" /goto :FindItemFoundIt
         /goto :FindItemNotFoundIt
         :FindItemFoundIt
            /press alt
            /press shift
            /if "$pack($l0,open)"=="true" /varset l3 1
            /if n $l3==0 {
               /click right inv $l0
               :FindItemLoop1
                  /doevents
                  /if "$pack($l0,open)"=="false" /goto :FindItemLoop1
                  /delay $cLag
            }
            /sendkey down ctrl
            /click left pack $l0 $l1
            :FindItemLoop2
               /doevents
               /if "$cursor(name)"=="null" /goto :FindItemLoop2
               /delay $cLag
            /sendkey up ctrl
            /if n $l3==1 /goto :FindItemDone
| Edited here to compensate for DONE button location
| /click left pack $l0 done
            /mouseto pack $l0 done
            /mouseto -0 -30
            /click left
| End Edit
            :FindItemLoop3
               /doevents
               /if "$pack($l0,open)"=="true" /goto :FindItemLoop3
               /delay $cLag
            /goto :FindItemDone
      :FindItemNotFoundIt
      /next l1
      :FindItemNextPack
   /next l0
:FindItemDone
/return

Can't wait for /finditem to be fully functional again :)

Valerian · Post by **Valerian** » Mon Sep 08, 2003 9:12 pm

uh, what's wrong with /finditem?

wassup · Post by **wassup** » Mon Sep 08, 2003 9:15 pm

Heh... I second Valerian...

use the /finditem command already built into MQ.

Good learning effort though!

Valerian · Post by **Valerian** » Mon Sep 08, 2003 9:24 pm

this is to "fix" the bag-opening thing... he wants to be able to finditem with a bag closed.

wassup · Post by **wassup** » Mon Sep 08, 2003 9:47 pm

Oh...

I always do tradeskill macros with bags open so have not encountered whatever it is that is causing a problem.

MacroFiend · Post by **MacroFiend** » Mon Sep 08, 2003 9:58 pm

aside from the fix I posted on the general dev board is that there is no delay between it opening the bag and trying to click on the item.

Somewhere around when SOE added the tradeskill delays, the click commands stopped getting queued (or started getting flushed or bag openings got lagged more).

Before the patch, instead of /finditem opening the bag and then grabbing the item, it would open the bag and move the mouse to where the item lives but would lose the click to pick it up.

After the patch, the conditionals that checked if the bag was closed was commented out due to the structure changes and it would no longer open the bags at all.

Curious · Post by **Curious** » Tue Sep 09, 2003 2:29 am

Sorry, guess I should have specified the problem I was trying to fix :)

Is there any plans of re-enabling /finditem's ability to select items from closed containers? Or to add a variable to determine what container an item is found in?

EqMule · Post by **EqMule** » Thu Sep 18, 2003 10:47 pm

/finditem now opens the container if an item is inside it, but it will not pick it up... you can however /echo $GetLastError which will return PACKNOTOPEN if the item was found but pack was closed, you then just call /finditem again and this time it will pick it up, since the pack was opened in the previous attempt... Lets see if I can get Valerian to put something in the pulse which will allow us to open and pick up in the same attept... but for now, you can use this...

in dev cvs right now... should be available in 24h on backup, or earlier if DKAA updates the zipfile.

Curious · Post by **Curious** » Thu Sep 18, 2003 10:52 pm

Sweet! Thanks EqMule! My routine works, but quite a bit slower than /finditem ... can't wait to get the updates :)

Sub FindItem

Sub FindItem

The problem ...

fixed the 19 sep 2003