/finditem help??

Need help running MacroQuest 1? Too bad! Use MQ2.

Moderator: MacroQuest Developers

Spectre
orc pawn
orc pawn
Posts: 21
Joined: Tue Sep 02, 2003 10:31 am

/finditem help??

Post by Spectre » Tue Sep 02, 2003 10:54 am

I've compiled from the latest zip file, and my tradeskill macros are running into a bit of trouble.

I'm picking on celestial essences to be simple, but the same error pops up with other items. The relevant code snippets run something like this:

Code: Select all

/finditem "Celestial Solvent"
/delay 5
/if $cursor() != True /call abort_the_macro
When I run the macro, the cursor moves to the item perfectly, but doesn't pick one up. $cursor then returns null, like it's supposed to, since there's nothing on the cursor. I've tried various values of /delay, from 1 to 100, with no change in results.

Any ideas?

User avatar
SimpleMynd_01
a lesser mummy
a lesser mummy
Posts: 71
Joined: Thu May 08, 2003 3:16 pm

Answer

Post by SimpleMynd_01 » Tue Sep 02, 2003 11:28 am

From http://macroquest2.com/phpBB2/viewtopic.php?t=2940
Before anyone says it's a bug, I will announce that /click DOES work, but NOT if EQ has the focus, or the mouse pointer (release your mouse pointer and it works fine).
Let me clarify the /click problems:

If you are using EQ in either full screen or native windowed mode, the current /click will NOT work. Why? For the current /click to work, EQ must NOT have the mouse in exclusive mode, meaning you have to window EQ and release the mouse using shift+alt+r (or whatever you have it set to.) Now, macros will only run if EQ is in the foreground... and when EQ is in the foreground it has exclusive control of the mouse. Release the mouse, macros stop running, and you can't type commands; /click can't be called, so it won't work.

How are they getting around this to use /click? By using EQW, which allows EQ to have the focus, but the mouse to still be released. That means, if you want to /click you have to use EQW.

I don't consider this a valid solution, just an interim work around. We still need to figure out why /click is not working as previously written and fix it.

This also explains why /click did not work prior to the DirectInput solution. EQ is written in such a way that it grabs, via DirectX, exclusive control of the mouse. Any attempt to write directly to the memory address and cause a click results in a conflict with DirectX, which causes EQ to crash. The detoured solution allowed us to piggyback our own click command onto the DirectInput stream, telling EQ that our mouse had been clicked, even if the button wasn't pressed.

I have yet to determine what change was made to the EQ code that no longer allows us to piggyback our commands using Detours. Until we can do that and fix it, or come up with a way to /click in EQ without using EQWindows, /click should still be considered officially "broken".
_________________
A Horse! A Horse! My Kingdom for a Horse!

Achy Wrists
a lesser mummy
a lesser mummy
Posts: 36
Joined: Wed Aug 27, 2003 4:17 pm

Post by Achy Wrists » Tue Sep 02, 2003 11:30 am

Complete newb chiming in. I've been looking at MQ for less than a week now, so my clue about MQ is very small and wimpy, but... From reading these forums and trying to get stuff to run by myself and getting the same results as you, I think the problem might be with the /click? You need to ctrl+click on an item to actually pick it up and right now I think that's broken. When I tried to run a tradeskill macro what I saw was that if the items are stacked, it won't pick them up. But if I have only 1 of an item in a spot in a container then it successfully picks it up, puts it in the tradeskill contianer and combines. I'll have to recheck that tonight just to make sure I'm remembering correctly.

wassup
Official Guardian and Writer of TFM
Official Guardian and Writer of TFM
Posts: 1487
Joined: Sat Oct 26, 2002 5:15 pm

Post by wassup » Tue Sep 02, 2003 11:45 am

I just tried what Achy Wrists described.

If you only have one of the item in a container or in a general inventory slot, /finditem does not pick it up.

Spectre
orc pawn
orc pawn
Posts: 21
Joined: Tue Sep 02, 2003 10:31 am

Post by Spectre » Tue Sep 02, 2003 12:00 pm

Thanks for the response, I didn't think to search for /click.

Anyone with EQW want to verify that /finditem works there?

User avatar
SimpleMynd_01
a lesser mummy
a lesser mummy
Posts: 71
Joined: Thu May 08, 2003 3:16 pm

Don't know but...

Post by SimpleMynd_01 » Tue Sep 02, 2003 1:33 pm

I don't know which I'm using (might be /finditem or /selectitem or something close), but I know my tradeskill script works with EQW (and not in focus). I'll post later when I get home to verify exactly which I'm using.

-SimpleMynd

User avatar
Curious
a ghoul
a ghoul
Posts: 88
Joined: Wed Aug 27, 2003 5:19 am

Post by Curious » Wed Sep 03, 2003 3:45 am

Spectre wrote:Anyone with EQW want to verify that /finditem works there?

Code: Select all

/finditem similar "Fishing Pole"
(from Fish.mac that comes with the MQ release)

Works perfectly when running EQW ... even while EQW was running in the background behind IE.

(as long as EQW does NOT have the mouse)

Spectre
orc pawn
orc pawn
Posts: 21
Joined: Tue Sep 02, 2003 10:31 am

Post by Spectre » Wed Sep 03, 2003 7:50 pm

Thanks, works perfectly under EQW.