Group.Member[x] returns self or the wrong player

[nokternal]

Hey all, been working on fixing some of the shammy macs, and all seems to be coming along, however Group.Member seems to be not working correctly. for Example if I do a /targ pc ${Group.Member[0]} I am targeted as expected. But if I do a /targ pc ${Group.Member[2]} it again targets me versus the correct player. I"m trying to put a group together as we speak so i can verify it. But seems that ${Group.Member[x]} is not selecting the correct players. I am using the MQ2-20050310.zip.


An example of the code i'm trying to get working correctly.

Code: Select all

Sub Check_grpHPs 
   /declare i int local 1 
    
   /for i 1 to ${Group} 

   /if (${Group.Member[${i}].Class.Name.Equal[Cleric]} || ${Group.Member[${i}].Class.Name.Equal[Druid]} || ${Group.Member[${i}].Class.Name.Equal[Wizard]} || ${Group.Member[${i}].Class.Name.Equal[Magician]} || ${Group.Member[${i}].Class.Name.Equal[Necromancer]} || ${Group.Member[${i}].Class.Name.Equal[Enchanter]}) /if (${Group.Member[${i}].PctHPs}<=${CasterHeals}) { 
      /target pc ${Group.Member[${i}].Name} 
      /if (${Me.CurrentMana}<${Spell[${SpellHeal}].Mana}) { 
         /echo *** Shid ! I don't have mana to heal ${Group.Member[${i}]} 
      } else /if (${Target.Distance}<=200) { 
         /if (${Verbose}) /gsay *** ${SpellHeal} on %T 
         /call cast ${SpellHeal} gem6 4s 
      } 
   } 
    
   /if (${Group.Member[${i}].Class.Name.Equal[Warrior]} || ${Group.Member[${i}].Class.Name.Equal[Monk]} || ${Group.Member[${i}].Class.Name.Equal[Rouge]} || ${Group.Member[${i}].Class.Name.Equal[Bard]} || ${Group.Member[${i}].Class.Name.Equal[Ranger]} || ${Group.Member[${i}].Class.Name.Equal[Beastlord]} || ${Group.Member[${i}].Class.Name.Equal[Shadow Knight]} || ${Group.Member[${i}].Class.Name.Equal[Berserker]} || ${Group.Member[${i}].Class.Name.Equal[Paladin]}) /if (${Group.Member[${i}].PctHPs}<=${MelleeHeals} && ${Group.Member[${i}].Name.NotEqual[${M_Assist}]}) { 
      /target pc ${Group.Member[${i}]} 
      /if (${Me.CurrentMana}<${Spell[${SpellHeal}].Mana}) { 
         /echo *** Shid ! I don't have mana to heal ${Group.Member[${i}]} 
      } else /if (${Target.Distance}<=200) { 
         /if (${Verbose}) /gsay *** ${SpellHeal} on %T 
         /call cast ${SpellHeal} gem6 4s 
      } 
   } 

   /if (${Group.Member[${i}].Name.Equal[${M_Assist}]} && ${Group.Member[${i}].PctHPs}<=${TankHeal}) { 
      /target pc ${Group.Member[${i}]} 
      /if (${Me.CurrentMana}<${Spell[${SpellHeal}].Mana}) { 
         /echo *** Shid ! I don't have mana to heal ${Group.Member[${i}]} 
      } else /if (${Target.Distance}<=200) { 
         /if (${Verbose}) /gsay *** ${SpellHeal} on %T 
         /call cast ${SpellHeal} gem6 4s 
      } 
   } 

   /next i 
/return 

[Arune]

I had same problem, but I just redownloaded, recompiled, deleted everything in the folder I run MQ from, copied the new files into the folder and went into game and it worked.

I just tested this now, and it works perfect.

[htw]

Bah. :-P

htw

[Quagmire]

I'm still seeing this problem w/ MQ2-20050319. Only happens after you zone once.

[Quagmire]

just did some of my own debuggin on this issue:

the _CHARINFO->GroupMember[] actually has 6 members, not 5 like currently declared in the structs. When you join a group you're not added to the array, but when you zone you are added and it's re-ordered to the order in which you joined the group. So group leader/creator in 0, and there can be gaps if someone has left the group.

[htw]

Hmm, right you are. It is only for the zoning char also (makes sense), but just wanted to point that out. Is easy enough to add a 6th member to the group array, make a few changes to DataTypes, and then let's do some more testing to see where we are after that.


htw

[Lax]

I'll have a fix up shortly, but feel free

[xyilla]

Econ

[xyilla]

138.1

[xyilla]

толь

[xyilla]

CHAP

[xyilla]

Fion

[xyilla]

alla

[xyilla]

Mult

[xyilla]

Jose