June 11th Offsets - Untested ATM

A forum for feature requests/discussions and user submitted patches that improve MQ2

Moderator: MacroQuest Developers

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Wed Jun 11, 2003 6:08 pm

Jaerin,

I'm really terrible at debugging a running application, but if you'd like an executable to test to see what's wrong..I can send you one.

Pragma
a ghoul
a ghoul
Posts: 91
Joined: Sat May 03, 2003 1:45 am

Post by Pragma » Wed Jun 11, 2003 6:13 pm

iI have expanded the detour variable to hold more offsets, and I am crashing exactly the same way, with the send bug report error box. I am using VC6.0 on winxp.

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Wed Jun 11, 2003 6:21 pm

What does the send bug error details message say? (You should be able to see it without sending to MS)

Pragma
a ghoul
a ghoul
Posts: 91
Joined: Sat May 03, 2003 1:45 am

Post by Pragma » Wed Jun 11, 2003 6:23 pm

ill check brb :)

Jaerin
Developer
Developer
Posts: 133
Joined: Mon Mar 10, 2003 7:37 pm
Contact:

Post by Jaerin » Wed Jun 11, 2003 6:34 pm

Wild Goose chase...

This is something totally bazaar with the setup. Because I just downloaded a totally virgin copy of the source straight from CVS and compiled it. Completely removed all traces of my working MQ. Used all of the files from the compile and it works just fine.

Jaerin

Pragma
a ghoul
a ghoul
Posts: 91
Joined: Sat May 03, 2003 1:45 am

Post by Pragma » Wed Jun 11, 2003 6:34 pm

Major breakthrough. The error message I got this time was with a Debug button and a Cancel button. It said eqgame.exe has commited an error and needs to close. I clicked bebug: then got a MessageBox from VS6.0 saying: Unhandled Exception in eqgame.exe (EQLIB.DLL) : 0xC0000005: Access Violation.

Sure enough 0xC0000005 is the line memcpy(....) for building my detour list. This would explain why things are going wrong but the game isnt halting, the offsets are not being detoured.

This question of the day is: why the hell is my memcpy routine crashing all of the sudden?????

Pragma
a ghoul
a ghoul
Posts: 91
Joined: Sat May 03, 2003 1:45 am

Post by Pragma » Wed Jun 11, 2003 7:01 pm

Another issue. I fixed the memset on detours problem, that was my own fault, the new crash resolves to this line in eqlib_interp.cpp:

for (i=0;pCmdListOrig.fAddress != 0;i++) {

Could an offset be wrong there? Mabey the EQADDR_CMDLIST offset?

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Wed Jun 11, 2003 7:10 pm

lol...yea, I'd say that there is something inherently wrong with
CommandList=0053da8
we seem to be missing a digit ;)

...let's try:

Code: Select all

CommandList=005b3da8
Last edited by Amadeus on Wed Jun 11, 2003 7:16 pm, edited 2 times in total.

Pragma
a ghoul
a ghoul
Posts: 91
Joined: Sat May 03, 2003 1:45 am

Post by Pragma » Wed Jun 11, 2003 7:13 pm

ummmmm someone major fubared. Look at this: CommandList=0053da8

Thats only 7 hexes long....

I just looked at the dissaembled source and got this: 005 ***B*** 3DA8 Note the B!!!! Testing now

Pragma
a ghoul
a ghoul
Posts: 91
Joined: Sat May 03, 2003 1:45 am

Post by Pragma » Wed Jun 11, 2003 7:14 pm

You beat me to it Amedeus :) Was finding the offset as you posted hehe. Now im praying...

Pragma
a ghoul
a ghoul
Posts: 91
Joined: Sat May 03, 2003 1:45 am

Post by Pragma » Wed Jun 11, 2003 7:22 pm

all i can say it BOOOO-YA-KA-SHAAAA

It works.


Edit the page one offset list, the commandlist offset is bad!

Make it this:

CommandList=005b3da8

Working well for me now.

The question remains though.. .... how the hell did Jaerin get it to work when an offset was wrong???

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Wed Jun 11, 2003 7:22 pm

That fixed it for me! I am also not getting any errors on 'who npc corpse' as was reported before.

I would suggest to those that are ok with altering their source, to integrate the changes posted at http://macroquest2.com/phpBB2/viewtopic.php?t=2470 (especially charinfo) ....I'll get them in the CVS in a day or so when we've finished debugging.

Shocks
a ghoul
a ghoul
Posts: 101
Joined: Tue Feb 18, 2003 3:26 pm
Contact:

Works for me!

Post by Shocks » Wed Jun 11, 2003 7:25 pm

The offset change works great. Thanks again guys for all the great work!

Glasscoin
a lesser mummy
a lesser mummy
Posts: 55
Joined: Mon Jan 13, 2003 8:57 am

Post by Glasscoin » Thu Jun 12, 2003 12:50 am

Hmmmm, the number of items in a stack isn't being returned with $cursor(stack) anymore... is that because of the missing HSliderItem offset, or because of the fact that some iteminfo structs have changed and I didn't download a fresh copy of MQ off of the CVS?

Thanks in advance!

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Thu Jun 12, 2003 2:25 am

Did you check out the link I provided earlier in this thread? I'm not assuring that it will fix it...but it won't hurt.