AbilityReady & CombatAbilityReady in MQ2-20051101

[Albert]

First of I want to tell that I'm running EQ Titanium against an EQEmu server.

I downloaded the 20051101 zip and it compiled and works fine with my unpatched eqgame.exe

But I'm having a couple of problems.

Me.CombatAbilityReady[1] always returns TRUE if the character has any comabt abilities. NULL for characters without combat abilities. It never returns FALSE. It returns TRUE even when the combat ability is not ready to be used yet. It doesn't matter if I use the name or the number.
Me.CombatAbility[Evasive Discipline] returns 1, and Me.CombatAbility[1] returns Evasive Discipline. So that part is working.
Me.CombatAbilityTimer[1] always returns NULL

Me.Ability[Kick] returns NULL for my warrior character. Even with Kick assigned to slot 1 in the Ability window. But Me.Ability[1] returns Kick!!!
Me.AbilityReady[1] works as it should, but Me.AbilityReady[Kick] always returns NULL.
The strange thing here is that for a Shadowknigh character Me.Ability[Kick] and Me.AbilityReady[Kick] works!!!

I saw that CombatAbility, CombatAbilityReady and CombatAbilityTimer was changed in the 20051130 release to use the EQ functions. But by then the offsets was already changed to the 2005-11-16 patch. So to be able to update the 20051101 code with those changes I need to get hold of the offsets for EQ_PC__GetAltAbilityIndex, EQ_PC__GetCombatAbility and EQ_PC__GetCombatAbilityTimer for the 2005-11-01 eqgame.exe. But I'm not sure how to do that.

Keep in mind that there are a bounch of us out there that are running against EQEmu servers, and then it is the 20051101 code that we need use. (Or at least start from)

[Albert]

After some debugging I found why the Me.AbilityReady[Kick] wasn't working.
After it found the skill Kick it checked if the skill level was above 252 and did an automatic "return false;" if it was.

MQ2DataTypes.cpp

Code: Select all

				// name
				for (DWORD nSkill=0;szSkills[nSkill];nSkill++)
					if (!stricmp(GETFIRST(),szSkills[nSkill]))
					{
						// found name
						if (GetCharInfo2()->Skill[nSkill]>252)
-->>							return false;
						for (DWORD nAbility=0;nAbility<10;nAbility++)
						if (EQADDR_DOABILITYLIST[nAbility] == nSkill) 
						{
							if (nAbility<4)
								nAbility+=7;
							else
								nAbility-=3;
							if (SkillDict[nSkill]->AltTimer==2)
								Dest.DWord=gbAltTimerReady;
							else
								Dest.DWord=EQADDR_DOABILITYAVAILABLE[nSkill];
							Dest.Type=pBoolType;
							return true;
						}
					}

Since this server allows skill levels higher then 252 it failed.
But why do the code check the skill level before it checks if the skill is available? Skill level shouldn't have anything to do with it. (I saw that this check is removed in the 20090131 code)


No luck with the CombatAbilityReady[1] thou.
The struct GetCharInfo2()->CombatAbilityTimes[] is just filled with zero's. So I guess the code needs to call the EQ function to get that info.

[caj]

this line is looking for any skill over 252

Code: Select all

if (GetCharInfo2()->Skill[nSkill]>252)

not knowing what your character skill is at or what ever your tring to do but you can change it to 1 or what ever # what you want it to be.


this is what i use for the kick ability

Code: Select all

/if (${Me.AbilityReady[Kick]}) /doability "Kick"

because thats an older mq2 your useing Im not 100% certain that will work either but give it a shot

[Albert]

this line is looking for any skill over 252

Code: Select all

if (GetCharInfo2()->Skill[nSkill]>252)

not knowing what your character skill is at or what ever your tring to do but you can change it to 1 or what ever # what you want it to be.


this is what i use for the kick ability

Code: Select all

/if (${Me.AbilityReady[Kick]}) /doability "Kick"

because thats an older mq2 your useing Im not 100% certain that will work either but give it a shot

Why did you bother to post when you can't contribute anything? You obviously didn't read my posts.

[caj]

then why you asking for help?

If you read my post carefully you would have got the idea to change

if (GetCharInfo2()->Skill[nSkill]>252)

to

if (GetCharInfo2()->Skill[nSkill]>1)

why the hell do you need to know if kick ability is true or false. what your describing is a redundant check... I gave you options that was it. fix it yourself then.

[Albert]

3 reasons to why you shouldn't have posted a reply.

1) Your suggested change will make AbilityReady[] always return FALSE for all abilities that have a skill higher then 1. That is NOT the purpose of that function. So you don't know how it should work.

2) I have already fixed AbilityReady[]. See post nr 2.

3) It is not redundant to know if an Ability is ready to use.


You'r not helping.

[SwiftyMUSE]

Well... as was posted numerous times before about EMU support. Don't look for much of it here, the only version officially supported is the current LIVE release.

[Albert]

Yes, I realize that the majority of the community is running against live. But there are still some of us the are using this old version against EQEmu where there are some servers where it is perfectly legit to use MQ2.

What I really would need is if there is a guide or something about how to find offsets in the eqgame.exe. I remember from way back when I was using MQ2 on live that there was something like that, but I can't seem to find it now.

And this isn't really a support/help post. It's a bug report for an old version of the code.

[Bad Karma]

What I really would need is if there is a guide or something about how to find offsets in the eqgame.exe. I remember from way back when I was using MQ2 on live that there was something like that, but I can't seem to find it now.

Clearly, you didn't look very hard. "What [you] really would need is..." staring you right there in the face!

And this isn't really a support/help post. It's a bug report for an old version of the code.

In which case, it has most likely been resolved in the CURRENT version of the code, and therefore is no longer a valid "bug."

[Albert]

What I really would need is if there is a guide or something about how to find offsets in the eqgame.exe. I remember from way back when I was using MQ2 on live that there was something like that, but I can't seem to find it now.

Clearly, you didn't look very hard. "What [you] really would need is..." staring you right there in the face!

And this isn't really a support/help post. It's a bug report for an old version of the code.

In which case, it has most likely been resolved in the CURRENT version of the code, and therefore is no longer a valid "bug."

So nice of you to post a link to a none existing forum.

[wassup]

What I really would need is if there is a guide or something about how to find offsets in the eqgame.exe. I remember from way back when I was using MQ2 on live that there was something like that, but I can't seem to find it now.

Clearly, you didn't look very hard. "What [you] really would need is..." staring you right there in the face!

And this isn't really a support/help post. It's a bug report for an old version of the code.

In which case, it has most likely been resolved in the CURRENT version of the code, and therefore is no longer a valid "bug."

So nice of you to post a link to a none existing forum.

Yes, it does exist...

[di28889]

key Idea is to use search, also a vast amount of the info on this site is now in VIP

[xyilla]

испо

[xyilla]

96.2

[xyilla]

Bett